mirror of
https://github.com/curl/curl.git
synced 2024-11-27 05:50:21 +08:00
d511ec8b0a
The idea of linking dependencies found to `libcurl.pc` turns out not to work in practice in some cases. Specifically: gss, ldap, mbedtls, libmsh3, rustls A `.pc` may not work or be missing for a couple of reasons: - not all build methods generate it: mbedTLS, Rustls - generated file is broken: msh3 Ref: https://github.com/nibanks/msh3/pull/225 - installed package flavour isn't shipping with one: FreeBSD GSS, OmniOS LDAP, macOS LDAP The effect of such issues shall be subtle in theory, because `libcurl.pc` normally lists these dependencies in the `Requires.private` section meant for static linking. But, e.g. `pkg-config --exists` requires these to be present, and builds sometimes use this check regardless of build type. This bug is not present in `pkgconf`; it only checks for them when `--static` is also passed. Fix these by adding affected `.pc` references to `libcurl.pc` only when we detected the dependency via `pkg-config`. There are a few side-effects of this solution: - references are never added for dependencies where curl doesn't implement `pkg-config` detection. These are: - autotools: ldap, mbedtls, msh3 - cmake: ldap (pending #15273) - generated `libcurl.pc` depends on the build-time environment. - generated `libcurl.pc` depends on curl build tool (cmake, autotools). - generated `libcurl.pc` depends on curl build implementation details. Make an exception for GNU GSS, where I blindly guess that `gss.pc` is always available, as no issues were reported. Other, not mentioned, dependencies continue to be added regardless of the detection method. Reported-by: Harmen Stoppels, Thomas, Daniel Engberg, Andy Fiddaman Fixes #15469 Fixes #15507 Fixes #15535 Fixes https://github.com/curl/curl/pull/15163#issuecomment-2473358444 Closes #15573
70 lines
2.3 KiB
CMake
70 lines
2.3 KiB
CMake
#***************************************************************************
|
|
# _ _ ____ _
|
|
# Project ___| | | | _ \| |
|
|
# / __| | | | |_) | |
|
|
# | (__| |_| | _ <| |___
|
|
# \___|\___/|_| \_\_____|
|
|
#
|
|
# Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
#
|
|
# This software is licensed as described in the file COPYING, which
|
|
# you should have received as part of this distribution. The terms
|
|
# are also available at https://curl.se/docs/copyright.html.
|
|
#
|
|
# You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
# copies of the Software, and permit persons to whom the Software is
|
|
# furnished to do so, under the terms of the COPYING file.
|
|
#
|
|
# This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
# KIND, either express or implied.
|
|
#
|
|
# SPDX-License-Identifier: curl
|
|
#
|
|
###########################################################################
|
|
# Find the msh3 library
|
|
#
|
|
# Input variables:
|
|
#
|
|
# - `MSH3_INCLUDE_DIR`: The msh3 include directory.
|
|
# - `MSH3_LIBRARY`: Path to `msh3` library.
|
|
#
|
|
# Result variables:
|
|
#
|
|
# - `MSH3_FOUND`: System has msh3.
|
|
# - `MSH3_INCLUDE_DIRS`: The msh3 include directories.
|
|
# - `MSH3_LIBRARIES`: The msh3 library names.
|
|
# - `MSH3_LIBRARY_DIRS`: The msh3 library directories.
|
|
# - `MSH3_PC_REQUIRES`: The msh3 pkg-config packages.
|
|
# - `MSH3_CFLAGS`: Required compiler flags.
|
|
# - `MSH3_VERSION`: Version of msh3.
|
|
|
|
if(CURL_USE_PKGCONFIG AND
|
|
NOT DEFINED MSH3_INCLUDE_DIR AND
|
|
NOT DEFINED MSH3_LIBRARY)
|
|
find_package(PkgConfig QUIET)
|
|
pkg_check_modules(MSH3 "libmsh3")
|
|
endif()
|
|
|
|
if(MSH3_FOUND)
|
|
set(MSH3_PC_REQUIRES "libmsh3")
|
|
string(REPLACE ";" " " MSH3_CFLAGS "${MSH3_CFLAGS}")
|
|
message(STATUS "Found MSH3 (via pkg-config): ${MSH3_INCLUDE_DIRS} (found version \"${MSH3_VERSION}\")")
|
|
else()
|
|
find_path(MSH3_INCLUDE_DIR NAMES "msh3.h")
|
|
find_library(MSH3_LIBRARY NAMES "msh3")
|
|
|
|
include(FindPackageHandleStandardArgs)
|
|
find_package_handle_standard_args(MSH3
|
|
REQUIRED_VARS
|
|
MSH3_INCLUDE_DIR
|
|
MSH3_LIBRARY
|
|
)
|
|
|
|
if(MSH3_FOUND)
|
|
set(MSH3_INCLUDE_DIRS ${MSH3_INCLUDE_DIR})
|
|
set(MSH3_LIBRARIES ${MSH3_LIBRARY})
|
|
endif()
|
|
|
|
mark_as_advanced(MSH3_INCLUDE_DIR MSH3_LIBRARY)
|
|
endif()
|