mirror of
https://github.com/curl/curl.git
synced 2025-01-06 13:44:52 +08:00
c04504885d
Sources used `lib/curlx.h` with both `ENABLE_CURLX_PRINTF` set and unset
before including it.
In a cmake "unity" batch where the first included source had it unset,
the next sources did not get the macros requested with
`ENABLE_CURLX_PRINTF` because `lib/curl.x` had already been included
without them.
Fix it by by making the macros enabled permanently and globally for
internal sources, and dropping `ENABLE_CURLX_PRINTF`.
This came up while testing unity builds with smaller batches. The full,
default unity build where all `src` is bundled up in a single unit, was
not affected.
Fixes:
```
$ cmake -B build -DCMAKE_UNITY_BUILD=ON -DCMAKE_UNITY_BUILD_BATCH_SIZE=15
$ make -C build
...
curl/src/tool_getparam.c: In function ‘getparameter’:
curl/src/tool_getparam.c:2409:11: error: implicit declaration of function ‘msnprintf’; did you mean ‘vsnprintf’? [-Wimplicit-function-declaration]
2409 | msnprintf(buffer, sizeof(buffer), "%" CURL_FORMAT_CURL_OFF_T "-",
| ^~~~~~~~~
| vsnprintf
curl/src/tool_getparam.c:2409:11: warning: nested extern declaration of ‘msnprintf’ [-Wnested-externs]
[...]
```
Reported-by: Daniel Stenberg
Bug: https://github.com/curl/curl/pull/14626#issuecomment-2301663491
Closes #14632
115 lines
3.5 KiB
C
115 lines
3.5 KiB
C
#ifndef HEADER_CURL_CURLX_H
|
|
#define HEADER_CURL_CURLX_H
|
|
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
|
|
/*
|
|
* Defines protos and includes all header files that provide the curlx_*
|
|
* functions. The curlx_* functions are not part of the libcurl API, but are
|
|
* stand-alone functions whose sources can be built and linked by apps if need
|
|
* be.
|
|
*/
|
|
|
|
#include <curl/mprintf.h>
|
|
/* this is still a public header file that provides the curl_mprintf()
|
|
functions while they still are offered publicly. They will be made library-
|
|
private one day */
|
|
|
|
#include "strcase.h"
|
|
/* "strcase.h" provides the strcasecompare protos */
|
|
|
|
#include "strtoofft.h"
|
|
/* "strtoofft.h" provides this function: curlx_strtoofft(), returns a
|
|
curl_off_t number from a given string.
|
|
*/
|
|
|
|
#include "nonblock.h"
|
|
/* "nonblock.h" provides curlx_nonblock() */
|
|
|
|
#include "warnless.h"
|
|
/* "warnless.h" provides functions:
|
|
|
|
curlx_ultous()
|
|
curlx_ultouc()
|
|
curlx_uztosi()
|
|
*/
|
|
|
|
#include "curl_multibyte.h"
|
|
/* "curl_multibyte.h" provides these functions and macros:
|
|
|
|
curlx_convert_UTF8_to_wchar()
|
|
curlx_convert_wchar_to_UTF8()
|
|
curlx_convert_UTF8_to_tchar()
|
|
curlx_convert_tchar_to_UTF8()
|
|
curlx_unicodefree()
|
|
*/
|
|
|
|
#include "version_win32.h"
|
|
/* "version_win32.h" provides curlx_verify_windows_version() */
|
|
|
|
/* Now setup curlx_ * names for the functions that are to become curlx_ and
|
|
be removed from a future libcurl official API:
|
|
curlx_getenv
|
|
curlx_mprintf (and its variations)
|
|
curlx_strcasecompare
|
|
curlx_strncasecompare
|
|
|
|
*/
|
|
|
|
#define curlx_mvsnprintf curl_mvsnprintf
|
|
#define curlx_msnprintf curl_msnprintf
|
|
#define curlx_maprintf curl_maprintf
|
|
#define curlx_mvaprintf curl_mvaprintf
|
|
#define curlx_msprintf curl_msprintf
|
|
#define curlx_mprintf curl_mprintf
|
|
#define curlx_mfprintf curl_mfprintf
|
|
#define curlx_mvsprintf curl_mvsprintf
|
|
#define curlx_mvprintf curl_mvprintf
|
|
#define curlx_mvfprintf curl_mvfprintf
|
|
|
|
/* We define all "standard" printf() functions to use the curlx_* version
|
|
instead. It makes the source code transparent and easier to
|
|
understand/patch. Undefine them first. */
|
|
# undef printf
|
|
# undef fprintf
|
|
# undef sprintf
|
|
# undef msnprintf
|
|
# undef vprintf
|
|
# undef vfprintf
|
|
# undef mvsnprintf
|
|
# undef aprintf
|
|
# undef vaprintf
|
|
|
|
# define printf curlx_mprintf
|
|
# define fprintf curlx_mfprintf
|
|
# define sprintf curlx_msprintf
|
|
# define msnprintf curlx_msnprintf
|
|
# define vprintf curlx_mvprintf
|
|
# define vfprintf curlx_mvfprintf
|
|
# define mvsnprintf curlx_mvsnprintf
|
|
# define aprintf curlx_maprintf
|
|
# define vaprintf curlx_mvaprintf
|
|
|
|
#endif /* HEADER_CURL_CURLX_H */
|