curl/lib
Daniel Stenberg 5cd524df18 singleipconnect: return OK even when Curl_socket() fails
Commit 9109cdec11 brought this regression (shipped since 7.24.0).

The singleipconnect() function must not return an error if Curl_socket()
returns an error. It should then simply return OK and pass a SOCKET_BAD
back simply because that is how the user of this function expects it to
work and something else is not fine.

Reported by: Blaise Potard
Bug: http://curl.haxx.se/bug/view.cgi?id=3516508
2012-04-19 23:31:50 +02:00
..
.gitignore gitignore: ignore the symbol versioning file 2011-12-20 11:07:23 +01:00
amigaos.c curl tool: use configuration files from lib directory 2012-04-06 23:37:05 +02:00
amigaos.h curl tool: use configuration files from lib directory 2012-04-06 23:37:05 +02:00
arpa_telnet.h TELNET: improved treatment of options 2011-11-25 10:46:49 +01:00
asyn-ares.c resolve with c-ares: don't resolve IPv6 when not working 2012-03-13 22:52:39 +01:00
asyn-thread.c win32-threaded-resolver: stop using a dummy socket 2012-01-04 23:16:30 +01:00
asyn.h fix a bunch of MSVC compiler warnings 2011-09-03 16:07:09 +02:00
axtls.c stdio.h, stdlib.h, string.h, stdarg.h and ctype.h inclusion done in setup_once.h 2011-07-26 17:23:27 +02:00
axtls.h return code cleanup: build, init and run-time errors 2011-04-05 15:14:02 +02:00
base64.c fix several compiler warnings 2012-03-22 04:54:04 +01:00
checksrc.pl checksrc: detect "}else" uses as well 2011-09-07 22:45:43 +02:00
CMakeLists.txt CMake: improve library search, implement install. 2011-04-28 10:12:33 +02:00
config-amigaos.h curl tool: use configuration files from lib directory 2012-04-06 23:37:05 +02:00
config-dos.h errno.h inclusion conditionally done in setup_once.h 2011-07-24 04:39:43 +02:00
config-mac.h curl tool: use configuration files from lib directory 2012-04-06 23:37:05 +02:00
config-os400.h build adjustments: CURL_HIDDEN_SYMBOLS no longer defined in config files 2012-04-11 19:33:54 +02:00
config-riscos.h curl tool: use configuration files from lib directory 2012-04-06 23:37:05 +02:00
config-symbian.h nss: unconditionally require PK11_CreateGenericObject() 2012-04-13 12:19:36 +02:00
config-tpf.h configure: Windows cross-compilation fixes 2012-04-09 21:24:16 +02:00
config-vms.h errno.h inclusion conditionally done in setup_once.h 2011-07-24 04:39:43 +02:00
config-vxworks.h nss: unconditionally require PK11_CreateGenericObject() 2012-04-13 12:19:36 +02:00
config-win32.h Changed Windows 64bit OS define to x86_64. 2011-09-20 12:32:04 +02:00
config-win32ce.h errno.h inclusion conditionally done in setup_once.h - followup 2011-07-25 03:10:24 +02:00
connect.c singleipconnect: return OK even when Curl_socket() fails 2012-04-19 23:31:50 +02:00
connect.h timeleft_accept: ack global timeout, moved to ftp.c 2011-12-20 20:55:54 +01:00
content_encoding.c zlib: ensure user provided memory functions are used by zlib, when given 2011-08-21 13:24:46 +02:00
content_encoding.h fix a bunch of MSVC compiler warnings 2011-09-03 16:07:09 +02:00
cookie.c OOM handling/cleanup slight adjustments 2011-10-11 19:41:30 +02:00
cookie.h fix a bunch of MSVC compiler warnings 2011-09-03 16:07:09 +02:00
curl_addrinfo.c stdio.h, stdlib.h, string.h, stdarg.h and ctype.h inclusion done in setup_once.h 2011-07-26 17:23:27 +02:00
curl_addrinfo.h CURLOPT_RESOLVE: added 2010-11-08 08:56:21 +01:00
curl_base64.h base64: fix Curl_base64_encode and Curl_base64_decode interfaces 2011-08-24 08:10:30 +02:00
curl_config.h.cmake nss: unconditionally require PK11_CreateGenericObject() 2012-04-13 12:19:36 +02:00
curl_fnmatch.c unittest: mark all unit tested functions 2011-06-10 14:40:46 +02:00
curl_fnmatch.h
curl_gethostname.c curl_gethostname.c: fix signed/unsigned comparison and avoid a double copy 2011-10-13 23:00:24 +02:00
curl_gethostname.h HOSTNAME_MAX: Moved to curl_gethostname.h 2011-09-25 23:58:47 +02:00
curl_gssapi.c curl_gssapi: add a missing include of sendf.h 2011-08-03 18:07:07 +02:00
curl_gssapi.h curl_gssapi: add a missing include of sendf.h 2011-08-03 18:07:07 +02:00
curl_hmac.h
curl_ldap.h Fixed libcurl to honour the --disable-ldaps configure option 2011-03-07 17:45:33 -08:00
curl_md4.h
curl_md5.h md5: Add support for calculating the md5 sum of buffers incrementally 2012-03-31 22:31:16 +01:00
curl_memory.h
curl_memrchr.c source cleanup: unify look, style and indent levels 2011-04-27 09:09:35 +02:00
curl_memrchr.h
curl_ntlm_core.c Add support for using nettle instead of gcrypt as gnutls backend 2011-11-19 22:23:14 +01:00
curl_ntlm_core.h NTLM: header inclusion cleanup 2011-08-28 07:15:46 +02:00
curl_ntlm_msgs.c add LF termination to infof() trace string 2012-01-16 21:14:05 +01:00
curl_ntlm_msgs.h sspi build fix 2011-10-03 23:28:17 +02:00
curl_ntlm_wb.c fix a bunch of MSVC compiler warnings 2011-09-03 16:07:09 +02:00
curl_ntlm_wb.h NTLM: header inclusion cleanup 2011-08-28 07:15:46 +02:00
curl_ntlm.c Curl_ntlm_create_typeX_message: Added the outlen parameter 2011-10-03 23:28:17 +02:00
curl_ntlm.h fix a bunch of MSVC compiler warnings 2011-09-03 16:07:09 +02:00
curl_rand.c
curl_rand.h
curl_rtmp.c curl_multi_fdset: correct fdset with FTP PORT use 2011-10-21 23:36:54 +02:00
curl_rtmp.h
curl_sspi.c Use own typedef as workaround for broken sspi.h header (f.e. Watcom). 2010-09-02 00:38:16 +02:00
curl_sspi.h Fix a couple of spelling errors in lib/ 2011-04-21 07:55:53 -07:00
curl_threads.c stdio.h, stdlib.h, string.h, stdarg.h and ctype.h inclusion done in setup_once.h 2011-07-26 17:23:27 +02:00
curl_threads.h
curlx.h Typo fixes. 2010-12-21 22:39:56 +01:00
cyassl.c cyassl: update to CyaSSL 2.0.x API 2012-02-14 19:49:54 +01:00
cyassl.h fix a bunch of MSVC compiler warnings 2011-09-03 16:07:09 +02:00
dict.c add LF termination to infof() trace string 2012-01-16 21:14:05 +01:00
dict.h
easy.c curl tool: use configuration files from lib directory 2012-04-06 23:37:05 +02:00
easyif.h CURL_DOES_CONVERSIONS: cleanup 2011-04-20 00:50:07 +02:00
escape.c URL sanitize: reject URLs containing bad data 2012-01-24 08:54:26 +01:00
escape.h URL sanitize: reject URLs containing bad data 2012-01-24 08:54:26 +01:00
file.c query-part: ignore the URI part for given protocols 2011-11-24 23:31:19 +01:00
file.h
fileinfo.c OOM handling/cleanup slight adjustments 2011-10-11 19:41:30 +02:00
fileinfo.h
firefox-db2pem.sh
formdata.c formdata.c: OOM handling fixes 2011-12-21 15:39:44 +01:00
formdata.h formdata: provide error message 2010-10-20 14:57:43 +02:00
ftp.c ftp.c: ftplistparser related OOM handling fix 2012-04-04 17:31:11 +02:00
ftp.h timeleft_accept: ack global timeout, moved to ftp.c 2011-12-20 20:55:54 +01:00
ftplistparser.c remove short-lived CURL_WRITEFUNC_OUT_OF_MEMORY 2011-09-26 13:05:42 +02:00
ftplistparser.h
getenv.c stdio.h, stdlib.h, string.h, stdarg.h and ctype.h inclusion done in setup_once.h 2011-07-26 17:23:27 +02:00
getinfo.c Take in account that CURLAUTH_* bitmasks are now 'unsigned long' - follow-up 2012-04-19 16:31:11 +02:00
getinfo.h
gopher.c curl_multi_fdset: correct fdset with FTP PORT use 2011-10-21 23:36:54 +02:00
gopher.h Gopher protocol support (initial release) 2010-08-25 14:19:58 +02:00
gtls.c gnutls: enforced use of SSLv3 2012-01-24 08:54:26 +01:00
gtls.h NTLM: header inclusion cleanup follow-up 2011-08-28 11:29:09 +02:00
hash.c hash.c: fix OOM triggered segfault 2011-12-25 11:35:45 +01:00
hash.h
hmac.c source cleanup: unify look, style and indent levels 2011-04-27 09:09:35 +02:00
hostasyn.c stdio.h, stdlib.h, string.h, stdarg.h and ctype.h inclusion done in setup_once.h 2011-07-26 17:23:27 +02:00
hostip4.c hostip: avoid getaddrinfo when c-ares is used 2012-01-12 23:13:19 +01:00
hostip6.c fix a bunch of MSVC compiler warnings 2011-09-03 16:07:09 +02:00
hostip.c hostip.c: fix potential write past the end of string buffer 2012-01-02 13:44:56 +01:00
hostip.h CURLOPT_RESOLVE: avoid adding already present host names 2011-12-31 10:45:27 +01:00
hostsyn.c CURLOPT_DNS_SERVERS: set name servers if possible 2011-11-17 22:52:33 +01:00
http_chunks.c fix bool variables checking and assignment 2011-09-05 20:46:09 +02:00
http_chunks.h
http_digest.c fix several compiler warnings 2012-03-22 04:54:04 +01:00
http_digest.h fix a bunch of MSVC compiler warnings 2011-09-03 16:07:09 +02:00
http_negotiate_sspi.c http_negotiate_sspi.c: fix compiler warning 2012-01-13 13:34:43 +01:00
http_negotiate.c add LF termination to infof() trace string 2012-01-16 21:14:05 +01:00
http_negotiate.h HTTP: HTTP Negotiate authentication using SSPI 2011-01-07 23:48:40 +01:00
http_proxy.c CONNECT: fix multi interface regression 2012-03-22 00:12:37 +01:00
http_proxy.h http_proxy.h: fix builds with proxy or http disabled 2012-03-22 17:27:14 +01:00
http.c Take in account that CURLAUTH_* bitmasks are now 'unsigned long' 2012-04-18 23:04:35 +02:00
http.h privatise: make private functions static 2011-06-03 19:51:08 +02:00
idn_win32.c stdio.h, stdlib.h, string.h, stdarg.h and ctype.h inclusion done in setup_once.h 2011-07-26 17:23:27 +02:00
if2ip.c if2ip.[ch]: fix compilation with MinGW 2011-12-13 18:37:33 +01:00
if2ip.h if2ip.[ch]: fix compilation with MinGW 2011-12-13 18:37:33 +01:00
imap.c email: Moved server greeting responses into separate functions 2012-03-24 11:55:34 +00:00
imap.h source cleanup: unify look, style and indent levels 2011-04-27 09:09:35 +02:00
inet_ntop.c stdio.h, stdlib.h, string.h, stdarg.h and ctype.h inclusion done in setup_once.h 2011-07-26 17:23:27 +02:00
inet_ntop.h
inet_pton.c stdio.h, stdlib.h, string.h, stdarg.h and ctype.h inclusion done in setup_once.h 2011-07-26 17:23:27 +02:00
inet_pton.h
krb4.c add missing semicolons 2011-08-24 13:58:37 +02:00
krb4.h source cleanup: unify look, style and indent levels 2011-04-27 09:09:35 +02:00
krb5.c krb5.c: fix compiler warning: variable set but not used 2012-01-04 19:11:54 +01:00
ldap.c curl_multi_fdset: correct fdset with FTP PORT use 2011-10-21 23:36:54 +02:00
libcurl.def
libcurl.imp Added NetWare export. 2012-04-13 01:24:34 +02:00
libcurl.plist removed trailing whitespace 2011-12-30 03:36:18 +01:00
libcurl.rc
libcurl.vers.in configure: add symbols versioning option 2011-12-19 23:25:36 +01:00
llist.c OOM handling/cleanup slight adjustments 2011-10-11 19:41:30 +02:00
llist.h llist: hide Curl_llist_init 2010-08-10 11:07:38 +02:00
Makefile.am build adjustments: commit 9e24b9c7 follow-up 2012-04-17 13:29:12 +02:00
makefile.amiga curl tool: use configuration files from lib directory - follow-up I 2012-04-07 00:31:24 +02:00
Makefile.b32 lib/Makefile.b32: updates 2011-04-07 15:17:58 +02:00
makefile.dj Changed email per Gisle's request. 2011-04-16 00:11:43 +02:00
Makefile.inc curl tool: use configuration files from lib directory - follow-up I 2012-04-07 00:31:24 +02:00
Makefile.m32 Updated dependency lib versions (2nd try). 2012-04-12 20:51:29 +02:00
Makefile.netware Updated dependency lib versions (2nd try). 2012-04-12 20:51:29 +02:00
Makefile.vc6 Updated dependency lib versions (2nd try). 2012-04-12 20:51:29 +02:00
Makefile.vxworks Fix a couple of spelling errors in lib/ 2011-04-21 07:55:53 -07:00
Makefile.Watcom Updated dependency lib versions (2nd try). 2012-04-12 20:51:29 +02:00
md4.c fix several compiler warnings 2012-03-20 18:28:24 +01:00
md5.c md5: Add support for calculating the md5 sum of buffers incrementally 2012-03-31 22:31:16 +01:00
memdebug.c fix a bunch of MSVC compiler warnings 2011-09-03 16:07:09 +02:00
memdebug.h Make Curl_safefree() macro assign NULL to given pointer when free'd 2011-09-15 17:35:23 +02:00
mk-ca-bundle.pl Revert "access the CA source file using HTTPS" 2012-04-04 23:54:02 +02:00
mk-ca-bundle.vbs Fix to skip untrusted certs. 2011-11-08 05:46:46 +01:00
mprintf.c MemoryTracking: fix logging of free() calls done where Curl_safefree is called 2011-09-02 19:40:53 +02:00
msvcproj.foot
msvcproj.head
multi.c CONNECT: fix multi interface regression 2012-03-22 00:12:37 +01:00
multiif.h multi: support timeouts 2010-08-15 13:16:39 +02:00
netrc.c stdio.h, stdlib.h, string.h, stdarg.h and ctype.h inclusion done in setup_once.h 2011-07-26 17:23:27 +02:00
netrc.h test1304: Added some unit tests for Curl_parsenetrc. 2011-02-10 07:38:48 -08:00
non-ascii.c source cleanup: unify look, style and indent levels 2011-04-27 09:09:35 +02:00
non-ascii.h fix a bunch of MSVC compiler warnings 2011-09-03 16:07:09 +02:00
nonblock.c lwip: basic checks and macros for compatiblity 2012-03-17 23:02:21 +01:00
nonblock.h
nss.c nss.c: fix compiler warning 2012-04-16 22:37:12 +02:00
nssg.h fix a bunch of MSVC compiler warnings 2011-09-03 16:07:09 +02:00
nwlib.c stdio.h, stdlib.h, string.h, stdarg.h and ctype.h inclusion done in setup_once.h 2011-07-26 17:23:27 +02:00
nwos.c stdio.h, stdlib.h, string.h, stdarg.h and ctype.h inclusion done in setup_once.h 2011-07-26 17:23:27 +02:00
openldap.c includes: remove inclusion of unused file http_proxy.h 2012-03-09 00:05:24 +01:00
parsedate.c parsedate.c: fix a numeric overflow 2012-03-22 15:54:34 +01:00
parsedate.h parsedate: turn private and static 2011-06-03 19:31:32 +02:00
pingpong.c pingpong: change two comments wrongly referring "FTP" 2011-11-06 17:38:36 +01:00
pingpong.h pingpong.c: fix Curl_pp_vsendf() arbitrary restrictions on command length 2011-08-29 14:27:06 +02:00
polarssl.c PolarSSL: correct return code for CRL matches 2012-04-06 15:10:59 +02:00
polarssl.h PolarSSL: add support for asynchronous connect 2012-04-05 00:18:34 +02:00
pop3.c pop3: Reworked the command sending and handling 2012-04-02 23:24:00 +01:00
pop3.h pop3: Reworked the command sending and handling 2012-04-02 23:24:00 +01:00
progress.c HTTP: reset expected DL/UL sizes on redirects 2012-04-01 00:07:24 +02:00
progress.h HTTP: reset expected DL/UL sizes on redirects 2012-04-01 00:07:24 +02:00
qssl.c stdio.h, stdlib.h, string.h, stdarg.h and ctype.h inclusion done in setup_once.h 2011-07-26 17:23:27 +02:00
qssl.h fix a bunch of MSVC compiler warnings 2011-09-03 16:07:09 +02:00
rawstr.c source cleanup: unify look, style and indent levels 2011-04-27 09:09:35 +02:00
rawstr.h source cleanup: unify look, style and indent levels 2011-04-27 09:09:35 +02:00
README.ares README.ares: we know require c-ares 1.6.0 2010-09-30 23:14:58 +02:00
README.curl_off_t
README.curlx
README.encoding transfer-encoding: document the options 2011-04-18 19:46:21 +02:00
README.hostip
README.httpauth
README.memoryleak
README.multi_socket
README.pingpong
README.pipelining
rtsp.c curl_multi_fdset: correct fdset with FTP PORT use 2011-10-21 23:36:54 +02:00
rtsp.h RTSP: cleanups 2011-05-05 16:53:05 +02:00
security.c include limits.h for INT_MAX 2011-08-24 14:00:42 +02:00
select.c Curl_socket_check: enlarge poll struct array to 3 2011-12-20 23:33:54 +01:00
select.h sockets: new Curl_socket_check() can wait for 3 sockets 2011-12-20 20:30:02 +01:00
sendf.c remove short-lived CURL_WRITEFUNC_OUT_OF_MEMORY 2011-09-26 13:05:42 +02:00
sendf.h fix a bunch of MSVC compiler warnings 2011-09-03 16:07:09 +02:00
setup_once.h setup_once.h: tighten requirements for stdbool.h header inclusion 2012-04-14 15:41:38 +02:00
setup-os400.h
setup.h headers: require GCC 2.7 or newer in order to allow attribute GCC'isms usage 2012-04-14 15:12:30 +02:00
share.c ssl session caching: fix compiler warnings 2012-01-18 23:42:39 +01:00
share.h ssl session caching: fix compiler warnings 2012-01-18 23:42:39 +01:00
slist.c libcurl: some OOM handling fixes 2011-10-07 20:50:57 +02:00
slist.h
smtp.c smtp.c: fix compiler warnings 2012-04-04 17:24:30 +02:00
smtp.h smtp: Add support for DIGEST-MD5 authentication 2012-03-31 22:31:19 +01:00
sockaddr.h
socks_gssapi.c SOCKS: fix the connect timeout 2011-08-08 11:23:31 +02:00
socks_sspi.c SOCKS: fix the connect timeout 2011-08-08 11:23:31 +02:00
socks.c fix bool variables checking and assignment 2011-09-05 20:46:09 +02:00
socks.h SOCKS: fix the connect timeout 2011-08-08 11:23:31 +02:00
speedcheck.c Curl_speedcheck: don't mistakenly clear Curl_expire() 2011-09-08 08:39:53 +02:00
speedcheck.h
splay.c splay: add unit tests 2011-06-10 20:19:35 +02:00
splay.h fix a bunch of MSVC compiler warnings 2011-09-03 16:07:09 +02:00
ssh.c SSH: public key can now be an empty string 2012-04-01 20:22:37 +02:00
ssh.h rectify comment 2011-11-25 15:02:43 +01:00
sslgen.c ssl session caching: fix compiler warnings 2012-01-18 23:42:39 +01:00
sslgen.h ssl session caching: fix compiler warnings 2012-01-18 23:42:39 +01:00
ssluse.c OpenSSL: Made cert hostname check conform to RFC 6125 2012-04-01 20:10:37 +02:00
ssluse.h NTLM: header inclusion cleanup follow-up 2011-08-28 11:29:09 +02:00
strdup.c stdio.h, stdlib.h, string.h, stdarg.h and ctype.h inclusion done in setup_once.h 2011-07-26 17:23:27 +02:00
strdup.h
strequal.c stdio.h, stdlib.h, string.h, stdarg.h and ctype.h inclusion done in setup_once.h 2011-07-26 17:23:27 +02:00
strequal.h
strerror.c FTP: perform active connections non-blocking 2011-12-20 20:30:02 +01:00
strerror.h
strtok.c stdio.h, stdlib.h, string.h, stdarg.h and ctype.h inclusion done in setup_once.h 2011-07-26 17:23:27 +02:00
strtok.h
strtoofft.c stdio.h, stdlib.h, string.h, stdarg.h and ctype.h inclusion done in setup_once.h 2011-07-26 17:23:27 +02:00
strtoofft.h Typo fixes. 2010-12-21 22:39:56 +01:00
telnet.c fix some compiler warnings 2012-03-16 19:06:34 +01:00
telnet.h
tftp.c hostip: avoid getaddrinfo when c-ares is used 2012-01-12 23:13:19 +01:00
tftp.h
timeval.c tvdiff_secs(): sub-zero time difference adjustment 2011-11-25 13:51:55 +01:00
timeval.h
transfer.c CURLOPT_POSTREDIR: also allow 303 to do POST on the redirected URL 2012-04-05 23:29:21 +02:00
transfer.h source cleanup: unify look, style and indent levels 2011-04-27 09:09:35 +02:00
url.c url.c: CURLOPT_HTTPAUTH and CURLOPT_PROXYAUTH fixes 2012-04-19 00:35:44 +02:00
url.h non-blocking active FTP: cleanup multi state usage 2011-12-20 20:30:02 +01:00
urldata.h Take in account that CURLAUTH_* bitmasks are now 'unsigned long' 2012-04-18 23:04:35 +02:00
vc6libcurl.dsw
vc8proj.foot Use DOS line-endings. 2007-01-29 19:08:04 +00:00
vc8proj.head
version.c NTLM_WB: fix disabling of NTLM_WB when NTLM is disabled 2011-09-22 00:24:02 +02:00
warnless.c fix some compiler warnings 2012-03-25 18:30:16 +02:00
warnless.h fix some compiler warnings 2012-03-25 18:30:16 +02:00
wildcard.c stdio.h, stdlib.h, string.h, stdarg.h and ctype.h inclusion done in setup_once.h 2011-07-26 17:23:27 +02:00
wildcard.h

HTTP Pipelining with libcurl
============================

Background

Since pipelining implies that one or more requests are sent to a server before
the previous response(s) have been received, we only support it for multi
interface use.

Considerations

When using the multi interface, you create one easy handle for each transfer.
Bascially any number of handles can be created, added and used with the multi
interface - simultaneously. It is an interface designed to allow many
simultaneous transfers while still using a single thread. Pipelining does not
change any of these details.

API

We've added a new option to curl_multi_setopt() called CURLMOPT_PIPELINING
that enables "attempted pipelining" and then all easy handles used on that
handle will attempt to use an existing pipeline.

Details

- A pipeline is only created if a previous connection exists to the same IP
  address that the new request is being made to use.

- Pipelines are only supported for HTTP(S) as no other currently supported
  protocol has features resemembling this, but we still name this feature
  plain 'pipelining' to possibly one day support it for other protocols as
  well.

- HTTP Pipelining is for GET and HEAD requests only.

- When a pipeline is in use, we must take precautions so that when used easy
  handles (i.e those who still wait for a response) are removed from the multi
  handle, we must deal with the outstanding response nicely.

- Explicitly asking for pipelining handle X and handle Y won't be supported.
  It isn't easy for an app to do this association. The lib should probably
  still resolve the second one properly to make sure that they actually _can_
  be considered for pipelining. Also, asking for explicit pipelining on handle
  X may be tricky when handle X get a closed connection.

- We need options to control max pipeline length, and probably how to behave
  if we reach that limit. As was discussed on the list, it can probably be
  made very complicated, so perhaps we can think of a way to pass all
  variables involved to a callback and let the application decide how to act
  in specific situations. Either way, these fancy options are only interesting
  to work on when everything is working and we have working apps to test with.