mirror/curl
2
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2024-12-27 06:59:43 +08:00
Code Issues Packages Projects Releases Wiki Activity
3829759bd0
curl/lib/vtls
History
Viktor Szakats 3829759bd0
build: enable missing OpenSSF-recommended warnings, with fixes 
https://best.openssf.org/Compiler-Hardening-Guides/Compiler-Options-Hardening-Guide-for-C-and-C++.html
as of 2023-11-29 [1].

Enable new recommended warnings (except `-Wsign-conversion`):

- enable `-Wformat=2` for clang (in both cmake and autotools).
- add `CURL_PRINTF()` internal attribute and mark functions accepting
  printf arguments with it. This is a copy of existing
  `CURL_TEMP_PRINTF()` but using `__printf__` to make it compatible
  with redefinting the `printf` symbol:
  https://gcc.gnu.org/onlinedocs/gcc-3.0.4/gcc_5.html#SEC94
- fix `CURL_PRINTF()` and existing `CURL_TEMP_PRINTF()` for
  mingw-w64 and enable it on this platform.
- enable `-Wimplicit-fallthrough`.
- enable `-Wtrampolines`.
- add `-Wsign-conversion` commented with a FIXME.
- cmake: enable `-pedantic-errors` the way we do it with autotools.
  Follow-up to d5c0351055 #2747
- lib/curl_trc.h: use `CURL_FORMAT()`, this also fixes it to enable format
  checks. Previously it was always disabled due to the internal `printf`
  macro.

Fix them:

- fix bug where an `set_ipv6_v6only()` call was missed in builds with
  `--disable-verbose` / `CURL_DISABLE_VERBOSE_STRINGS=ON`.
- add internal `FALLTHROUGH()` macro.
- replace obsolete fall-through comments with `FALLTHROUGH()`.
- fix fallthrough markups: Delete redundant ones (showing up as
  warnings in most cases). Add missing ones. Fix indentation.
- silence `-Wformat-nonliteral` warnings with llvm/clang.
- fix one `-Wformat-nonliteral` warning.
- fix new `-Wformat` and `-Wformat-security` warnings.
- fix `CURL_FORMAT_SOCKET_T` value for mingw-w64. Also move its
  definition to `lib/curl_setup.h` allowing use in `tests/server`.
- lib: fix two wrongly passed string arguments in log outputs.
  Co-authored-by: Jay Satiro
- fix new `-Wformat` warnings on mingw-w64.

[1] 56c0fde389/docs/Compiler-Hardening-Guides/Compiler-Options-Hardening-Guide-for-C-and-C%2B%2B.md

Closes #12489
2023-12-16 13:12:37 +00:00
..
bearssl.c lib: reduce use of strncpy 2023-12-11 23:29:02 +01:00
bearssl.h
gtls.c lib: strndup/memdup instead of malloc, memcpy and null-terminate 2023-12-07 08:47:44 +01:00
gtls.h vtls/vquic, keep peer name information together 2023-11-19 13:55:22 +01:00
hostcheck.c
hostcheck.h
keylog.c windows: use built-in _WIN32 macro to detect Windows 2023-11-22 15:42:25 +00:00
keylog.h
mbedtls_threadlock.c misc: fix -Walloc-size warnings 2023-11-11 23:35:47 +01:00
mbedtls_threadlock.h
mbedtls.c lib: rename Curl_strndup to Curl_memdup0 to avoid misunderstanding 2023-12-08 17:22:33 +01:00
mbedtls.h
openssl.c build: enable missing OpenSSF-recommended warnings, with fixes 2023-12-16 13:12:37 +00:00
openssl.h vtls: consistently use typedef names for OpenSSL structs 2023-12-01 23:00:43 +01:00
rustls.c build: enable missing OpenSSF-recommended warnings, with fixes 2023-12-16 13:12:37 +00:00
rustls.h
schannel_int.h schannel: add CA cache support for files and memory blobs 2023-11-11 04:11:11 -05:00
schannel_verify.c build: enable missing OpenSSF-recommended warnings, with fixes 2023-12-16 13:12:37 +00:00
schannel.c build: enable missing OpenSSF-recommended warnings, with fixes 2023-12-16 13:12:37 +00:00
schannel.h
sectransp.c lib: rename Curl_strndup to Curl_memdup0 to avoid misunderstanding 2023-12-08 17:22:33 +01:00
sectransp.h
vtls_int.h openssl: when a session-ID is reused, skip OCSP stapling 2023-11-28 22:59:10 +01:00
vtls.c lib: reduce use of strncpy 2023-12-11 23:29:02 +01:00
vtls.h vtls: remove the Curl_cft_ssl_proxy object if CURL_DISABLE_PROXY 2023-12-07 09:31:05 +01:00
wolfssl.c build: enable missing OpenSSF-recommended warnings, with fixes 2023-12-16 13:12:37 +00:00
wolfssl.h
x509asn1.c build: enable missing OpenSSF-recommended warnings, with fixes 2023-12-16 13:12:37 +00:00
x509asn1.h