mirror of
https://github.com/curl/curl.git
synced 2024-12-27 06:59:43 +08:00
2100d9fde2
The goal of this patch is to avoid unnecessary feature detection work
when doing Windows builds with CMake. Do this by pre-filling well-known
detection results for Windows and specifically for mingw-w64 and MSVC
compilers. Also limit feature checks to platforms where the results are
actually used. Drop a few redundant ones. And some tidying up.
- pre-fill remaining detection values in Windows CMake builds.
Based on actual detection results observed in CI runs, preceding
similar work over libssh2 and matching up values with
`lib/config-win32.h`.
This brings down CMake configuration time from 58 to 14 seconds on the
same local machine.
On AppVeyor CI this translates to:
- 128 seconds -> 50 seconds VS2022 MSVC with OpenSSL (per CMake job):
https://ci.appveyor.com/project/curlorg/curl/builds/48208419/job/4gw66ecrjpy7necb#L296
https://ci.appveyor.com/project/curlorg/curl/builds/48217440/job/8m4fwrr2fe249uo8#L186
- 62 seconds -> 16 seconds VS2017 MINGW (per CMake job):
https://ci.appveyor.com/project/curlorg/curl/builds/48208419/job/s1y8q5ivlcs7ub29?fullLog=true#L290
https://ci.appveyor.com/project/curlorg/curl/builds/48217440/job/pchpxyjsyc9kl13a?fullLog=true#L194
The formula is about 1-3 seconds delay for each detection. Almost all
of these trigger a full compile-link cycle behind the scenes, slow
even today, both cross and native, mingw-w64 and apparently MSVC too.
Enabling .map files or other custom build features slows it down
further. (Similar is expected for autotools configure.)
- stop detecting `idn2.h` if idn2 was deselected.
autotools does this.
- stop detecting `idn2.h` if idn2 was not found.
This deviates from autotools. Source code requires both header and
lib, so this is still correct, but faster.
- limit `ADDRESS_FAMILY` detection to Windows.
- normalize `HAVE_WIN32_WINNT` value to lowercase `0x0a12` format.
- pre-fill `HAVE_WIN32_WINNT`-dependent detection results.
Saving 4 (slow) feature-detections in most builds: `getaddrinfo`,
`freeaddrinfo`, `inet_ntop`, `inet_pton`
- fix pre-filled `HAVE_SYS_TIME_H`, `HAVE_SYS_PARAM_H`,
`HAVE_GETTIMEOFDAY` for mingw-w64.
Luckily this do not change build results, as `WIN32` took
priority over `HAVE_GETTIMEOFDAY` with the current source
code.
- limit `HAVE_CLOCK_GETTIME_MONOTONIC_RAW` and
`HAVE_CLOCK_GETTIME_MONOTONIC` detections to non-Windows.
We're not using these in the source code for Windows.
- reduce compiler warning noise in CMake internal logs:
- fix to include `winsock2.h` before `windows.h`.
Apply it to autotools test snippets too.
- delete previous `-D_WINSOCKAPI_=` hack that aimed to fix the above.
- cleanup `CMake/CurlTests.c` to emit less warnings.
- delete redundant `HAVE_MACRO_SIGSETJMP` feature check.
It was the same check as `HAVE_SIGSETJMP`.
- delete 'experimental' marking from `CURL_USE_OPENSSL`.
- show CMake version via `CMakeLists.txt`.
Credit to the `zlib-ng` project for the idea:
61e181c8ae/CMakeLists.txt (L7)
- make `CMake/CurlTests.c` pass `checksrc`.
- `CMake/WindowsCache.cmake` tidy-ups.
- replace `WIN32` guard with `_WIN32` in `CMake/CurlTests.c`.
Closes #12044
198 lines
5.1 KiB
CMake
198 lines
5.1 KiB
CMake
#***************************************************************************
|
|
# _ _ ____ _
|
|
# Project ___| | | | _ \| |
|
|
# / __| | | | |_) | |
|
|
# | (__| |_| | _ <| |___
|
|
# \___|\___/|_| \_\_____|
|
|
#
|
|
# Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
#
|
|
# This software is licensed as described in the file COPYING, which
|
|
# you should have received as part of this distribution. The terms
|
|
# are also available at https://curl.se/docs/copyright.html.
|
|
#
|
|
# You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
# copies of the Software, and permit persons to whom the Software is
|
|
# furnished to do so, under the terms of the COPYING file.
|
|
#
|
|
# This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
# KIND, either express or implied.
|
|
#
|
|
# SPDX-License-Identifier: curl
|
|
#
|
|
###########################################################################
|
|
if(NOT WIN32)
|
|
message(FATAL_ERROR "This file should be included on Windows platform only")
|
|
endif()
|
|
|
|
set(HAVE_LOCALE_H 1)
|
|
|
|
if(MINGW)
|
|
set(HAVE_SNPRINTF 1)
|
|
set(HAVE_UNISTD_H 1)
|
|
set(HAVE_LIBGEN_H 1)
|
|
set(HAVE_STDDEF_H 1) # detected by CMake internally in check_type_size()
|
|
set(HAVE_STDINT_H 1)
|
|
set(HAVE_STDBOOL_H 1)
|
|
set(HAVE_BOOL_T "${HAVE_STDBOOL_H}")
|
|
set(HAVE_INTTYPES_H 1)
|
|
set(HAVE_STRTOLL 1)
|
|
set(HAVE_BASENAME 1)
|
|
set(HAVE_STRCASECMP 1)
|
|
set(HAVE_FTRUNCATE 1)
|
|
set(HAVE_SYS_PARAM_H 1)
|
|
set(HAVE_SYS_TIME_H 1)
|
|
set(HAVE_GETTIMEOFDAY 1)
|
|
else()
|
|
set(HAVE_LIBGEN_H 0)
|
|
set(HAVE_STRCASECMP 0)
|
|
set(HAVE_FTRUNCATE 0)
|
|
set(HAVE_SYS_PARAM_H 0)
|
|
set(HAVE_SYS_TIME_H 0)
|
|
set(HAVE_GETTIMEOFDAY 0)
|
|
if(MSVC)
|
|
set(HAVE_UNISTD_H 0)
|
|
set(HAVE_LOCALE_H 1)
|
|
set(HAVE_STDDEF_H 1) # detected by CMake internally in check_type_size()
|
|
set(HAVE_STDATOMIC_H 0)
|
|
if(NOT MSVC_VERSION LESS 1400)
|
|
set(HAVE_VARIADIC_MACROS_C99 1)
|
|
else()
|
|
set(HAVE_VARIADIC_MACROS_C99 0)
|
|
endif()
|
|
if(NOT MSVC_VERSION LESS 1600)
|
|
set(HAVE_STDINT_H 1)
|
|
else()
|
|
set(HAVE_STDINT_H 0)
|
|
endif()
|
|
if(NOT MSVC_VERSION LESS 1800)
|
|
set(HAVE_STDBOOL_H 1)
|
|
set(HAVE_INTTYPES_H 1)
|
|
set(HAVE_STRTOLL 1)
|
|
else()
|
|
set(HAVE_STDBOOL_H 0)
|
|
set(HAVE_INTTYPES_H 0)
|
|
set(HAVE_STRTOLL 0)
|
|
endif()
|
|
set(HAVE_BOOL_T "${HAVE_STDBOOL_H}")
|
|
if(NOT MSVC_VERSION LESS 1900)
|
|
set(HAVE_SNPRINTF 1)
|
|
else()
|
|
set(HAVE_SNPRINTF 0)
|
|
endif()
|
|
set(HAVE_BASENAME 0)
|
|
set(HAVE_STRTOK_R 0)
|
|
set(HAVE_FILE_OFFSET_BITS 0)
|
|
set(HAVE_ATOMIC 0)
|
|
endif()
|
|
endif()
|
|
|
|
set(HAVE_FCHMOD 0)
|
|
set(HAVE_SOCKETPAIR 0)
|
|
set(HAVE_SENDMSG 0)
|
|
set(HAVE_ALARM 0)
|
|
set(HAVE_FCNTL 0)
|
|
set(HAVE_GETPPID 0)
|
|
set(HAVE_UTIMES 0)
|
|
set(HAVE_GETPWUID_R 0)
|
|
set(HAVE_STRERROR_R 0)
|
|
set(HAVE_SIGINTERRUPT 0)
|
|
set(HAVE_PIPE 0)
|
|
set(HAVE_IF_NAMETOINDEX 0)
|
|
set(HAVE_GETRLIMIT 0)
|
|
set(HAVE_SETRLIMIT 0)
|
|
set(HAVE_FSETXATTR 0)
|
|
set(HAVE_LIBSOCKET 0)
|
|
set(HAVE_SETLOCALE 1)
|
|
set(HAVE_SETMODE 1)
|
|
set(HAVE_GETPEERNAME 1)
|
|
set(HAVE_GETSOCKNAME 1)
|
|
set(HAVE_GETHOSTNAME 1)
|
|
set(HAVE_LIBZ 0)
|
|
|
|
set(HAVE_RECV 1)
|
|
set(HAVE_SEND 1)
|
|
set(HAVE_STROPTS_H 0)
|
|
set(HAVE_SYS_XATTR_H 0)
|
|
set(HAVE_ARC4RANDOM 0)
|
|
set(HAVE_FNMATCH 0)
|
|
set(HAVE_SCHED_YIELD 0)
|
|
set(HAVE_ARPA_INET_H 0)
|
|
set(HAVE_FCNTL_H 1)
|
|
set(HAVE_IFADDRS_H 0)
|
|
set(HAVE_IO_H 1)
|
|
set(HAVE_NETDB_H 0)
|
|
set(HAVE_NETINET_IN_H 0)
|
|
set(HAVE_NETINET_TCP_H 0)
|
|
set(HAVE_NETINET_UDP_H 0)
|
|
set(HAVE_NET_IF_H 0)
|
|
set(HAVE_IOCTL_SIOCGIFADDR 0)
|
|
set(HAVE_POLL_H 0)
|
|
set(HAVE_POLL_FINE 0)
|
|
set(HAVE_PWD_H 0)
|
|
set(HAVE_STRINGS_H 0) # mingw-w64 has it (wrapper to string.h)
|
|
set(HAVE_SYS_FILIO_H 0)
|
|
set(HAVE_SYS_WAIT_H 0)
|
|
set(HAVE_SYS_IOCTL_H 0)
|
|
set(HAVE_SYS_POLL_H 0)
|
|
set(HAVE_SYS_RESOURCE_H 0)
|
|
set(HAVE_SYS_SELECT_H 0)
|
|
set(HAVE_SYS_SOCKET_H 0)
|
|
set(HAVE_SYS_SOCKIO_H 0)
|
|
set(HAVE_SYS_STAT_H 1)
|
|
set(HAVE_SYS_TYPES_H 1)
|
|
set(HAVE_SYS_UN_H 0)
|
|
set(HAVE_SYS_UTIME_H 1)
|
|
set(HAVE_TERMIOS_H 0)
|
|
set(HAVE_TERMIO_H 0)
|
|
set(HAVE_UTIME_H 0) # mingw-w64 has it (wrapper to sys/utime.h)
|
|
|
|
set(HAVE_FSEEKO 0)
|
|
set(HAVE__FSEEKI64 1)
|
|
set(HAVE_SOCKET 1)
|
|
set(HAVE_SELECT 1)
|
|
set(HAVE_STRDUP 1)
|
|
set(HAVE_STRICMP 1)
|
|
set(HAVE_STRCMPI 1)
|
|
set(HAVE_MEMRCHR 0)
|
|
set(HAVE_CLOSESOCKET 1)
|
|
set(HAVE_SIGSETJMP 0)
|
|
set(HAVE_SOCKADDR_IN6_SIN6_SCOPE_ID 1)
|
|
set(HAVE_GETPASS_R 0)
|
|
set(HAVE_GETPWUID 0)
|
|
set(HAVE_GETEUID 0)
|
|
set(HAVE_UTIME 1)
|
|
set(HAVE_GMTIME_R 0)
|
|
set(HAVE_GETHOSTBYNAME_R 0)
|
|
set(HAVE_SIGNAL 1)
|
|
set(HAVE_SIGACTION 0)
|
|
set(HAVE_LINUX_TCP_H 0)
|
|
set(HAVE_GLIBC_STRERROR_R 0)
|
|
set(HAVE_MACH_ABSOLUTE_TIME 0)
|
|
set(HAVE_GETIFADDRS 0)
|
|
set(HAVE_FCNTL_O_NONBLOCK 0)
|
|
set(HAVE_IOCTLSOCKET 1)
|
|
set(HAVE_IOCTLSOCKET_CAMEL 0)
|
|
set(HAVE_IOCTLSOCKET_CAMEL_FIONBIO 0)
|
|
set(HAVE_IOCTLSOCKET_FIONBIO 1)
|
|
set(HAVE_IOCTL_FIONBIO 0)
|
|
set(HAVE_SETSOCKOPT_SO_NONBLOCK 0)
|
|
set(HAVE_POSIX_STRERROR_R 0)
|
|
set(HAVE_BUILTIN_AVAILABLE 0)
|
|
set(HAVE_MSG_NOSIGNAL 0)
|
|
set(HAVE_STRUCT_TIMEVAL 1)
|
|
|
|
set(HAVE_GETHOSTBYNAME_R_3 0)
|
|
set(HAVE_GETHOSTBYNAME_R_3_REENTRANT 0)
|
|
set(HAVE_GETHOSTBYNAME_R_5 0)
|
|
set(HAVE_GETHOSTBYNAME_R_5_REENTRANT 0)
|
|
set(HAVE_GETHOSTBYNAME_R_6 0)
|
|
set(HAVE_GETHOSTBYNAME_R_6_REENTRANT 0)
|
|
|
|
set(HAVE_O_NONBLOCK 0)
|
|
set(HAVE_IN_ADDR_T 0)
|
|
set(STDC_HEADERS 1)
|
|
|
|
set(HAVE_SIZEOF_SUSECONDS_T 0)
|
|
set(HAVE_SIZEOF_SA_FAMILY_T 0)
|