mirror of
https://github.com/curl/curl.git
synced 2025-04-18 16:30:45 +08:00
9465327084
- cmake: disable test bundles for clang-tidy builds. clang-tidy ignores #included .c sources, and incompatible with unity and bundles. It caused clang-tidy ignoring all test sources. It also means this is the first time tests sources are checked with clang-tidy. (autotools doesn't run it on tests.) - cmake: update description for `CURL_TEST_BUNDLES` option. - fix tests using special `CURLE_*` enums that were missing from `curl/curl.h`. Add them as reserved codes. - fix about ~50 other issues detected by clang-tidy: unchecked results, NULL derefs, memory leaks, casts to enums, unused assigments, uninitialized `errno` uses, unchecked `open`, indent, and more. - drop unnecessary casts (lib1533, lib3207). - suppress a few impossible cases with detailed `NOLINT`s. - lib/escape.c: drop `NOLINT` no longer necessary. Follow-up to 72abf7c13a479edcde80afa60faad3f35f672c0b #13862 (possibly) - extend two existing `NOLINT` comments with details. Follow-up to fabfa8e4024473035b3e5c3c30c330be726d9bb4 #15825 Closes #16756
131 lines
3.6 KiB
C
131 lines
3.6 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "test.h"
|
|
#include "memdebug.h"
|
|
|
|
/* build request url */
|
|
static char *suburl(const char *base, int i)
|
|
{
|
|
return curl_maprintf("%s%.4d", base, i);
|
|
}
|
|
|
|
/*
|
|
* Test Session ID capture
|
|
*/
|
|
CURLcode test(char *URL)
|
|
{
|
|
CURLcode res;
|
|
CURL *curl;
|
|
char *stream_uri = NULL;
|
|
char *rtsp_session_id;
|
|
int request = 1;
|
|
int i;
|
|
|
|
FILE *idfile = fopen(libtest_arg2, "wb");
|
|
if(!idfile) {
|
|
fprintf(stderr, "couldn't open the Session ID File\n");
|
|
return TEST_ERR_MAJOR_BAD;
|
|
}
|
|
|
|
if(curl_global_init(CURL_GLOBAL_ALL) != CURLE_OK) {
|
|
fprintf(stderr, "curl_global_init() failed\n");
|
|
fclose(idfile);
|
|
return TEST_ERR_MAJOR_BAD;
|
|
}
|
|
|
|
curl = curl_easy_init();
|
|
if(!curl) {
|
|
fprintf(stderr, "curl_easy_init() failed\n");
|
|
curl_global_cleanup();
|
|
fclose(idfile);
|
|
return TEST_ERR_MAJOR_BAD;
|
|
}
|
|
|
|
test_setopt(curl, CURLOPT_HEADERDATA, stdout);
|
|
test_setopt(curl, CURLOPT_WRITEDATA, stdout);
|
|
test_setopt(curl, CURLOPT_VERBOSE, 1L);
|
|
|
|
test_setopt(curl, CURLOPT_URL, URL);
|
|
|
|
test_setopt(curl, CURLOPT_RTSP_REQUEST, CURL_RTSPREQ_SETUP);
|
|
res = curl_easy_perform(curl);
|
|
if(res != (int)CURLE_BAD_FUNCTION_ARGUMENT) {
|
|
fprintf(stderr, "This should have failed. "
|
|
"Cannot setup without a Transport: header");
|
|
res = TEST_ERR_MAJOR_BAD;
|
|
goto test_cleanup;
|
|
}
|
|
|
|
/* Go through the various Session IDs */
|
|
for(i = 0; i < 3; i++) {
|
|
stream_uri = suburl(URL, request++);
|
|
if(!stream_uri) {
|
|
res = TEST_ERR_MAJOR_BAD;
|
|
goto test_cleanup;
|
|
}
|
|
test_setopt(curl, CURLOPT_RTSP_STREAM_URI, stream_uri);
|
|
curl_free(stream_uri);
|
|
stream_uri = NULL;
|
|
|
|
test_setopt(curl, CURLOPT_RTSP_REQUEST, CURL_RTSPREQ_SETUP);
|
|
test_setopt(curl, CURLOPT_RTSP_TRANSPORT,
|
|
"Fake/NotReal/JustATest;foo=baz");
|
|
res = curl_easy_perform(curl);
|
|
if(res)
|
|
goto test_cleanup;
|
|
|
|
curl_easy_getinfo(curl, CURLINFO_RTSP_SESSION_ID, &rtsp_session_id);
|
|
fprintf(idfile, "Got Session ID: [%s]\n", rtsp_session_id);
|
|
rtsp_session_id = NULL;
|
|
|
|
stream_uri = suburl(URL, request++);
|
|
if(!stream_uri) {
|
|
res = TEST_ERR_MAJOR_BAD;
|
|
goto test_cleanup;
|
|
}
|
|
test_setopt(curl, CURLOPT_RTSP_STREAM_URI, stream_uri);
|
|
curl_free(stream_uri);
|
|
stream_uri = NULL;
|
|
|
|
test_setopt(curl, CURLOPT_RTSP_REQUEST, CURL_RTSPREQ_TEARDOWN);
|
|
res = curl_easy_perform(curl);
|
|
if(res)
|
|
goto test_cleanup;
|
|
|
|
/* Clear for the next go-round */
|
|
test_setopt(curl, CURLOPT_RTSP_SESSION_ID, NULL);
|
|
}
|
|
|
|
test_cleanup:
|
|
|
|
if(idfile)
|
|
fclose(idfile);
|
|
|
|
curl_free(stream_uri);
|
|
curl_easy_cleanup(curl);
|
|
curl_global_cleanup();
|
|
|
|
return res;
|
|
}
|