mirror of
https://github.com/curl/curl.git
synced 2025-04-18 16:30:45 +08:00
- cmake: disable test bundles for clang-tidy builds. clang-tidy ignores #included .c sources, and incompatible with unity and bundles. It caused clang-tidy ignoring all test sources. It also means this is the first time tests sources are checked with clang-tidy. (autotools doesn't run it on tests.) - cmake: update description for `CURL_TEST_BUNDLES` option. - fix tests using special `CURLE_*` enums that were missing from `curl/curl.h`. Add them as reserved codes. - fix about ~50 other issues detected by clang-tidy: unchecked results, NULL derefs, memory leaks, casts to enums, unused assigments, uninitialized `errno` uses, unchecked `open`, indent, and more. - drop unnecessary casts (lib1533, lib3207). - suppress a few impossible cases with detailed `NOLINT`s. - lib/escape.c: drop `NOLINT` no longer necessary. Follow-up to 72abf7c13a479edcde80afa60faad3f35f672c0b #13862 (possibly) - extend two existing `NOLINT` comments with details. Follow-up to fabfa8e4024473035b3e5c3c30c330be726d9bb4 #15825 Closes #16756
186 lines
4.8 KiB
C
186 lines
4.8 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "test.h"
|
|
|
|
#ifdef HAVE_SYS_STAT_H
|
|
#include <sys/stat.h>
|
|
#endif
|
|
#ifdef HAVE_FCNTL_H
|
|
#include <fcntl.h>
|
|
#endif
|
|
|
|
#include "memdebug.h"
|
|
|
|
/* build request url */
|
|
static char *suburl(const char *base, int i)
|
|
{
|
|
return curl_maprintf("%s%.4d", base, i);
|
|
}
|
|
|
|
/*
|
|
* Test the Client->Server ANNOUNCE functionality (PUT style)
|
|
*/
|
|
CURLcode test(char *URL)
|
|
{
|
|
CURLcode res;
|
|
CURL *curl;
|
|
int sdp;
|
|
FILE *sdpf = NULL;
|
|
struct_stat file_info;
|
|
char *stream_uri = NULL;
|
|
int request = 1;
|
|
struct curl_slist *custom_headers = NULL;
|
|
|
|
if(curl_global_init(CURL_GLOBAL_ALL) != CURLE_OK) {
|
|
fprintf(stderr, "curl_global_init() failed\n");
|
|
return TEST_ERR_MAJOR_BAD;
|
|
}
|
|
|
|
curl = curl_easy_init();
|
|
if(!curl) {
|
|
fprintf(stderr, "curl_easy_init() failed\n");
|
|
curl_global_cleanup();
|
|
return TEST_ERR_MAJOR_BAD;
|
|
}
|
|
|
|
test_setopt(curl, CURLOPT_HEADERDATA, stdout);
|
|
test_setopt(curl, CURLOPT_WRITEDATA, stdout);
|
|
|
|
test_setopt(curl, CURLOPT_URL, URL);
|
|
|
|
stream_uri = suburl(URL, request++);
|
|
if(!stream_uri) {
|
|
res = TEST_ERR_MAJOR_BAD;
|
|
goto test_cleanup;
|
|
}
|
|
test_setopt(curl, CURLOPT_RTSP_STREAM_URI, stream_uri);
|
|
curl_free(stream_uri);
|
|
stream_uri = NULL;
|
|
|
|
sdp = open(libtest_arg2, O_RDONLY);
|
|
if(sdp == -1) {
|
|
fprintf(stderr, "can't open %s\n", libtest_arg2);
|
|
res = TEST_ERR_MAJOR_BAD;
|
|
goto test_cleanup;
|
|
}
|
|
fstat(sdp, &file_info);
|
|
close(sdp);
|
|
|
|
sdpf = fopen(libtest_arg2, "rb");
|
|
if(!sdpf) {
|
|
fprintf(stderr, "can't fopen %s\n", libtest_arg2);
|
|
res = TEST_ERR_MAJOR_BAD;
|
|
goto test_cleanup;
|
|
}
|
|
test_setopt(curl, CURLOPT_RTSP_REQUEST, CURL_RTSPREQ_ANNOUNCE);
|
|
|
|
test_setopt(curl, CURLOPT_READDATA, sdpf);
|
|
test_setopt(curl, CURLOPT_UPLOAD, 1L);
|
|
test_setopt(curl, CURLOPT_INFILESIZE_LARGE, (curl_off_t) file_info.st_size);
|
|
test_setopt(curl, CURLOPT_VERBOSE, 1L);
|
|
|
|
/* Do the ANNOUNCE */
|
|
res = curl_easy_perform(curl);
|
|
if(res)
|
|
goto test_cleanup;
|
|
|
|
test_setopt(curl, CURLOPT_UPLOAD, 0L);
|
|
fclose(sdpf);
|
|
sdpf = NULL;
|
|
|
|
/* Make sure we can do a normal request now */
|
|
stream_uri = suburl(URL, request++);
|
|
if(!stream_uri) {
|
|
res = TEST_ERR_MAJOR_BAD;
|
|
goto test_cleanup;
|
|
}
|
|
test_setopt(curl, CURLOPT_RTSP_STREAM_URI, stream_uri);
|
|
curl_free(stream_uri);
|
|
stream_uri = NULL;
|
|
|
|
test_setopt(curl, CURLOPT_RTSP_REQUEST, CURL_RTSPREQ_DESCRIBE);
|
|
res = curl_easy_perform(curl);
|
|
if(res)
|
|
goto test_cleanup;
|
|
|
|
/* Now do a POST style one */
|
|
|
|
stream_uri = suburl(URL, request++);
|
|
if(!stream_uri) {
|
|
res = TEST_ERR_MAJOR_BAD;
|
|
goto test_cleanup;
|
|
}
|
|
test_setopt(curl, CURLOPT_RTSP_STREAM_URI, stream_uri);
|
|
curl_free(stream_uri);
|
|
stream_uri = NULL;
|
|
|
|
custom_headers = curl_slist_append(custom_headers,
|
|
"Content-Type: posty goodness");
|
|
if(!custom_headers) {
|
|
res = TEST_ERR_MAJOR_BAD;
|
|
goto test_cleanup;
|
|
}
|
|
test_setopt(curl, CURLOPT_RTSPHEADER, custom_headers);
|
|
test_setopt(curl, CURLOPT_RTSP_REQUEST, CURL_RTSPREQ_ANNOUNCE);
|
|
test_setopt(curl, CURLOPT_POSTFIELDS,
|
|
"postyfield=postystuff&project=curl\n");
|
|
|
|
res = curl_easy_perform(curl);
|
|
if(res)
|
|
goto test_cleanup;
|
|
|
|
test_setopt(curl, CURLOPT_POSTFIELDS, NULL);
|
|
test_setopt(curl, CURLOPT_RTSPHEADER, NULL);
|
|
curl_slist_free_all(custom_headers);
|
|
custom_headers = NULL;
|
|
|
|
/* Make sure we can do a normal request now */
|
|
stream_uri = suburl(URL, request++);
|
|
if(!stream_uri) {
|
|
res = TEST_ERR_MAJOR_BAD;
|
|
goto test_cleanup;
|
|
}
|
|
test_setopt(curl, CURLOPT_RTSP_STREAM_URI, stream_uri);
|
|
curl_free(stream_uri);
|
|
stream_uri = NULL;
|
|
|
|
test_setopt(curl, CURLOPT_RTSP_REQUEST, CURL_RTSPREQ_OPTIONS);
|
|
res = curl_easy_perform(curl);
|
|
|
|
test_cleanup:
|
|
|
|
if(sdpf)
|
|
fclose(sdpf);
|
|
|
|
curl_free(stream_uri);
|
|
|
|
if(custom_headers)
|
|
curl_slist_free_all(custom_headers);
|
|
|
|
curl_easy_cleanup(curl);
|
|
curl_global_cleanup();
|
|
|
|
return res;
|
|
}
|