Daniel Stenberg
b22e03b2b2
Fix how TFTP connections are treated when re-used, if the SessionHandle has
...
been used for other protocols in between. I found this when test 2004 started
to fail for me!
2007-11-14 22:41:42 +00:00
Yang Tse
a2926ebe7c
Fix a variable potential wrapping in add_buffer() when using absolutely
...
huge send buffer sizes
2007-11-14 00:48:11 +00:00
Daniel Stenberg
c508d70258
Fixed a remaining problem with doing SFTP directory listings on a re-used
...
persistent connection. Mentioned by Immanuel Gregoire on the mailing list.
2007-11-12 23:04:44 +00:00
Daniel Stenberg
f5971f54ff
comment language
2007-11-12 21:42:20 +00:00
Daniel Stenberg
c5b16d4468
Bug report #1830637 ( http://curl.haxx.se/bug/view.cgi?id=1830637 ), which was
...
forwarded from the Gentoo bug tracker by Daniel Black and was originally
submitted by Robin Johnson, pointed out that libcurl would do bad memory
references when it failed and bailed out before the handler thing was
setup. My fix is not done like the provided patch does it, but instead I
make sure that there's never any chance for a NULL pointer in that struct
member.
2007-11-12 21:38:43 +00:00
Daniel Stenberg
3c71a1bab7
oops, fixed build when CURL_LIBSSH2_DEBUG is defined
2007-11-12 09:24:05 +00:00
Yang Tse
9a39839a43
Some versions of winsock2.h have pollfd struct and constants
2007-11-10 04:23:15 +00:00
Yang Tse
e87c996fe0
Fix compiler warning: integral size mismatch in argument
2007-11-08 19:28:25 +00:00
Yang Tse
32195c673d
Define WIN32 when build target is Win32 API.
...
This also defines it for WinCE even though it is a subset of WIN32.
2007-11-08 18:13:54 +00:00
Yang Tse
b99a61c5b0
Fix compiler warning: may be used uninitialized
2007-11-08 16:43:01 +00:00
Daniel Stenberg
a29471d0f7
spell!
2007-11-08 10:25:23 +00:00
Daniel Stenberg
ba6f20a244
Bug report #1823487 ( http://curl.haxx.se/bug/view.cgi?id=1823487 ) pointed
...
out that SFTP requests didn't use persistent connections. Neither did SCP
ones. I gave the SSH code a good beating and now both SCP and SFTP should
use persistent connections fine. I also did a bunch for indent changes as
well as a bug fix for the "keyboard interactive" auth.
2007-11-08 10:22:49 +00:00
Yang Tse
dee3844f13
MSVC versions prior to VS2005 do not complain about portable C functions
2007-11-07 18:18:42 +00:00
Daniel Stenberg
cbd1a77ec2
if () => if()
...
while () => while()
and some other minor re-indentings
2007-11-07 09:21:35 +00:00
Dan Fandrich
33f7ac06c3
Improved telnet support by drastically reducing the number of write
...
callbacks needed to pass a buffer to the user. Instead one per byte it
is now as little as one per segment.
2007-11-07 05:52:03 +00:00
Gisle Vanem
66e4d391d3
Added prototype for _strtoi64().
2007-11-06 16:20:54 +00:00
Gisle Vanem
caf880be18
Constified from arguments.
2007-11-06 16:20:04 +00:00
Daniel Stenberg
ad6e28073c
removed space after if and while before the parenthesis for better source code
...
consistency
2007-11-05 09:45:09 +00:00
Daniel Stenberg
b9a7f4e502
Move connection-oriented variables from the SessionHandle struct to the
...
connectdata struct. This will in theory enable us to do persistent connections
with SCP+SFTP, but currently the state machine always (and wrongly) cleanup
everything in the 'done' action instead of in 'disconnect'. Also did a bunch
of indent fixes, if () => if() and a few other source cleanups like added
comments etc.
2007-11-05 09:30:45 +00:00
Daniel Stenberg
51009a40b4
make sure the code deals with failures on the DO_MORE state properly
2007-11-03 14:44:38 +00:00
Daniel Stenberg
2ec8f77f21
avoid setting up a transfer when the state machine failed previously
2007-11-02 23:34:00 +00:00
Daniel Stenberg
d34fe06fb0
minor re-indent
2007-11-01 21:43:56 +00:00
Gisle Vanem
c56c4a0a47
Add support for LDAP urls. Allthough the OpenWatcom
...
headers <winlap.h> and <winber.h> defines wrong calling convention.
2007-10-31 10:58:51 +00:00
Gisle Vanem
45064c5778
Added optional use of zlib (USE_ZLIB=1).
...
Use a response-file for the C-compiler.
2007-10-31 10:20:48 +00:00
Dan Fandrich
59b05ac383
Fixed an OOM problem with file: URLs
...
Moved Curl_file_connect into the protocol handler struct.
2007-10-30 23:00:40 +00:00
Dan Fandrich
0f77fe55b6
Reverted the const change--what was I thinking?
2007-10-29 20:57:03 +00:00
Dan Fandrich
68ee002ad0
Made some pointers const
2007-10-29 18:32:20 +00:00
Daniel Stenberg
e5f1499f62
let 7.17.1 be version-info 4:1:0
2007-10-29 10:19:07 +00:00
Gisle Vanem
848f40fd65
OpenWatcom cannot use wldap32.lib (wrong calling convention?).
...
Added generation of dummy ca-bundle.h. Sorted objects.
2007-10-28 12:02:20 +00:00
Dan Fandrich
d3ee83747c
Fixed a valgrind uninitialized variable error.
2007-10-26 19:26:41 +00:00
Yang Tse
07dbfa25a0
typecast to prevent compiler warning
2007-10-26 01:12:33 +00:00
Daniel Stenberg
6a17cae4f6
Made libcurl built with NSS possible to ignore the peer verification.
...
Previously it would fail if the ca bundle wasn't present, even if the code
ignored the verification results.
2007-10-25 21:08:55 +00:00
Daniel Stenberg
4b96ac504c
prevent compiler warnings about shadowing and one case of unused variable
2007-10-25 20:54:46 +00:00
Daniel Stenberg
ca67dcbc05
Don't assume there's a sessionhandle around when a connection is disconnected,
...
so do the data->reqdata.current_conn assignment when we know there is an easy
handle existing! Fixes the valgrind report on test 509.
2007-10-25 09:41:35 +00:00
Daniel Stenberg
9dbc2c827d
fix the check
2007-10-25 09:34:16 +00:00
Daniel Stenberg
91e27ce755
Fixed a TFTP memory leak. Enabled test 2003 to verify this.
2007-10-25 07:47:38 +00:00
Daniel Stenberg
8997d258f7
Curl_ftp_disconnect() no longer relies on anything in the reqdata struct. That
...
was even mentioned to be bad in a comment! Should make test 2000 and 2001 work
fine.
Also, freedirs() now take a ftp_conn struct pointer which saves some extra
unnecessary variable assignments.
2007-10-24 21:14:11 +00:00
Daniel Stenberg
a3f958aaaa
added clarifying comment
2007-10-24 21:09:59 +00:00
Yang Tse
08c5e2a194
Windows build targets have socklen_t definition in ws2tcpip.h but some
...
versions of ws2tcpip.h do not have the definition. It seems that when
the socklen_t definition is missing from ws2tcpip.h the definition for
INET_ADDRSTRLEN is also missing, and that when one definition is present
the other one also is available.
2007-10-24 14:39:07 +00:00
Daniel Stenberg
949ff9715a
Bug report #1812190 ( http://curl.haxx.se/bug/view.cgi?id=1812190 ) points out
...
that libcurl tried to re-use connections a bit too much when using non-SSL
protocols tunneled over a HTTP proxy.
2007-10-23 21:00:51 +00:00
Yang Tse
b9a305983f
File is not a protocol that can deal with "persistancy"
2007-10-23 15:16:46 +00:00
Yang Tse
e550df675a
Fix compiler warning: subscript has type `char'
2007-10-23 10:14:24 +00:00
Daniel Stenberg
5b358603bd
Michal Marek forwarded the bug report
...
https://bugzilla.novell.com/show_bug.cgi?id=332917 about a HTTP redirect to
FTP that caused memory havoc. His work together with my efforts created two
fixes:
#1 - FTP::file was moved to struct ftp_conn, because is has to be dealt with
at connection cleanup, at which time the struct HandleData could be
used by another connection.
Also, the unused char *urlpath member is removed from struct FTP.
#2 - provide a Curl_reset_reqproto() function that frees
data->reqdata.proto.* on connection setup if needed (that is if the
SessionHandle was used by a different connection).
2007-10-22 15:05:35 +00:00
Daniel Stenberg
1056dc9a26
Bug report #1815530 ( http://curl.haxx.se/bug/view.cgi?id=1815530 ) points out
...
that specifying a proxy with a trailing slash didn't work (unless it also
contained a port number).
2007-10-22 09:25:45 +00:00
Yang Tse
7fe89c5d29
We use this ZERO_NULL to avoid picky compiler warnings,
...
when assigning a NULL pointer to a function pointer var.
2007-10-20 15:47:16 +00:00
Yang Tse
5c8fc7dce9
Fix compiler warning: conversion from "int" to "unsigned short" may lose significant bits
2007-10-20 15:11:51 +00:00
Patrick Monnerat
8f5909b664
Allow CURLOPT_COPYPOSTFIELDS with explicit data size = 0
2007-10-18 10:54:49 +00:00
Dan Fandrich
bef2e7f2ff
Avoid a NULL pointer dereference in an OOM condition.
2007-10-18 01:04:57 +00:00
Yang Tse
0164f0cf81
Fix overflow detection, take four. Avoiding zero size malloc.
2007-10-17 19:29:06 +00:00
Yang Tse
e7387f7557
Fix overflow detection, thanks to Patrick Monnerat detecting test
...
failure condition: http://curl.haxx.se/mail/lib-2007-10/0152.html
2007-10-17 18:06:32 +00:00
