From cfd6f43d6ca7e57670b422bab7bbf10221a2cf3e Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Sat, 6 Jul 2024 03:57:51 +0200 Subject: [PATCH] build: tidy up `__builtin_available` feature checks (Apple) - sync detection snippet between autotools and cmake It wasn't causing issues, but it's useful to avoid unnecessary differences while debugging. - cmake: limit check to `APPLE`. Ref: b05dc7eb3592305de9fa85640767f3dd2a8d4c93 #14122 Cherry-picked from #14097 Closes #14127 --- CMake/CurlTests.c | 2 +- CMake/Platforms/WindowsCache.cmake | 1 - CMakeLists.txt | 6 ++++-- acinclude.m4 | 3 +-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/CMake/CurlTests.c b/CMake/CurlTests.c index 483b9a218b..f04abd79b2 100644 --- a/CMake/CurlTests.c +++ b/CMake/CurlTests.c @@ -380,7 +380,7 @@ int main(void) #ifdef HAVE_BUILTIN_AVAILABLE int main(void) { - if(__builtin_available(macOS 10.12, *)) {} + if(__builtin_available(macOS 10.12, iOS 5.0, *)) {} return 0; } #endif diff --git a/CMake/Platforms/WindowsCache.cmake b/CMake/Platforms/WindowsCache.cmake index 9fe977bcfe..5346f595ee 100644 --- a/CMake/Platforms/WindowsCache.cmake +++ b/CMake/Platforms/WindowsCache.cmake @@ -173,7 +173,6 @@ set(HAVE_IOCTLSOCKET_FIONBIO 1) set(HAVE_IOCTL_FIONBIO 0) set(HAVE_SETSOCKOPT_SO_NONBLOCK 0) set(HAVE_POSIX_STRERROR_R 0) -set(HAVE_BUILTIN_AVAILABLE 0) set(HAVE_MSG_NOSIGNAL 0) set(HAVE_STRUCT_TIMEVAL 1) set(HAVE_STRUCT_SOCKADDR_STORAGE 1) diff --git a/CMakeLists.txt b/CMakeLists.txt index 22c7cc9f4c..aec06e898b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1484,8 +1484,10 @@ if(NOT WIN32) curl_internal_test(HAVE_CLOCK_GETTIME_MONOTONIC) endif() -# Check compiler support of __builtin_available() -curl_internal_test(HAVE_BUILTIN_AVAILABLE) +if(APPLE) + # Check compiler support of __builtin_available() + curl_internal_test(HAVE_BUILTIN_AVAILABLE) +endif() # Some other minor tests diff --git a/acinclude.m4 b/acinclude.m4 index a44ae350e3..7b5526d36c 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -1649,9 +1649,8 @@ AC_DEFUN([CURL_SUPPORTS_BUILTIN_AVAILABLE], [ AC_MSG_CHECKING([to see if the compiler supports __builtin_available()]) AC_COMPILE_IFELSE([ AC_LANG_PROGRAM([[ -#include ]],[[ - if (__builtin_available(macOS 10.8, iOS 5.0, *)) {} + if(__builtin_available(macOS 10.12, iOS 5.0, *)) {} ]]) ],[ AC_MSG_RESULT([yes])