mirror/curl
2
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2025-01-06 13:44:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

tool_operate: fix a scan-build warning

Browse Source 
... and avoid the temp storing of the return code in a diff variable.

Closes #8565
This commit is contained in:
Daniel Stenberg 2022-03-09 11:43:24 +01:00
parent 3e842078f3
commit bec62e39d1
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/tool_operate.c
View File

@ -1736,20 +1736,17 @@ static CURLcode single_transfer(struct GlobalConfig *global,
if(config->cookies) { if(config->cookies) {
struct curlx_dynbuf cookies; struct curlx_dynbuf cookies;
struct curl_slist *cl; struct curl_slist *cl;
CURLcode ret;
/* The maximum size needs to match MAX_NAME in cookie.h */ /* The maximum size needs to match MAX_NAME in cookie.h */
curlx_dyn_init(&cookies, 4096); curlx_dyn_init(&cookies, 4096);
for(cl = config->cookies; cl; cl = cl->next) { for(cl = config->cookies; cl; cl = cl->next) {
if(cl == config->cookies) if(cl == config->cookies)
ret = curlx_dyn_addf(&cookies, "%s", cl->data); result = curlx_dyn_addf(&cookies, "%s", cl->data);
else else
ret = curlx_dyn_addf(&cookies, ";%s", cl->data); result = curlx_dyn_addf(&cookies, ";%s", cl->data);
if(ret) { if(result)
result = CURLE_OUT_OF_MEMORY;
break; break;
}
} }
my_setopt_str(curl, CURLOPT_COOKIE, curlx_dyn_ptr(&cookies)); my_setopt_str(curl, CURLOPT_COOKIE, curlx_dyn_ptr(&cookies));