mirror/curl
2
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2025-03-31 16:00:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

tests: improve SLOWDOWN test reliability by reducing sent data

Browse Source 
These tests are run in SLOWDOWN mode which adds a 10 msec delay after
each character output, which means it takes at least 1.6 seconds (and
320 kernel calls) just to get through the long welcome banner. On an
overloaded system, this can end up taking much more than 1.6 seconds,
and even more than the 7 or 16 second curl timeout that the tests rely
on, causing them to fail. Reducing the size of the welcome banner drops
the total number of characters sent before the transfer starts by more
than half, which reduces the opportunity for test-breaking slowdowns by
the same amount.

Ref: #11328
This commit is contained in:
Dan Fandrich 2023-09-06 12:00:47 -07:00
parent 877e103584
commit ad3c83599e
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/data/test1086
View File

@ -8,6 +8,7 @@ timeout
FAILURE
SLOWDOWN
flaky
timing-dependent
</keywords>
</info>
@ -17,6 +18,7 @@ flaky
# to avoid wasting time waiting for the data phase to start
<servercmd>
SLOWDOWN
REPLY welcome 220 Hey
REPLY USER 331 OK
REPLY PASS 230 OK
REPLY PWD 257 "/"

1
tests/data/test1112
View File

@ -16,6 +16,7 @@ SLOWDOWN
# to avoid wasting time waiting for the data phase to start
<servercmd>
SLOWDOWN
REPLY welcome 220 Hey
REPLY USER 331 OK
REPLY PASS 230 OK
REPLY PWD 257 "/"