mirror/curl
2
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2024-11-27 05:50:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

cf-h1-proxy: skip an extra NULL assign

Browse Source 
and use Curl_safefree() once to save another NULL assign. Found by PVS.

Ref. #10929
Closes #10953
This commit is contained in:
Daniel Stenberg 2023-04-13 12:50:04 +02:00
parent 314dc407d6
commit aabfa60371
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/cf-h1-proxy.c
View File

@ -215,7 +215,6 @@ static void tunnel_go_state(struct Curl_cfilter *cf,
make sure that it isn't accidentally used for the document request
after we've connected. So let's free and clear it here. */
Curl_safefree(data->state.aptr.proxyuserpwd);
data->state.aptr.proxyuserpwd = NULL;
#ifdef USE_HYPER
data->state.hconnect = FALSE;
#endif
@ -1043,8 +1042,7 @@ static CURLcode CONNECT(struct Curl_cfilter *cf,
DEBUGASSERT(ts->tunnel_state == TUNNEL_RESPONSE);
if(data->info.httpproxycode/100 != 2) {
/* a non-2xx response and we have no next url to try. */
free(data->req.newurl);
data->req.newurl = NULL;
Curl_safefree(data->req.newurl);
/* failure, close this connection to avoid re-use */
streamclose(conn, "proxy CONNECT failure");
tunnel_go_state(cf, ts, TUNNEL_FAILED, data);