From 7dad86a03f8c5f131daa4a6cfc38da92e489b738 Mon Sep 17 00:00:00 2001 From: Stefan Eissing Date: Tue, 7 Feb 2023 09:34:49 +0100 Subject: [PATCH] vrls: addressing issues reported by coverity I believe the code was secure before this, but limiting the accepted name length to what is used in the structures should help Coverity's analysis. Closes #10431 --- lib/vtls/vtls.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/vtls/vtls.c b/lib/vtls/vtls.c index e8ae3c05ff..f5967ecb33 100644 --- a/lib/vtls/vtls.c +++ b/lib/vtls/vtls.c @@ -1954,7 +1954,7 @@ CURLcode Curl_alpn_to_proto_buf(struct alpn_proto_buf *buf, memset(buf, 0, sizeof(*buf)); for(i = 0; spec && i < spec->count; ++i) { len = strlen(spec->entries[i]); - if(len > 255) + if(len >= ALPN_NAME_MAX) return CURLE_FAILED_INIT; blen = (unsigned char)len; if(off + blen + 1 >= (int)sizeof(buf->data)) @@ -1976,7 +1976,7 @@ CURLcode Curl_alpn_to_proto_str(struct alpn_proto_buf *buf, memset(buf, 0, sizeof(*buf)); for(i = 0; spec && i < spec->count; ++i) { len = strlen(spec->entries[i]); - if(len > 255) + if(len >= ALPN_NAME_MAX) return CURLE_FAILED_INIT; if(off + len + 2 >= (int)sizeof(buf->data)) return CURLE_FAILED_INIT;