mirror of
https://github.com/curl/curl.git
synced 2025-04-18 16:30:45 +08:00
tool_formparse: avoid clobbering on function params
While perfectly legal to do, clobbering function parameters and using them as local variables is confusing at best and rarely improves code readability. Fix by using a local variable instead, no functionality is changed. This also renames the parameter from data to mime_data since the term data is (soft) reserved for the easy handle struct. Closes: #10046 Reviewed-by: Daniel Stenberg <daniel@haxx.se>
This commit is contained in:
parent
60453483b5
commit
76b73c7468
@ -61,17 +61,18 @@ static struct tool_mime *tool_mime_new_parts(struct tool_mime *parent)
|
||||
}
|
||||
|
||||
static struct tool_mime *tool_mime_new_data(struct tool_mime *parent,
|
||||
char *data)
|
||||
char *mime_data)
|
||||
{
|
||||
char *mime_data_copy;
|
||||
struct tool_mime *m = NULL;
|
||||
|
||||
data = strdup(data);
|
||||
if(data) {
|
||||
mime_data_copy = strdup(mime_data);
|
||||
if(mime_data_copy) {
|
||||
m = tool_mime_new(parent, TOOLMIME_DATA);
|
||||
if(!m)
|
||||
free(data);
|
||||
free(mime_data_copy);
|
||||
else
|
||||
m->data = data;
|
||||
m->data = mime_data_copy;
|
||||
}
|
||||
return m;
|
||||
}
|
||||
|
Loading…
x
Reference in New Issue
Block a user