From 73f4ef584fa58108f873b918b3ab3db641f8be75 Mon Sep 17 00:00:00 2001 From: Nicholas Nethercote Date: Fri, 1 Sep 2023 14:55:47 +1000 Subject: [PATCH] hyper: fix a progress upload counter bug `Curl_pgrsSetUploadCounter` should be a passed a total count, not an increment. This changes the failing diff for test 579 with hyper from this: ``` Progress callback called with UL 0 out of 0[LF] -Progress callback called with UL 8 out of 0[LF] -Progress callback called with UL 16 out of 0[LF] -Progress callback called with UL 26 out of 0[LF] -Progress callback called with UL 61 out of 0[LF] -Progress callback called with UL 66 out of 0[LF] +Progress callback called with UL 29 out of 0[LF] ``` to this: ``` Progress callback called with UL 0 out of 0[LF] -Progress callback called with UL 8 out of 0[LF] -Progress callback called with UL 16 out of 0[LF] -Progress callback called with UL 26 out of 0[LF] -Progress callback called with UL 61 out of 0[LF] -Progress callback called with UL 66 out of 0[LF] +Progress callback called with UL 40 out of 0[LF] ``` Presumably a step in the right direction. Closes #11780 --- lib/c-hyper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/c-hyper.c b/lib/c-hyper.c index f0f49ce6c2..05080fa9ac 100644 --- a/lib/c-hyper.c +++ b/lib/c-hyper.c @@ -771,7 +771,7 @@ static int uploadstreamed(void *userdata, hyper_context *ctx, /* increasing the writebytecount here is a little premature but we don't know exactly when the body is sent */ data->req.writebytecount += fillcount; - Curl_pgrsSetUploadCounter(data, fillcount); + Curl_pgrsSetUploadCounter(data, data->req.writebytecount); } return HYPER_POLL_READY; }