openssl: shortcut store_expired for negative timeouts

Avoid some unnecessary computation if the timeout is negative.

Spotted by CodeSonar
Closes #13919
This commit is contained in:
Daniel Stenberg 2024-06-11 08:03:28 +02:00
parent a945393e51
commit 5e8d921f55
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2

View File

@ -3310,14 +3310,15 @@ cached_x509_store_expired(const struct Curl_easy *data,
const struct ossl_x509_share *mb)
{
const struct ssl_general_config *cfg = &data->set.general_ssl;
struct curltime now = Curl_now();
timediff_t elapsed_ms = Curl_timediff(now, mb->time);
timediff_t timeout_ms = cfg->ca_cache_timeout * (timediff_t)1000;
if(cfg->ca_cache_timeout < 0)
return FALSE;
else {
struct curltime now = Curl_now();
timediff_t elapsed_ms = Curl_timediff(now, mb->time);
timediff_t timeout_ms = cfg->ca_cache_timeout * (timediff_t)1000;
if(timeout_ms < 0)
return false;
return elapsed_ms >= timeout_ms;
return elapsed_ms >= timeout_ms;
}
}
static bool