mirror/curl
2
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2024-11-21 01:16:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

ssh: free the session on init failures

Browse Source 
Ensure to clear the session object in case the libssh2 initialization
fails.

It could be argued that the libssh2 error function should be called to
get a proper error message in this case. But since the only error path
in libssh2_knownhost_init() is memory a allocation failure it's safest
to avoid since the libssh2 error handling allocates memory.

Closes #3179
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
This commit is contained in:
Daniel Gustafsson 2018-10-26 15:39:15 +02:00
parent a0c2779d61
commit 5c8c310edb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/ssh.c
View File

@ -2926,7 +2926,7 @@ static CURLcode ssh_connect(struct connectdata *conn, bool *done)
int rc; int rc;
ssh->kh = libssh2_knownhost_init(ssh->ssh_session); ssh->kh = libssh2_knownhost_init(ssh->ssh_session);
if(!ssh->kh) { if(!ssh->kh) {
/* eeek. TODO: free the ssh_session! */ libssh2_session_free(ssh->ssh_session);
return CURLE_FAILED_INIT; return CURLE_FAILED_INIT;
} }