tests: fixed variable might be clobbered warning

This stops the compiler from potentially making invalid assumptions
about the immutability of sdp and sap across the longjmp boundary.
This commit is contained in:
Dan Fandrich 2016-11-12 12:33:10 +01:00
parent ff662f1c3a
commit 56bb7b1a3c

View File

@ -1232,19 +1232,17 @@ static void sendtftp(struct testcase *test, struct formats *pf)
{
int size;
ssize_t n;
/* This is volatile to live through a siglongjmp */
/* These are volatile to live through a siglongjmp */
volatile unsigned short sendblock; /* block count */
struct tftphdr *sdp; /* data buffer */
struct tftphdr *sap; /* ack buffer */
struct tftphdr * volatile sdp = r_init(); /* data buffer */
struct tftphdr * const sap = &ackbuf.hdr; /* ack buffer */
sendblock = 1;
#if defined(HAVE_ALARM) && defined(SIGALRM)
mysignal(SIGALRM, timer);
#endif
sdp = r_init();
sap = &ackbuf.hdr;
do {
size = readit(test, &sdp, pf->f_convert);
size = readit(test, (struct tftphdr **)&sdp, pf->f_convert);
if(size < 0) {
nak(errno + 100);
return;