From 1d5b7b7009dda753b18d00c0198e8624eeedc9c5 Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Sun, 10 Jul 2022 22:28:14 +0000 Subject: [PATCH] Makefile.m32: add `CURL_RC` and `CURL_STRIP` variables [ci skip] They allow to override the hardcoded values for the `windres` and `strip` tools, complementing the existing set of `CURL_{CC,AR,RANLIB}` variables. `CURL_RC` comes handy when using LLVM tools with `CROSSPREFIX=llvm-` and `CURL_CC=clang` set on current latest debian:unstable or earlier, where `llvm-windres` is missing, and a `CURL_RC=-windres` fixes it. Hopefully this will be fixed in the llvm package. FWIW `llvm-windres` does exist in Homebrew llvm, MSYS2 llvm and llvm-mingw. Reviewed-by: Daniel Stenberg Closes #9132 --- docs/examples/Makefile.m32 | 5 ++++- lib/Makefile.m32 | 10 ++++++++-- src/Makefile.m32 | 10 ++++++++-- 3 files changed, 20 insertions(+), 5 deletions(-) diff --git a/docs/examples/Makefile.m32 b/docs/examples/Makefile.m32 index 3a98b66bd7..f802d55367 100644 --- a/docs/examples/Makefile.m32 +++ b/docs/examples/Makefile.m32 @@ -113,11 +113,14 @@ endif ifeq ($(CURL_AR),) CURL_AR := $(CROSSPREFIX)ar endif +ifeq ($(CURL_RC),) +CURL_RC := $(CROSSPREFIX)windres +endif CC = $(CURL_CC) CFLAGS = -O3 $(CURL_CFLAG_EXTRAS) -W -Wall LDFLAGS = $(CURL_LDFLAG_EXTRAS) $(CURL_LDFLAG_EXTRAS_EXE) -RC = $(CROSSPREFIX)windres +RC = $(CURL_RC) RCFLAGS = --include-dir=$(PROOT)/include -O coff $(CURL_RCFLAG_EXTRAS) # Set environment var ARCH to your architecture to override autodetection. diff --git a/lib/Makefile.m32 b/lib/Makefile.m32 index 8cc72dae52..7166c1b5dc 100644 --- a/lib/Makefile.m32 +++ b/lib/Makefile.m32 @@ -108,15 +108,21 @@ endif ifeq ($(CURL_RANLIB),) CURL_RANLIB := $(CROSSPREFIX)ranlib endif +ifeq ($(CURL_RC),) +CURL_RC := $(CROSSPREFIX)windres +endif +ifeq ($(CURL_STRIP),) +CURL_STRIP := $(CROSSPREFIX)strip +endif CC = $(CURL_CC) CFLAGS = -O3 $(CURL_CFLAG_EXTRAS) -W -Wall LDFLAGS = $(CURL_LDFLAG_EXTRAS) $(CURL_LDFLAG_EXTRAS_DLL) AR = $(CURL_AR) RANLIB = $(CURL_RANLIB) -RC = $(CROSSPREFIX)windres +RC = $(CURL_RC) RCFLAGS = --include-dir=$(PROOT)/include -O coff $(CURL_RCFLAG_EXTRAS) -STRIP = $(CROSSPREFIX)strip -g +STRIP = $(CURL_STRIP) -g # Set environment var ARCH to your architecture to override autodetection. ifndef ARCH diff --git a/src/Makefile.m32 b/src/Makefile.m32 index b202bf0879..8ed3fee827 100644 --- a/src/Makefile.m32 +++ b/src/Makefile.m32 @@ -113,14 +113,20 @@ endif ifeq ($(CURL_AR),) CURL_AR := $(CROSSPREFIX)ar endif +ifeq ($(CURL_RC),) +CURL_RC := $(CROSSPREFIX)windres +endif +ifeq ($(CURL_STRIP),) +CURL_STRIP := $(CROSSPREFIX)strip +endif CC = $(CURL_CC) CFLAGS = -O3 $(CURL_CFLAG_EXTRAS) -W -Wall LDFLAGS = $(CURL_LDFLAG_EXTRAS) $(CURL_LDFLAG_EXTRAS_EXE) AR = $(CURL_AR) -RC = $(CROSSPREFIX)windres +RC = $(CURL_RC) RCFLAGS = --include-dir=$(PROOT)/include -O coff -DCURL_EMBED_MANIFEST $(CURL_RCFLAG_EXTRAS) -STRIP = $(CROSSPREFIX)strip -g +STRIP = $(CURL_STRIP) -g # We may need these someday # PERL = perl