mirror/curl
2
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2025-04-06 16:10:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

http_aws_sigv4: fix scan-build "value stored to 'ret' is never read"

Browse Source 
Follow-up to 495d09810aa9a

Closes #10766
This commit is contained in:
Daniel Stenberg 2023-03-15 00:14:31 +01:00
parent e5e8815532
commit 18a45a51ba
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/http_aws_sigv4.c
View File

@ -318,7 +318,7 @@ static CURLcode calc_payload_hash(struct Curl_easy *data,
{
const char *post_data = data->set.postfields;
size_t post_data_len = 0;
CURLcode ret = CURLE_OUT_OF_MEMORY;
CURLcode result;
if(post_data) {
if(data->set.postfieldsize < 0)
@ -326,14 +326,11 @@ static CURLcode calc_payload_hash(struct Curl_easy *data,
else
post_data_len = (size_t)data->set.postfieldsize;
}
ret = Curl_sha256it(sha_hash, (const unsigned char *) post_data,
post_data_len);
if(ret)
goto fail;
sha256_to_hex(sha_hex, sha_hash);
fail:
return ret;
result = Curl_sha256it(sha_hash, (const unsigned char *) post_data,
post_data_len);
if(!result)
sha256_to_hex(sha_hex, sha_hash);
return result;
}
#define S3_UNSIGNED_PAYLOAD "UNSIGNED-PAYLOAD"
@ -355,7 +352,6 @@ static CURLcode calc_s3_payload_hash(struct Curl_easy *data,
ret = calc_payload_hash(data, sha_hash, sha_hex);
if(ret)
goto fail;
ret = CURLE_OUT_OF_MEMORY;
}
else {
/* Fall back to s3's UNSIGNED-PAYLOAD */
@ -501,7 +497,6 @@ CURLcode Curl_output_aws_sigv4(struct Curl_easy *data, bool proxy)
ret = calc_payload_hash(data, sha_hash, sha_hex);
if(ret)
goto fail;
ret = CURLE_OUT_OF_MEMORY;
payload_hash = sha_hex;
/* may be shorter than SHA256_HEX_LENGTH, like S3_UNSIGNED_PAYLOAD */