2
0
mirror of https://github.com/curl/curl.git synced 2025-04-12 16:20:35 +08:00

create_conn: mark non-HTTP proxies accordingly

A proxy could be marked 'httpproxy' wrongly before if set with an
environment variable or with the CURLOPT_PROXY option with a socks*://
prefix or similar.

Added test 710 to verify

Bug: http://curl.haxx.se/mail/lib-2011-07/0194.html
This commit is contained in:
Daniel Stenberg 2011-08-05 00:44:40 +02:00
parent 75fa3d2d6e
commit 17f343290c

@ -3501,6 +3501,8 @@ static struct connectdata *allocate_conn(struct SessionHandle *data)
#else /* CURL_DISABLE_PROXY */
/* note that these two proxy bits are now just on what looks to be
requested, they may be altered down the road */
conn->bits.proxy = (bool)(data->set.str[STRING_PROXY] &&
*data->set.str[STRING_PROXY]);
conn->bits.httpproxy = (bool)(conn->bits.proxy &&
@ -4825,6 +4827,8 @@ static CURLcode create_conn(struct SessionHandle *data,
conn->bits.httpproxy = TRUE;
#endif
}
else
conn->bits.httpproxy = FALSE; /* not a HTTP proxy */
conn->bits.proxy = TRUE;
}
else {