From 041cf77cbda1dbbe9677becc8f0712463899857b Mon Sep 17 00:00:00 2001 From: Stefan Eissing Date: Thu, 30 Mar 2023 16:30:40 +0200 Subject: [PATCH] tests/http: relax connection check in test_07_02 Only 1 connection will be used when curl is slow, happens when address-sanitized in CI, for example Closes #10865 --- tests/http/test_02_download.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/http/test_02_download.py b/tests/http/test_02_download.py index a0ae8a8209..4b131594b5 100644 --- a/tests/http/test_02_download.py +++ b/tests/http/test_02_download.py @@ -159,8 +159,10 @@ class TestDownload: ]) r.check_exit_code(0) r.check_stats(count=count, exp_status=200) - # should have used 2 connections only (test servers allow 100 req/conn) - assert r.total_connects == 2, "h2 should use fewer connections here" + # should have used at most 2 connections only (test servers allow 100 req/conn) + # it may be just 1 on slow systems where request are answered faster than + # curl can exhaust the capacity or if curl runs with address-sanitizer speed + assert r.total_connects <= 2, "h2 should use fewer connections here" # download files parallel with http/1.1, check connection not reused @pytest.mark.parametrize("proto", ['http/1.1'])