mirror/blockbench
2
0
Fork 0
mirror of https://github.com/JannisX11/blockbench.git synced 2025-01-18 15:26:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix issue with styling in plugin dialogs

Browse Source 
Fix cannot set empty string as settings override value
Fix color in menu items on hover
Add nullish coalescing as browser requirement
This commit is contained in:
JannisX11 2023-02-04 12:42:11 +01:00
parent 69078ca5ea
commit 489964cf31
4 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
css/general.css
View File

@ -594,6 +594,7 @@
.contextMenu li.focused,
.contextMenu li.parent.opened {
background-color: var(--color-accent);
color: var(--color-accent_text);
}
.contextMenu li.hybrid_parent.opened {
background-color: transparent;

3
index.html
View File

@ -54,8 +54,9 @@
<script>
// Browser compatibility check
try {
eval('window?.document');
eval('window?.document ?? 2');
} catch (err) {
console.error(err);
let error_element = document.querySelector('#loading_error_detail')
error_element.innerHTML = `Incompatible browser version. Please update your web browser.`
}

4
js/interface/dialog.js
View File

@ -326,9 +326,9 @@ function buildLines(dialog) {
dialog.max_label_width = Math.max(getStringWidth(widget.name), dialog.max_label_width)
}
dialog.uses_wide_inputs = true;
dialog_content.append(bar)
dialog_content.append(bar);
} else {
dialog_content.append(DOMPurify.sanitize(l))
dialog_content.append(l);
}
})
}

4
js/interface/settings.js
View File

@ -71,7 +71,7 @@ class Setting {
get value() {
let profile = SettingsProfile.all.find(profile => profile.isActive() && profile.settings[this.id] !== undefined);
if (profile) {
return profile.settings[this.id] || this.master_value;
return profile.settings[this.id] ?? this.master_value;
} else {
return this.master_value;
}
@ -82,7 +82,7 @@ class Setting {
get ui_value() {
let profile = Settings.dialog.content_vue?.profile;
if (profile) {
return profile.settings[this.id] || this.master_value;
return profile.settings[this.id] ?? this.master_value;
} else {
return this.master_value;
}