Restructure tests

tests/BrowserKitTests/AdminFormsTest.php

@@ -8,7 +8,7 @@ use Illuminate\Support\Facades\Redis;
 use Illuminate\Foundation\Testing\WithoutMiddleware;
 use Illuminate\Foundation\Testing\DatabaseTransactions;
 
-class AdminConfigurationsTest extends BrowserKitTestCase
+class AdminFormsTest extends BrowserKitTestCase
 {
     use DatabaseTransactions;
 

tests/HttpTest/MiddlewareTest/AuthenticateTest.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace Tests;
+
+use App\Models\User;
+
+class AuthenticateTest extends TestCase
+{
+    public function testHandle()
+    {
+        $this->get('/user')->assertRedirect('auth/login');
+
+        $user = factory(User::class)->make();
+        $this->actingAs($user)->assertAuthenticated();
+    }
+}

tests/HttpTest/MiddlewareTest/CheckAdministratorTest.php

@@ -0,0 +1,29 @@
+<?php
+
+namespace Tests;
+
+use App\Models\User;
+
+class CheckAdministratorTest extends TestCase
+{
+    public function testHandle()
+    {
+        // Without logged in
+        $this->get('/admin')->assertRedirect('/auth/login');
+
+        // Normal user
+        $this->actingAs(factory(User::class)->make())
+            ->get('/admin')
+            ->assertStatus(403);
+
+        // Admin
+        $this->actingAs(factory(User::class, 'admin')->make())
+            ->get('/admin')
+            ->assertSuccessful();
+
+        // Super admin
+        $this->actingAs(factory(User::class, 'superAdmin')->make())
+            ->get('/admin')
+            ->assertSuccessful();
+    }
+}

tests/HttpTest/MiddlewareTest/CheckInstallationTest.php

@@ -0,0 +1,40 @@
+<?php
+
+namespace Tests;
+
+use App\Models\User;
+use Illuminate\Filesystem\Filesystem;
+use Illuminate\Foundation\Testing\DatabaseTransactions;
+
+class CheckInstallationTest extends TestCase
+{
+    use DatabaseTransactions;
+
+    public function testHandle()
+    {
+        $this->get('/setup')->assertSee('Already installed');
+
+        $this->mock(Filesystem::class, function ($mock) {
+            $mock->shouldReceive('exists')
+                ->with(storage_path('install.lock'))
+                ->twice()
+                ->andReturn(false);
+            $mock->shouldReceive('exists')
+                ->with(base_path('.env'))
+                ->andReturn(true);
+        });
+        $this->get('/setup')->assertSee(trans(
+            'setup.wizard.welcome.text',
+            ['version' => config('app.version')]
+        ));
+
+        $this->actingAs(factory(User::class, 'superAdmin')->make());
+        $this->mock(Filesystem::class, function ($mock) {
+            $mock->shouldReceive('exists')
+                ->with(storage_path('install.lock'))
+                ->andReturn(true);
+        });
+        config(['app.version' => '100.0.0']);
+        $this->get('/setup/update')->assertSee(trans('setup.updates.welcome.title'));
+    }
+}

tests/HttpTest/MiddlewareTest/CheckPlayerExistTest.php

@@ -0,0 +1,45 @@
+<?php
+
+namespace Tests;
+
+use Event;
+use App\Models\User;
+use App\Models\Player;
+use Illuminate\Foundation\Testing\DatabaseTransactions;
+
+class CheckPlayerExistTest extends TestCase
+{
+    use DatabaseTransactions;
+
+    public function testHandle()
+    {
+        Event::fake();
+
+        $this->getJson('/nope.json')
+            ->assertStatus(404)
+            ->assertSee(trans('general.unexistent-player'));
+
+        $this->get('/skin/nope.png')
+            ->assertStatus(404)
+            ->assertSee(trans('general.unexistent-player'));
+
+        option(['return_204_when_notfound' => true]);
+        $this->getJson('/nope.json')->assertStatus(204);
+
+        $player = factory(Player::class)->create();
+        $this->getJson("/{$player->name}.json")
+            ->assertJson(['username' => $player->name]);  // Default is CSL API
+
+        $this->getJson("/{$player->name}.json");
+        Event::assertDispatched(\App\Events\CheckPlayerExists::class);
+
+        $player = factory(Player::class)->create();
+        $user = $player->user;
+        $this->actingAs($user)
+            ->postJson('/user/player/rename/-1', ['name' => 'name'])
+            ->assertJson([
+                'code' => 1,
+                'message' => trans('general.unexistent-player'),
+            ]);
+    }
+}

tests/HttpTest/MiddlewareTest/CheckPlayerOwnerTest.php

@@ -0,0 +1,30 @@
+<?php
+
+namespace Tests;
+
+use App\Models\User;
+use App\Models\Player;
+use Illuminate\Foundation\Testing\DatabaseTransactions;
+
+class CheckPlayerOwnerTest extends TestCase
+{
+    use DatabaseTransactions;
+
+    public function testHandle()
+    {
+        $other_user = factory(User::class)->create();
+        $player = factory(Player::class)->create();
+        $owner = $player->user;
+
+        $this->actingAs($other_user)
+            ->get('/user/player')
+            ->assertSuccessful();
+
+        $this->actingAs($other_user)
+            ->postJson('/user/player/rename/'.$player->pid)
+            ->assertJson([
+                'code' => 1,
+                'message' => trans('admin.players.no-permission'),
+            ]);
+    }
+}

tests/HttpTest/MiddlewareTest/CheckSuperAdminTest.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace Tests;
+
+use App\Models\User;
+
+class CheckSuperAdminTest extends TestCase
+{
+    public function testHandle()
+    {
+        // Admin
+        $this->actAs(factory(User::class, 'admin')->make())
+            ->get('/admin/plugins/manage')
+            ->assertForbidden();
+
+        // Super admin
+        $this->actAs(factory(User::class, 'superAdmin')->make())
+            ->get('/admin/plugins/manage')
+            ->assertSuccessful();
+    }
+}

tests/HttpTest/MiddlewareTest/CheckUserVerifiedTest.php

@@ -0,0 +1,38 @@
+<?php
+
+namespace Tests;
+
+use App\Models\User;
+use Illuminate\Foundation\Testing\DatabaseTransactions;
+
+class CheckUserVerifiedTest extends TestCase
+{
+    use DatabaseTransactions;
+
+    public function testHandle()
+    {
+        $unverified = factory(User::class)->create(['verified' => false]);
+
+        option(['require_verification' => false]);
+        $this->actingAs($unverified)
+            ->get('/skinlib/upload')
+            ->assertSuccessful();
+
+        option(['require_verification' => true]);
+        $this->actingAs($unverified)
+            ->get('/skinlib/upload')
+            ->assertStatus(403)
+            ->assertSee(trans('auth.check.verified'));
+
+        $this->actAs('normal')
+            ->get('/skinlib/upload')
+            ->assertSuccessful();
+
+        $user = factory(User::class)->create(['verified' => false]);
+        $this->actingAs($user)->get('/user/oauth/manage')->assertForbidden();
+        $this->getJson('/oauth/clients')->assertForbidden();
+        $user->verified = true;
+        $user->save();
+        $this->getJson('/oauth/clients')->assertSuccessful();
+    }
+}

tests/HttpTest/MiddlewareTest/EnsureEmailFilledTest.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace Tests;
+
+use App\Models\User;
+
+class EnsureEmailFilledTest extends TestCase
+{
+    public function testHandle()
+    {
+        $noEmailUser = factory(User::class)->make(['email' => '']);
+        $this->actingAs($noEmailUser)->get('/user')->assertRedirect('/auth/bind');
+
+        $normalUser = factory(User::class)->make();
+        $this->actingAs($normalUser)->get('/auth/bind')->assertRedirect('/user');
+    }
+}

tests/HttpTest/MiddlewareTest/FireUserAuthenticatedTest.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace Tests;
+
+use Event;
+use App\Models\User;
+
+class FireUserAuthenticatedTest extends TestCase
+{
+    public function testHandle()
+    {
+        Event::fake();
+        $user = factory(User::class)->make();
+        $this->actingAs($user)->get('/user');
+        Event::assertDispatched(\App\Events\UserAuthenticated::class, function ($event) use ($user) {
+            $this->assertEquals($user->uid, $event->user->uid);
+
+            return true;
+        });
+    }
+}

tests/HttpTest/MiddlewareTest/ForbiddenIETest.php

@@ -0,0 +1,12 @@
+<?php
+
+namespace Tests;
+
+class ForbiddenIETest extends TestCase
+{
+    public function testHandle()
+    {
+        $this->get('/', ['user-agent' => 'MSIE'])->assertSee(trans('errors.http.ie'));
+        $this->get('/', ['user-agent' => 'Trident'])->assertSee(trans('errors.http.ie'));
+    }
+}

tests/HttpTest/MiddlewareTest/RedirectIfAuthenticatedTest.php

@@ -0,0 +1,19 @@
+<?php
+
+namespace Tests;
+
+use App\Models\User;
+
+class RedirectIfAuthenticatedTest extends TestCase
+{
+    public function testHandle()
+    {
+        $this->get('/auth/login')
+            ->assertViewIs('auth.login')
+            ->assertDontSee(trans('general.user-center'));
+
+        $this->actingAs(factory(User::class)->make())
+            ->get('/auth/login')
+            ->assertRedirect('/user');
+    }
+}

tests/HttpTest/MiddlewareTest/RedirectToSetupTest.php

@@ -0,0 +1,36 @@
+<?php
+
+namespace Tests;
+
+use App\Models\User;
+use Illuminate\Filesystem\Filesystem;
+use Illuminate\Foundation\Testing\DatabaseTransactions;
+
+class RedirectToSetupTest extends TestCase
+{
+    use DatabaseTransactions;
+
+    public function testHandle()
+    {
+        $superAdmin = factory(User::class, 'superAdmin')->make();
+
+        $current = config('app.version');
+        config(['app.version' => '100.0.0']);
+        $this->get('/')->assertStatus(503);
+        $this->actingAs($superAdmin)->get('/')->assertRedirect('/setup/update');
+        config(['app.version' => $current]);
+
+        $this->mock(Filesystem::class, function ($mock) {
+            $mock->shouldReceive('exists')
+                ->with(storage_path('install.lock'))
+                ->andReturn(true, false, false);
+
+            $mock->shouldReceive('exists')
+                ->with(base_path('.env'))
+                ->andReturn(true);
+        });
+        $this->get('/')->assertViewIs('index');
+        $this->get('/setup')->assertViewIs('setup.wizard.welcome');
+        $this->get('/')->assertRedirect('/setup');
+    }
+}

tests/HttpTest/MiddlewareTest/RejectBannedUserTest.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace Tests;
+
+use App\Models\User;
+
+class RejectBannedUserTest extends TestCase
+{
+    public function testHandle()
+    {
+        $user = factory(User::class, 'banned')->make();
+        $this->actingAs($user)->get('/user')->assertForbidden();
+        $this->get('/user', ['accept' => 'application/json'])
+            ->assertForbidden()
+            ->assertJson(['code' => -1, 'message' => trans('auth.check.banned')]);
+    }
+}

tests/HttpTest/MiddlewareTest/RequireBindPlayerTest.php

@@ -0,0 +1,30 @@
+<?php
+
+namespace Tests;
+
+use App\Models\User;
+use App\Models\Player;
+use Illuminate\Foundation\Testing\DatabaseTransactions;
+
+class RequireBindPlayerTest extends TestCase
+{
+    use DatabaseTransactions;
+
+    public function testHandle()
+    {
+        $user = factory(User::class)->create();
+        $this->actingAs($user)->get('/user')->assertViewIs('user.index');
+        $this->get('/user/player/bind')->assertRedirect('/user');
+
+        option(['single_player' => true]);
+
+        $this->getJson('/user/player/list')->assertHeader('content-type', 'application/json');
+
+        $this->get('/user/player/bind')->assertViewIs('user.bind');
+        $this->get('/user')->assertRedirect('/user/player/bind');
+
+        factory(Player::class)->create(['uid' => $user->uid]);
+        $this->get('/user')->assertViewIs('user.index');
+        $this->get('/user/player/bind')->assertRedirect('/user');
+    }
+}

tests/MiddlewareTest.php

@@ -1,247 +0,0 @@
-<?php
-
-namespace Tests;
-
-use Event;
-use App\Models\User;
-use App\Models\Player;
-use App\Services\Facades\Option;
-use Illuminate\Filesystem\Filesystem;
-use Illuminate\Foundation\Testing\DatabaseTransactions;
-
-class MiddlewareTest extends TestCase
-{
-    use DatabaseTransactions;
-
-    public function testAuthenticate()
-    {
-        $this->get('/user')->assertRedirect('auth/login');
-        $this->actAs('normal')->assertAuthenticated();
-    }
-
-    public function testCheckUserVerified()
-    {
-        $unverified = factory(User::class)->create(['verified' => false]);
-
-        option(['require_verification' => false]);
-        $this->actingAs($unverified)
-            ->get('/skinlib/upload')
-            ->assertSuccessful();
-
-        option(['require_verification' => true]);
-        $this->actingAs($unverified)
-            ->get('/skinlib/upload')
-            ->assertStatus(403)
-            ->assertSee(trans('auth.check.verified'));
-
-        $this->actAs('normal')
-            ->get('/skinlib/upload')
-            ->assertSuccessful();
-
-        $user = factory(User::class)->create(['verified' => false]);
-        $this->actingAs($user)->get('/user/oauth/manage')->assertForbidden();
-        $this->getJson('/oauth/clients')->assertForbidden();
-        $user->verified = true;
-        $user->save();
-        $this->getJson('/oauth/clients')->assertSuccessful();
-    }
-
-    public function testCheckAdministrator()
-    {
-        // Without logged in
-        $this->get('/admin')->assertRedirect('/auth/login');
-
-        // Normal user
-        $this->actAs('normal')
-            ->get('/admin')
-            ->assertStatus(403);
-
-        // Admin
-        $this->actAs('admin')
-            ->get('/admin')
-            ->assertSuccessful();
-
-        // Super admin
-        $this->actAs('superAdmin')
-            ->get('/admin')
-            ->assertSuccessful();
-    }
-
-    public function testCheckSuperAdmin()
-    {
-        // Admin
-        $this->actAs('admin')
-            ->get('/admin/plugins/manage')
-            ->assertForbidden();
-
-        // Super admin
-        $this->actAs('superAdmin')
-            ->get('/admin/plugins/manage')
-            ->assertSuccessful();
-    }
-
-    public function testCheckInstallation()
-    {
-        $this->get('/setup')->assertSee('Already installed');
-
-        $this->mock(Filesystem::class, function ($mock) {
-            $mock->shouldReceive('exists')
-                ->with(storage_path('install.lock'))
-                ->twice()
-                ->andReturn(false);
-            $mock->shouldReceive('exists')
-                ->with(base_path('.env'))
-                ->andReturn(true);
-        });
-        $this->get('/setup')->assertSee(trans(
-            'setup.wizard.welcome.text',
-            ['version' => config('app.version')]
-        ));
-
-        $this->actAs('superAdmin');
-        $this->mock(Filesystem::class, function ($mock) {
-            $mock->shouldReceive('exists')
-                ->with(storage_path('install.lock'))
-                ->andReturn(true);
-        });
-        config(['app.version' => '100.0.0']);
-        $this->get('/setup/update')->assertSee(trans('setup.updates.welcome.title'));
-    }
-
-    public function testCheckPlayerExist()
-    {
-        Event::fake();
-
-        $this->getJson('/nope.json')
-            ->assertStatus(404)
-            ->assertSee(trans('general.unexistent-player'));
-
-        $this->get('/skin/nope.png')
-            ->assertStatus(404)
-            ->assertSee(trans('general.unexistent-player'));
-
-        Option::set('return_204_when_notfound', true);
-        $this->getJson('/nope.json')->assertStatus(204);
-
-        $player = factory(\App\Models\Player::class)->create();
-        $this->getJson("/{$player->name}.json")
-            ->assertJson(['username' => $player->name]);  // Default is CSL API
-
-        $this->getJson("/{$player->name}.json");
-        Event::assertDispatched(\App\Events\CheckPlayerExists::class);
-
-        $player = factory(\App\Models\Player::class)->create();
-        $user = $player->user;
-        $this->actingAs($user)
-            ->postJson('/user/player/rename/-1', ['name' => 'name'])
-            ->assertJson([
-                'code' => 1,
-                'message' => trans('general.unexistent-player'),
-            ]);
-    }
-
-    public function testCheckPlayerOwner()
-    {
-        $other_user = factory(\App\Models\User::class)->create();
-        $player = factory(\App\Models\Player::class)->create();
-        $owner = $player->user;
-
-        $this->actingAs($other_user)
-            ->get('/user/player')
-            ->assertSuccessful();
-
-        $this->actingAs($other_user)
-            ->postJson('/user/player/rename/'.$player->pid)
-            ->assertJson([
-                'code' => 1,
-                'message' => trans('admin.players.no-permission'),
-            ]);
-    }
-
-    public function testEnsureEmailFilled()
-    {
-        $noEmailUser = factory(User::class)->create(['email' => '']);
-        $this->actingAs($noEmailUser)->get('/user')->assertRedirect('/auth/bind');
-
-        $normalUser = factory(User::class)->create();
-        $this->actingAs($normalUser)->get('/auth/bind')->assertRedirect('/user');
-    }
-
-    public function testFireUserAuthenticated()
-    {
-        Event::fake();
-        $user = factory(User::class)->create();
-        $this->actingAs($user)->get('/user');
-        Event::assertDispatched(\App\Events\UserAuthenticated::class, function ($event) use ($user) {
-            $this->assertEquals($user->uid, $event->user->uid);
-
-            return true;
-        });
-    }
-
-    public function testRedirectIfAuthenticated()
-    {
-        $this->get('/auth/login')
-            ->assertViewIs('auth.login')
-            ->assertDontSee(trans('general.user-center'));
-
-        $this->actingAs(factory(User::class)->create())
-            ->get('/auth/login')
-            ->assertRedirect('/user');
-    }
-
-    public function testRedirectToSetup()
-    {
-        $current = config('app.version');
-        config(['app.version' => '100.0.0']);
-        $this->get('/')->assertStatus(503);
-        $this->actAs('superAdmin')->get('/')->assertRedirect('/setup/update');
-        config(['app.version' => $current]);
-
-        $this->mock(Filesystem::class, function ($mock) {
-            $mock->shouldReceive('exists')
-                ->with(storage_path('install.lock'))
-                ->andReturn(true, false, false);
-
-            $mock->shouldReceive('exists')
-                ->with(base_path('.env'))
-                ->andReturn(true);
-        });
-        $this->get('/')->assertViewIs('index');
-        $this->get('/setup')->assertViewIs('setup.wizard.welcome');
-        $this->get('/')->assertRedirect('/setup');
-    }
-
-    public function testRejectBannedUser()
-    {
-        $user = factory(User::class, 'banned')->create();
-        $this->actingAs($user)->get('/user')->assertForbidden();
-        $this->get('/user', ['accept' => 'application/json'])
-            ->assertForbidden()
-            ->assertJson(['code' => -1, 'message' => trans('auth.check.banned')]);
-    }
-
-    public function testRequireBindPlayer()
-    {
-        $user = factory(User::class)->create();
-        $this->actingAs($user)->get('/user')->assertViewIs('user.index');
-        $this->get('/user/player/bind')->assertRedirect('/user');
-
-        option(['single_player' => true]);
-
-        $this->getJson('/user/player/list')->assertHeader('content-type', 'application/json');
-
-        $this->get('/user/player/bind')->assertViewIs('user.bind');
-        $this->get('/user')->assertRedirect('/user/player/bind');
-
-        factory(Player::class)->create(['uid' => $user->uid]);
-        $this->get('/user')->assertViewIs('user.index');
-        $this->get('/user/player/bind')->assertRedirect('/user');
-    }
-
-    public function testForbiddenIE()
-    {
-        $this->get('/', ['user-agent' => 'MSIE'])->assertSee(trans('errors.http.ie'));
-        $this->get('/', ['user-agent' => 'Trident'])->assertSee(trans('errors.http.ie'));
-    }
-}