mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-30 12:44:10 +08:00
73aa9ef81b
Simon noticed a crash that could be caused via new Python gdb.execute_mi function. Looking into this, I found a few unchecked casts to mi_interp, like: - struct mi_interp *mi = (struct mi_interp *) command_interp (); This patch replaces all such casts with safer variants. For -gdb-exit and mi_load_progress, I chose to have the functions simply not generate any output. It didn't seem useful to do so. Some casts I eliminated by adding a parameter to a function. Then, in mi_execute_command, I changed the code to use gdb::checked_static_cast. This is appropriate because this particular overload can only be called by the MI interpreter. There does not seem to be a very good way to test -gdb-exit. Regression tested on x86-64 Fedora 36.
120 lines
4.0 KiB
C++
120 lines
4.0 KiB
C++
/* MI Interpreter Definitions and Commands for GDB, the GNU debugger.
|
|
|
|
Copyright (C) 2017-2023 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef MI_MI_INTERP_H
|
|
#define MI_MI_INTERP_H
|
|
|
|
#include "interps.h"
|
|
|
|
struct mi_console_file;
|
|
|
|
/* An MI interpreter. */
|
|
|
|
class mi_interp final : public interp
|
|
{
|
|
public:
|
|
mi_interp (const char *name)
|
|
: interp (name)
|
|
{}
|
|
|
|
void init (bool top_level) override;
|
|
void resume () override;
|
|
void suspend () override;
|
|
void exec (const char *command_str) override;
|
|
ui_out *interp_ui_out () override;
|
|
void set_logging (ui_file_up logfile, bool logging_redirect,
|
|
bool debug_redirect) override;
|
|
void pre_command_loop () override;
|
|
|
|
void on_signal_received (gdb_signal sig) override;
|
|
void on_signal_exited (gdb_signal sig) override;
|
|
void on_normal_stop (struct bpstat *bs, int print_frame) override;
|
|
void on_exited (int status) override;
|
|
void on_no_history () override;
|
|
void on_sync_execution_done () override;
|
|
void on_command_error () override;
|
|
void on_user_selected_context_changed (user_selected_what selection) override;
|
|
void on_new_thread (thread_info *t) override;
|
|
void on_thread_exited (thread_info *t, int silent) override;
|
|
void on_inferior_added (inferior *inf) override;
|
|
void on_inferior_appeared (inferior *inf) override;
|
|
void on_inferior_disappeared (inferior *inf) override;
|
|
void on_inferior_removed (inferior *inf) override;
|
|
void on_record_changed (inferior *inf, int started, const char *method,
|
|
const char *format) override;
|
|
void on_target_resumed (ptid_t ptid) override;
|
|
void on_solib_loaded (so_list *so) override;
|
|
void on_solib_unloaded (so_list *so) override;
|
|
void on_about_to_proceed () override;
|
|
void on_traceframe_changed (int tfnum, int tpnum) override;
|
|
void on_tsv_created (const trace_state_variable *tsv) override;
|
|
void on_tsv_deleted (const trace_state_variable *tsv) override;
|
|
void on_tsv_modified (const trace_state_variable *tsv) override;
|
|
void on_breakpoint_created (breakpoint *b) override;
|
|
void on_breakpoint_deleted (breakpoint *b) override;
|
|
void on_breakpoint_modified (breakpoint *b) override;
|
|
void on_param_changed (const char *param, const char *value) override;
|
|
void on_memory_changed (inferior *inf, CORE_ADDR addr, ssize_t len,
|
|
const bfd_byte *data) override;
|
|
|
|
/* MI's output channels */
|
|
mi_console_file *out;
|
|
mi_console_file *err;
|
|
mi_console_file *log;
|
|
mi_console_file *targ;
|
|
mi_console_file *event_channel;
|
|
|
|
/* Raw console output. */
|
|
struct ui_file *raw_stdout;
|
|
|
|
/* Save the original value of raw_stdout here when logging, and the
|
|
file which we need to delete, so we can restore correctly when
|
|
done. */
|
|
struct ui_file *saved_raw_stdout;
|
|
ui_file_up logfile_holder;
|
|
ui_file_up stdout_holder;
|
|
|
|
/* MI's builder. */
|
|
struct ui_out *mi_uiout;
|
|
|
|
/* MI's CLI builder (wraps OUT). */
|
|
struct ui_out *cli_uiout;
|
|
|
|
int running_result_record_printed = 1;
|
|
|
|
/* Flag indicating that the target has proceeded since the last
|
|
command was issued. */
|
|
int mi_proceeded;
|
|
};
|
|
|
|
/* Output the shared object attributes to UIOUT. */
|
|
|
|
void mi_output_solib_attribs (ui_out *uiout, struct so_list *solib);
|
|
|
|
/* Returns the INTERP's data cast as mi_interp if INTERP is an MI, and
|
|
returns NULL otherwise. */
|
|
|
|
static inline struct mi_interp *
|
|
as_mi_interp (struct interp *interp)
|
|
{
|
|
return dynamic_cast<mi_interp *> (interp);
|
|
}
|
|
|
|
#endif /* MI_MI_INTERP_H */
|