mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-06 12:09:26 +08:00
fca4cfd9ec
This patch makes gdb_load_shlibs return the destination path of the copied library. To make the procedure implementation and interface more straightforward, it also changes it so that it accepts a single shared library path at the time. Therefore, calls that are passed multiple libraries: gdb_load_shlibs $lib1 $lib2 must be changed to separate calls: gdb_load_shlibs $lib1 gdb_load_shlibs $lib2 A subtle impact is the solib-search-path handling. In the former version, solib-search-path is set using the directory of the first passed lib (further calls overwrite the value). In the later version, the directory of the library passed to the last call to gdb_load_shlibs remnains. I don't think that's a problem in practice, since if we had tests that needed multiple different paths in solib-search-path, they wouldn't work in the first place. Changed in v2: * Split behavioural and rename changes in two separate patches. gdb/testsuite/ChangeLog: * lib/gdb.exp (gdb_load_shlibs): Accept a single argument. Return result of gdb_remote_download. * gdb.base/ctxobj.exp: Split gdb_load_shlibs call. * gdb.base/dso2dso.exp: Likewise. * gdb.base/global-var-nested-by-dso.exp: Likewise. * gdb.base/print-file-var.exp: Likewise. * gdb.base/shlib-call.exp: Likewise. * gdb.base/shreloc.exp: Likewise. * gdb.base/solib-overlap.exp: Likewise. * gdb.base/solib-weak.exp (do_test): Likewise. * gdb.base/unload.exp: Likewise.
76 lines
2.4 KiB
Plaintext
76 lines
2.4 KiB
Plaintext
# Copyright 2015-2016 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# The purpose of this testcase is to verify that we can "next" over
|
|
# a call to a function provided by one shared library made from another
|
|
# shared library, and that GDB stops at the expected location. In this
|
|
# case, the call is made from sub1 (provided by libdso1) and we are
|
|
# calling sub2 (provided by libdso2).
|
|
#
|
|
# Note that, while this is not the main purpose of this testcase, it
|
|
# also happens to exercise an issue with displaced stepping on amd64
|
|
# when libdso1 is mapped at an address greater than 0xffffffff.
|
|
|
|
if { [skip_shlib_tests] } {
|
|
return 0
|
|
}
|
|
|
|
standard_testfile
|
|
|
|
set output_dir [standard_output_file {}]
|
|
|
|
set libdso2 $testfile-dso2
|
|
set srcfile_libdso2 $srcdir/$subdir/$libdso2.c
|
|
set binfile_libdso2 [standard_output_file $libdso2.so]
|
|
|
|
set libdso1 $testfile-dso1
|
|
set srcfile_libdso1 $srcdir/$subdir/$libdso1.c
|
|
set binfile_libdso1 [standard_output_file $libdso1.so]
|
|
|
|
if { [gdb_compile_shlib $srcfile_libdso2 $binfile_libdso2 \
|
|
[list debug additional_flags=-fPIC]] != "" } {
|
|
untested "Could not compile $binfile_libdso2."
|
|
return -1
|
|
}
|
|
|
|
if { [gdb_compile_shlib $srcfile_libdso1 $binfile_libdso1 \
|
|
[list debug additional_flags=-fPIC]] != "" } {
|
|
untested "Could not compile $binfile_libdso1."
|
|
return -1
|
|
}
|
|
|
|
if { [gdb_compile $srcdir/$subdir/$srcfile $binfile executable \
|
|
[list debug shlib=$binfile_libdso2 shlib=$binfile_libdso1]] != "" } {
|
|
return -1
|
|
}
|
|
|
|
clean_restart $binfile
|
|
gdb_load_shlibs $binfile_libdso2
|
|
gdb_load_shlibs $binfile_libdso1
|
|
|
|
if { ![runto_main] } {
|
|
return -1
|
|
}
|
|
|
|
set bp_location [gdb_get_line_number "STOP HERE" [file tail $srcfile_libdso1]]
|
|
gdb_breakpoint ${libdso1}.c:${bp_location}
|
|
|
|
gdb_continue_to_breakpoint "at call to sub2" \
|
|
".*sub2 ().*"
|
|
|
|
gdb_test "next" \
|
|
".*return 5;.*" \
|
|
"next over call to sub2"
|