binutils-gdb/gdb/proc-utils.h
Rainer Orth c475f56919 More Solaris procfs cleanup
This procfs.c (and friends) cleanup patch grew along a couple of lines:

* First I noticed that PR_MODEL_NATIVE is always defined now that
  Solaris 10 is the minimum supported version.

* Then there was a cleanup that I'd missed when removing support for
  !NEW_PROC_API, IRIX, and Tru64 UNIX: given that sysset_t is no longer
  dynamic, there's no need for the special sysset_t_alloc, but we can
  just use XNEW instead.

* Then I found one of those ARI warning mails on gdb-patches, discovered
  how to run it myself and fixed a large number of the warnings, among
  them all uses of sprintf.

  I had to silence the warnings in only 3 instances of the same issue,
  namely references to LDT in function names which are due to the
  libthread_db API.

* Even so, there were several formatting glitches, like braces around
  single statements in an if, which I chose to fix while I was at it.

The result has been tested on amd64-pc-solaris2.11 and
amd64-pc-solaris2.11.

	* proc-utils.h (PROC_CTL_WORD_TYPE): Remove.

	* procfs.c: Don't check for PR_MODEL_NATIVE definition.
	* sparc-sol2-nat.c: Likewise.  Remove Linux, __arch64__ references.
	* sol-thread.c (ps_pdmodel): Don't guard definition.

	* procfs.c: Fix formatting.

	* procfs.c (sysset_t_alloc): Remove.
	(create_procinfo): Use XNEW instead of sysset_t_alloc.
	(procfs_debug_inferior): Likewise.
	(procfs_set_exec_trap): Likewise.
	(proc_set_traced_sysentry): Don't allocate argp dynamically.
	(proc_set_traced_sysexit): Likewise.

	* procfs.c (create_procinfo): Use xsnprintf to fix ARI warning.
	(dead_procinfo): Likewise.
	(proc_warn): Likewise.
	(proc_error): Likewise.
	(proc_get_LDT_entry): Likewise.
	(do_attach): Likewise.
	(procfs_target::pid_to_str): Likewise.
	(iterate_over_mappings): Likewise.

	* procfs.c (create_procinfo): Fix ARI warning.
	(proc_get_status): Likewise.
	(proc_stop_process): Likewise.
	(proc_run_process): Likewise.
	(proc_kill): Likewise.
	(proc_get_LDT_entry): Likewise.
	(procfs_find_LDT_entry): Likewise.
	(proc_update_threads): Likewise.
	(proc_iterate_over_threads): Likewise.
	(do_attach): Likewise.
	(procfs_xfer_memory): Likewise.
	(invalidate_cache): Likewise.
	(procfs_target::resume): Likewise.
	(procfs_init_inferior): Likewise.
	(procfs_set_exec_trap): Likewise.
	(procfs_target::thread_alive): Likewise.
	(procfs_target::pid_to_exec_file): Likewise.
	(iterate_over_mappings): Likewise.
	(procfs_target::make_corefile_notes): Likewise.
	* sol-thread.c (sol_thread_target::thread_alive): Likewise.

	* procfs.c (procfs_find_LDT_entry): Silence ARI warning.
	(procfs_find_LDT_entry): Likewise.
	* sol-thread.c (ps_lgetLDT): Likewise.
2018-09-20 20:01:05 +02:00

116 lines
3.8 KiB
C

/* Machine independent support for SVR4 /proc (process file system) for GDB.
Copyright (C) 1999-2018 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
/* From proc-why.c */
/*
* Pretty-print functions for /proc data
*/
extern void proc_prettyprint_why (unsigned long why, unsigned long what,
int verbose);
extern void proc_prettyprint_syscalls (sysset_t *sysset, int verbose);
extern void proc_prettyprint_syscall (int num, int verbose);
extern void proc_prettyprint_signalset (sigset_t *sigset, int verbose);
extern void proc_prettyprint_signal (int signo, int verbose);
extern void proc_prettyprint_faultset (fltset_t *fltset, int verbose);
extern void proc_prettyprint_fault (int faultno, int verbose);
extern void proc_prettyprint_actionset (struct sigaction *actions,
int verbose);
extern void proc_prettyfprint_signalset (FILE *file, sigset_t *sigset,
int verbose);
extern void proc_prettyfprint_faultset (FILE *file, fltset_t *fltset,
int verbose);
extern void proc_prettyfprint_syscall (FILE *file, int num, int verbose);
extern void proc_prettyfprint_signal (FILE *file, int signo, int verbose);
extern void proc_prettyfprint_flags (FILE *file, unsigned long flags,
int verbose);
extern void proc_prettyfprint_why (FILE *file, unsigned long why,
unsigned long what, int verbose);
extern void proc_prettyfprint_fault (FILE *file, int faultno, int verbose);
extern void proc_prettyfprint_syscalls (FILE *file, sysset_t *sysset,
int verbose);
extern void proc_prettyfprint_status (long, int, int, int);
/* From proc-flags.c */
/*
* Pretty-print the prstatus flags.
*/
extern void proc_prettyprint_flags (unsigned long flags, int verbose);
extern void proc_prettyfprint_flags (FILE *file, unsigned long flags,
int verbose);
/* From proc-api.c */
/*
* Trace functions for /proc api.
*/
extern int write_with_trace (int, void *, size_t, char *, int);
extern off_t lseek_with_trace (int, off_t, int, char *, int);
extern int ioctl_with_trace (int, long, void *, char *, int);
extern pid_t wait_with_trace (int *, char *, int);
extern int open_with_trace (char *, int, char *, int);
extern int close_with_trace (int, char *, int);
extern void procfs_note (const char *, const char *, int);
#ifdef PROCFS_TRACE
/*
* Debugging code:
*
* These macros allow me to trace the system calls that we make
* to control the child process. This is quite handy for comparing
* with the older version of procfs.
*/
#define write(X,Y,Z) write_with_trace (X, Y, Z, __FILE__, __LINE__)
#define lseek(X,Y,Z) lseek_with_trace (X, Y, Z, __FILE__, __LINE__)
#define ioctl(X,Y,Z) ioctl_with_trace (X, Y, Z, __FILE__, __LINE__)
#define open(X,Y) open_with_trace (X, Y, __FILE__, __LINE__)
#define close(X) close_with_trace (X, __FILE__, __LINE__)
#define wait(X) wait_with_trace (X, __FILE__, __LINE__)
#endif
#define PROCFS_NOTE(X) procfs_note (X, __FILE__, __LINE__)
#define PROC_PRETTYFPRINT_STATUS(X,Y,Z,T) \
proc_prettyfprint_status (X, Y, Z, T)
/* Define the type (and more importantly the width) of the control
word used to write to the /proc/PID/ctl file. */
typedef long procfs_ctl_t;