mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-15 04:31:49 +08:00
656efb5e26
Gentoo has a local GCC patch which always defines _FORTIFY_SOURCE=2.
This causes a build problem when building GDB there, because
"common/common-defs.h" also defines _FORTIFY_SOURCE=2:
CXX gdb.o
In file included from ../../gdb/defs.h:28:0,
from ../../gdb/gdb.c:19:
../../gdb/common/common-defs.h:71:0: error: "_FORTIFY_SOURCE" redefined [-Werror]
#define _FORTIFY_SOURCE 2
<built-in>: note: this is the location of the previous definition
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:1619: gdb.o] Error 1
Even though it is questionable whether Gentoo's approach is the
correct one:
https://jira.mongodb.org/browse/SERVER-29982
https://bugs.gentoo.org/621036
it is still possible for GDB to be a bit more robust here and make
sure it just defines _FORTIFY_SOURCE if it hasn't been defined
already. This patch does that.
Tested by rebuilding and making sure the macro was defined.
gdb/ChangeLog:
2018-10-31 Sergio Durigan Junior <sergiodj@redhat.com>
PR gdb/23835
* common/common-defs.h: Don't redefine _FORTIFY_SOURCE if it's
already defined.
131 lines
4.1 KiB
C
131 lines
4.1 KiB
C
/* Common definitions.
|
|
|
|
Copyright (C) 1986-2018 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef COMMON_DEFS_H
|
|
#define COMMON_DEFS_H
|
|
|
|
#include "config.h"
|
|
|
|
#undef PACKAGE_NAME
|
|
#undef PACKAGE_VERSION
|
|
#undef PACKAGE_STRING
|
|
#undef PACKAGE_TARNAME
|
|
|
|
#ifdef GDBSERVER
|
|
#include "build-gnulib-gdbserver/config.h"
|
|
#else
|
|
#include "build-gnulib/config.h"
|
|
#endif
|
|
|
|
#undef PACKAGE_NAME
|
|
#undef PACKAGE_VERSION
|
|
#undef PACKAGE_STRING
|
|
#undef PACKAGE_TARNAME
|
|
|
|
/* From:
|
|
https://www.gnu.org/software/gnulib/manual/html_node/stdint_002eh.html
|
|
|
|
"On some hosts that predate C++11, when using C++ one must define
|
|
__STDC_CONSTANT_MACROS to make visible the definitions of constant
|
|
macros such as INTMAX_C, and one must define __STDC_LIMIT_MACROS to
|
|
make visible the definitions of limit macros such as INTMAX_MAX.".
|
|
|
|
And:
|
|
https://www.gnu.org/software/gnulib/manual/html_node/inttypes_002eh.html
|
|
|
|
"On some hosts that predate C++11, when using C++ one must define
|
|
__STDC_FORMAT_MACROS to make visible the declarations of format
|
|
macros such as PRIdMAX."
|
|
|
|
Must do this before including any system header, since other system
|
|
headers may include stdint.h/inttypes.h. */
|
|
#define __STDC_CONSTANT_MACROS 1
|
|
#define __STDC_LIMIT_MACROS 1
|
|
#define __STDC_FORMAT_MACROS 1
|
|
|
|
/* Some distros enable _FORTIFY_SOURCE by default, which on occasion
|
|
has caused build failures with -Wunused-result when a patch is
|
|
developed on a distro that does not enable _FORTIFY_SOURCE. We
|
|
enable it here in order to try to catch these problems earlier;
|
|
plus this seems like a reasonable safety measure. The check for
|
|
optimization is required because _FORTIFY_SOURCE only works when
|
|
optimization is enabled. If _FORTIFY_SOURCE is already defined,
|
|
then we don't do anything. */
|
|
|
|
#if !defined _FORTIFY_SOURCE && defined __OPTIMIZE__ && __OPTIMIZE__ > 0
|
|
#define _FORTIFY_SOURCE 2
|
|
#endif
|
|
|
|
#include <stdarg.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <stddef.h>
|
|
#include <stdint.h>
|
|
#include <string.h>
|
|
#ifdef HAVE_STRINGS_H
|
|
#include <strings.h> /* for strcasecmp and strncasecmp */
|
|
#endif
|
|
#include <errno.h>
|
|
#include <alloca.h>
|
|
|
|
#include "ansidecl.h"
|
|
/* This is defined by ansidecl.h, but we prefer gnulib's version. On
|
|
MinGW, gnulib might enable __USE_MINGW_ANSI_STDIO, which may or not
|
|
require use of attribute gnu_printf instead of printf. gnulib
|
|
checks that at configure time. Since _GL_ATTRIBUTE_FORMAT_PRINTF
|
|
is compatible with ATTRIBUTE_PRINTF, simply use it. */
|
|
#undef ATTRIBUTE_PRINTF
|
|
#define ATTRIBUTE_PRINTF _GL_ATTRIBUTE_FORMAT_PRINTF
|
|
|
|
#include "libiberty.h"
|
|
#include "pathmax.h"
|
|
#include "gdb/signals.h"
|
|
#include "gdb_locale.h"
|
|
#include "ptid.h"
|
|
#include "common-types.h"
|
|
#include "common-utils.h"
|
|
#include "gdb_assert.h"
|
|
#include "errors.h"
|
|
#include "print-utils.h"
|
|
#include "common-debug.h"
|
|
#include "cleanups.h"
|
|
#include "common-exceptions.h"
|
|
#include "common/poison.h"
|
|
|
|
#define EXTERN_C extern "C"
|
|
#define EXTERN_C_PUSH extern "C" {
|
|
#define EXTERN_C_POP }
|
|
|
|
/* Pull in gdb::unique_xmalloc_ptr. */
|
|
#include "common/gdb_unique_ptr.h"
|
|
|
|
/* String containing the current directory (what getwd would return). */
|
|
extern char *current_directory;
|
|
|
|
/* sbrk on macOS is not useful for our purposes, since sbrk(0) always
|
|
returns the same value. brk/sbrk on macOS is just an emulation
|
|
that always returns a pointer to a 4MB section reserved for
|
|
that. */
|
|
|
|
#if defined (HAVE_SBRK) && !__APPLE__
|
|
#define HAVE_USEFUL_SBRK 1
|
|
#endif
|
|
|
|
#endif /* COMMON_DEFS_H */
|