binutils-gdb/ld/testsuite/ld-elf/elf.exp
H.J. Lu 74e315dbfe elf: Set p_align to the minimum page size if possible
Currently, on 32-bit and 64-bit ARM, it seems that ld generates p_align
values of 0x10000 even if no section alignment is greater than 0x1000.
The issue is more general and probably affects other targets with multiple
page sizes.

While file layout absolutely must take 64K page size into account, that
does not have to be reflected in the p_align value.  If running on a 64K
kernel, the file will be loaded at a 64K page boundary by necessity. On
a 4K kernel, 64K alignment is not needed.

The glibc loader has been fixed to honor p_align:

https://sourceware.org/bugzilla/show_bug.cgi?id=28676

similar to kernel:

commit ce81bb256a224259ab686742a6284930cbe4f1fa
Author: Chris Kennelly <ckennelly@google.com>
Date:   Thu Oct 15 20:12:32 2020 -0700

    fs/binfmt_elf: use PT_LOAD p_align values for suitable start address

This means that on 4K kernels, we will start to do extra work for 64K
p_align, but this pointless for pretty much all binaries (whose section
alignment rarely exceeds 16).

The minimum page size is used, instead of the maximum section alignment
due to this glibc bug:

https://sourceware.org/bugzilla/show_bug.cgi?id=28688

It has been fixed in glibc 2.35.  But linker output must work on existing
glibc binaries.

1. Set p_align to the minimum page size while laying out segments aligning
to the maximum page size or section alignment.  The run-time loader can
align segments to the minimum page size or above, depending on system page
size.
2. If -z max-page-size=NNN is used, p_align will be set to the maximum
page size or the largest section alignment.
3. If a section requires alignment higher than the minimum page size,
don't set p_align to the minimum page size.
4. If a section requires alignment higher than the maximum page size,
set p_align to the section alignment.
5. For objcopy, when the minimum page size != the maximum page size,
p_align may be set to the minimum page size while segments are aligned
to the maximum page size.  In this case, the input p_align will be
ignored and the maximum page size will be used to align the ouput
segments.
6. Update linker to disallow the common page size > the maximum page size.
7. Update linker to avoid the common page size > the maximum page size.
8. Adjust pru_irq_map-1.d to expect p_align == sh_addralign:

Section Headers:
  [Nr] Name   Type            Addr     Off    Size   ES Flg Lk Inf Al
  [ 0]        NULL            00000000 000000 000000 00      0   0  0
  [ 1] .text  PROGBITS        20000000 00007c 000004 00  AX  0   0  4
...
Program Headers:
  Type           Offset   VirtAddr   PhysAddr   FileSiz MemSiz  Flg Align
  LOAD           0x000074 0x00000000 0x00000000 0x00008 0x00008 RW  0x1
  LOAD           0x00007c 0x20000000 0x20000000 0x00004 0x00004 R E 0x4

vs.

Section Headers:
  [Nr] Name   Type            Addr     Off    Size   ES Flg Lk Inf Al
  [ 0]        NULL            00000000 000000 000000 00      0   0  0
  [ 1] .text  PROGBITS        20000000 00007c 000004 00  AX  0   0  4
...
Program Headers:
  Type           Offset   VirtAddr   PhysAddr   FileSiz MemSiz  Flg Align
  LOAD           0x000074 0x00000000 0x00000000 0x00008 0x00008 RW  0x1
  LOAD           0x00007c 0x20000000 0x20000000 0x00004 0x00004 R E 0x1

To enable this linker optimization, the backend should define ELF_P_ALIGN
to ELF_MINPAGESIZE.

bfd/

	PR ld/28689
	PR ld/28695
	* elf-bfd.h (elf_backend_data): Add p_align.
	* elf.c (assign_file_positions_for_load_sections): Set p_align
	to the default p_align value while laying out segments aligning
	to maximum page size or section alignment.
	(elf_is_p_align_valid): New function.
	(copy_elf_program_header): Call elf_is_p_align_valid to determine
	if p_align is valid.
	* elfxx-target.h (ELF_P_ALIGN): New.  Default to 0.
	(elfNN_bed): Add ELF_P_ALIGN.
	* elfxx-x86.h (ELF_P_ALIGN): New.  Set to ELF_MINPAGESIZE.

include/

	PR ld/28689
	PR ld/28695
	* bfdlink.h (bfd_link_info): Add maxpagesize_is_set.

ld/

	PR ld/28689
	PR ld/28695
	* emultempl/elf.em (gld${EMULATION_NAME}_handle_option): Set
	link_info.maxpagesize_is_set for -z max-page-size=NNN.
	* ldelf.c (ldelf_after_parse): Disallow link_info.commonpagesize
	> link_info.maxpagesize.
	* testsuite/ld-elf/elf.exp: Pass -z max-page-size=0x4000 to
	linker to build mbind2a and mbind2b.
	* testsuite/ld-elf/header.d: Add -z common-page-size=0x100.
	* testsuite/ld-elf/linux-x86.exp: Add PR ld/28689 tests.
	* testsuite/ld-elf/p_align-1.c: New file.
	* testsuite/ld-elf/page-size-1.d: New test.
	* testsuite/ld-elf/pr26936.d: Add -z common-page-size=0x1000.
	* testsuite/ld-elf/seg.d: Likewise.
	* testsuite/ld-scripts/rgn-at5.d: Likewise.
	* testsuite/ld-pru/pru_irq_map-1.d: Append 1 to name.  Adjust
	expected PT_LOAD segment alignment.
	* testsuite/ld-pru/pru_irq_map-2.d: Append 2 to name.
	* testsuite/ld-scripts/pr23571.d: Add -z max-page-size=0x1000.
2022-01-05 05:06:18 -08:00

514 lines
12 KiB
Plaintext

# Expect script for various ELF tests.
# Copyright (C) 2002-2022 Free Software Foundation, Inc.
#
# This file is part of the GNU Binutils.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
# MA 02110-1301, USA.
#
# Exclude non-ELF targets.
if ![is_elf_format] {
return
}
# Return true if target is riscv little endian.
# xfail the riscv little endain targets for the compressed1d1 test;
# The riscv big endian targets and others should pass.
proc riscv_little_endian { } {
if { [istarget "riscv32-*-*"]
|| [istarget "riscv64-*-*"]
|| [istarget "riscv32le-*-*"]
|| [istarget "riscv64le-*-*"] } {
return 1
}
return 0
}
set old_ldflags $LDFLAGS
if { [istarget spu*-*-*] } {
set LDFLAGS "$LDFLAGS --local-store 0:0"
}
# hpux .comm differs from everyone else
set hpux ""
set old_asflags $ASFLAGS
if [istarget "*-*-hpux*"] {
set hpux "--defsym HPUX=1"
set ASFLAGS "$ASFLAGS --defsym HPUX=1"
}
if { [istarget alpha*-*-* ] } {
# The compress1 test is written expecting 32-bit addresses; force the
# executable down into the low address space to match.
# ??? How can we adjust just the one testcase?
set LDFLAGS "$LDFLAGS -Ttext-segment 0x1000000"
set ASFLAGS "$ASFLAGS --defsym NO_SET=1"
}
if [istarget "tic6x-*-*"] {
append ASFLAGS " -mpic -mpid=near"
}
if { [istarget "*-*-solaris*"] } {
# Same for Solaris
set options_regsub(ld) {-melf_x86_64 -melf_x86_64_sol2}
}
if { [is_remote host] } then {
remote_download host merge.ld
}
# Note - the output file from the second test (symbol3w.a) is
# used in the proc is_elf64 test below...
run_ld_link_tests [list \
[list "Build symbol3.a" \
"" "" $hpux \
{symbol3.s} {} "symbol3.a" ] \
[list "Build symbol3w.a" \
"" "" "" \
{symbol3w.s} {} "symbol3w.a" ] \
]
if [is_elf64 tmpdir/symbol3w.a] {
set ASFLAGS "$ASFLAGS --defsym ALIGN=3"
set pr23900_1_exp "pr23900-1-64.rd"
set pr25490_2_exp "pr25490-2-64.rd"
set pr25490_3_exp "pr25490-3-64.rd"
set pr25490_4_exp "pr25490-4-64.rd"
set pr25490_5_exp "pr25490-5-64.rd"
set pr25490_6_exp "pr25490-6-64.rd"
} else {
set ASFLAGS "$ASFLAGS --defsym ALIGN=2"
set pr23900_1_exp "pr23900-1-32.rd"
if { [istarget avr-*-*]
|| [istarget h8300-*-*]
|| [istarget ip2k-*-*]
|| [istarget m68hc11-*]
|| [istarget "xc16x-*"]
|| [istarget "z80-*-*"] } {
set pr25490_2_exp "pr25490-2-16.rd"
set pr25490_3_exp "pr25490-3-16.rd"
set pr25490_4_exp "pr25490-4-16.rd"
set pr25490_5_exp "pr25490-5-16.rd"
set pr25490_6_exp "pr25490-6-16.rd"
} else {
set pr25490_2_exp "pr25490-2-32.rd"
set pr25490_3_exp "pr25490-3-32.rd"
set pr25490_4_exp "pr25490-4-32.rd"
set pr25490_5_exp "pr25490-5-32.rd"
set pr25490_6_exp "pr25490-6-32.rd"
}
}
# Targets that use _bfd_generic_link_add_symbols won't pass pr21703 tests
run_ld_link_tests {
{"PR ld/21703"
"--allow-multiple-definition tmpdir/pr21703-1.o tmpdir/pr21703-2.o" "" "" \
{pr21703-1.s pr21703-2.s} {{readelf {-s} pr21703.sd}} "pr21703" }
{"PR ld/21703 -r"
"-r --allow-multiple-definition tmpdir/pr21703-3.o tmpdir/pr21703-4.o" "" "" \
{pr21703-3.s pr21703-4.s} {{readelf {-s} pr21703-r.sd}} "pr21703.o" }
} \[is_generic\]
if [is_underscore_target] {
set ASFLAGS "$ASFLAGS --defsym UNDERSCORE=1"
}
set saved_ASFLAGS "$ASFLAGS"
if { [istarget "i?86-*-*"] || [istarget "x86_64-*-*"] } {
set ASFLAGS "$ASFLAGS -mx86-used-note=no"
}
# Build libraries required for SHF_GNU_RETAIN tests.
if { [check_gc_sections_available] && [supports_gnu_osabi] } {
run_ld_link_tests [list \
[list "Build libretain5.a" "" "" "" \
{retain5lib.s} {} "libretain5.a"] \
[list "Build libretain6.a" "" "" "" \
{retain6lib.s} {} "libretain6.a"] \
]
}
set test_list [lsort [glob -nocomplain $srcdir/$subdir/*.d]]
foreach t $test_list {
# We need to strip the ".d", but can leave the dirname.
verbose [file rootname $t]
run_dump_test [file rootname $t]
}
set ASFLAGS "$saved_ASFLAGS"
# Check that the --out-implib option work correctly.
# Targets that don't use elf.em won't support this.
run_ld_link_tests [list \
[list "Generate empty import library" \
"--out-implib=tmpdir/implib.lib" "" \
[concat "--defsym NO_GLOBAL=1" $hpux] \
{implib.s} \
{{ld empty-implib.out}} \
"implib" ] \
[list "Generate import library" \
"--out-implib=tmpdir/implib.lib" "" \
$hpux \
{implib.s} \
{{readelf {-s tmpdir/implib.lib} implib.rd}} \
"implib" ] \
] \[uses_genelf\]
#v850 gas complains about .tbss.var section attributes.
if { [check_gc_sections_available] && ![istarget "v850-*-*"] } {
run_ld_link_tests {
{"--gc-sections on tls variable"
"--gc-section" "" "" {tls_gc.s} {} "tls_gc"}
}
}
if { [istarget *-*-*linux*]
|| [istarget *-*-nacl*]
|| [istarget *-*-gnu*] } {
run_ld_link_tests [list \
[list "stack exec" \
"-z execstack" \
"" \
"" \
{stack.s} \
{{readelf {-Wl} stack-exec.rd}} \
"stack-exec.exe"] \
[list "stack noexec" \
"-z noexecstack" \
"" \
"" \
{stack.s} \
{{readelf {-Wl} stack-noexec.rd}} \
"stack-noexec.exe"] \
[list "stack size" \
"-z stack-size=0x123400" \
"" \
"" \
{stack.s} \
{{readelf {-Wl} stack-size.rd}} \
"stack-size.exe"] \
[list "PT_GNU_PROPERTY alignment" \
"" \
"" \
"" \
{pr23900-1.s} \
[list [list "readelf" {-Wl} $pr23900_1_exp]] \
"pr23900-1.exe"] \
]
}
if [check_gc_sections_available] {
run_ld_link_tests [list \
[list "__patchable_function_entries section 2" \
"--gc-sections -e _start" \
"" \
"" \
{pr25490-2.s} \
[list [list "readelf" {-SW} $pr25490_2_exp]] \
"pr25490-2.exe"] \
[list "__patchable_function_entries section 3" \
"--gc-sections -e _start" \
"" \
"" \
{pr25490-3.s} \
[list [list "readelf" {-SW} $pr25490_3_exp]] \
"pr25490-3.exe"] \
[list "__patchable_function_entries section 4" \
"--gc-sections -e _start" \
"" \
"" \
{pr25490-4.s} \
[list [list "readelf" {-SW} $pr25490_4_exp]] \
"pr25490-4.exe"] \
[list "__patchable_function_entries section 5" \
"--gc-sections -e _start" \
"" \
"" \
{pr25490-5.s} \
[list [list "readelf" {-SW} $pr25490_5_exp]] \
"pr25490-5.exe"] \
[list "__patchable_function_entries section 6" \
"--gc-sections -e _start" \
"" \
"" \
{pr25490-6.s} \
[list [list "readelf" {-SW} $pr25490_6_exp]] \
"pr25490-6.exe"] \
]
}
set LDFLAGS $old_ldflags
set ASFLAGS $old_asflags
# Check to see if the C compiler works
if { ![check_compiler_available] } {
return
}
if [check_gc_sections_available] {
run_cc_link_tests {
{"PR ld/13195" "-Wl,--gc-sections" ""
{pr13195.c} {} "pr13195"}
}
}
set array_tests {
{"preinit array" "" ""
{preinit.c} "preinit" "preinit.out"}
{"init array" "" ""
{init.c} "init" "init.out"}
{"fini array" "" ""
{fini.c} "fini" "fini.out"}
{"init array mixed" "" ""
{init-mixed.c} "init-mixed" "init-mixed.out" "-I."}
}
set array_tests_pie {
{"PIE preinit array" "-pie" ""
{preinit.c} "preinit" "preinit.out" "-fPIE"}
{"PIE init array" "-pie" ""
{init.c} "init" "init.out" "-fPIE"}
{"PIE fini array" "-pie" ""
{fini.c} "fini" "fini.out" "-fPIE"}
{"PIE init array mixed" "-pie" ""
{init-mixed.c} "init-mixed" "init-mixed.out" "-I. -fPIE"}
{"PIE PR ld/14525" "-pie" ""
{pr14525.c} "pr14525" "pr14525.out" "-fPIE"}
}
set array_tests_static {
{"static preinit array" "-static" ""
{preinit.c} "preinit" "preinit.out"}
{"static init array" "-static" ""
{init.c} "init" "init.out"}
{"static fini array" "-static" ""
{fini.c} "fini" "fini.out"}
{"static init array mixed" "-static" ""
{init-mixed.c} "init-mixed" "init-mixed.out" "-I."}
}
# NetBSD ELF systems do not currently support the .*_array sections.
set xfails "*-*-netbsd*"
run_ld_link_exec_tests $array_tests $xfails
if { [istarget *-*-linux*]
|| [istarget *-*-nacl*]
|| [istarget *-*-gnu*] } {
run_ld_link_exec_tests $array_tests_pie $xfails
if { $STATIC_PIE_LDFLAGS != "" } then {
run_ld_link_exec_tests [list \
[list \
"Static PIE preinit array" \
"$STATIC_PIE_LDFLAGS" \
"" \
{preinit.c} \
"preinit-static-pie" \
"preinit.out" \
"-fPIE" \
] \
[list \
"Static PIE init array" \
"$STATIC_PIE_LDFLAGS" \
"" \
{init.c} \
"init-static-pie" \
"init.out" \
"-fPIE" \
] \
[list \
"Static PIE fini array" \
"$STATIC_PIE_LDFLAGS" \
"" \
{fini.c} \
"fini-static-pie" \
"fini.out" \
"-fPIE" \
] \
[list \
"Static PIE init array mixed" \
"$STATIC_PIE_LDFLAGS" \
"" \
{init-mixed.c} \
"init-mixed-static-pie" \
"init-mixed.out" \
"-I. -fPIE" \
] \
[list \
"Static PIE PR ld/14525" \
"$STATIC_PIE_LDFLAGS" \
"" \
{pr14525.c} \
"pr14525-static-pie" \
"pr14525.out" \
"-fPIE" \
] \
]
}
run_ld_link_exec_tests [list \
[list \
"Run mbind2a" \
"$NOPIE_LDFLAGS -Wl,-z,common-page-size=0x4000,-z,max-page-size=0x4000" \
"" \
{ mbind2a.s mbind2b.c } \
"mbind2a" \
"pass.out" \
"-O2 -I../bfd" \
] \
[list \
"Run mbind2b" \
"-static -Wl,-z,common-page-size=0x4000,-z,max-page-size=0x4000" \
"" \
{ mbind2a.s mbind2b.c } \
"mbind2b" \
"pass.out" \
"-O2 -I../bfd" \
] \
]
}
run_ld_link_exec_tests $array_tests_static $xfails
run_cc_link_tests [list \
[list \
"Build pr26391-1" \
"-Wl,-z,unique-symbol" \
"-fno-function-sections" \
{pr26391a.c pr26391b.c pr26391c.c pr26391d.c} \
{{nm "" pr26391.nd}} \
"pr26391-1" \
] \
[list \
"Build pr26391-2" \
"-Wl,-z,unique-symbol" \
"-ffunction-sections" \
{pr26391a.c pr26391b.c pr26391c.c pr26391d.c} \
{{nm "" pr26391.nd}} \
"pr26391-2" \
] \
[list \
"Build pr26391-3" \
"-Wl,-z,unique-symbol,--emit-relocs" \
"-fno-function-sections" \
{pr26391a.c pr26391b.c pr26391c.c pr26391d.c} \
{{nm "" pr26391.nd}} \
"pr26391-3" \
] \
[list \
"Build pr26391-4" \
"-Wl,-z,unique-symbol,--emit-relocs" \
"-ffunction-sections" \
{pr26391a.c pr26391b.c pr26391c.c pr26391d.c} \
{{nm "" pr26391.nd}} \
"pr26391-4" \
] \
]
run_ld_link_tests [list \
[list \
"Build pr26391-5.o" \
"-z unique-symbol -r" \
"" \
"" \
{pr26391a.c pr26391b.c pr26391c.c pr26391d.c} \
[list \
[list "nm" "$dep_plug_opt" "pr26391.nd"] \
[list "nm" "$dep_plug_opt" "pr26391.fd"] \
] \
"pr26391-5.o" \
"-fno-function-sections" \
] \
[list \
"Build pr26391-6.o" \
"-z unique-symbol -r" \
"" \
"" \
{pr26391a.c pr26391b.c pr26391c.c pr26391d.c} \
{{nm "" pr26391.nd}} \
"pr26391-6.o" \
"-ffunction-sections" \
] \
]
run_ld_link_exec_tests [list \
[list \
"Run pr26391-1" \
"-Wl,-z,unique-symbol" \
"" \
{pr26391a.c pr26391b.c pr26391c.c pr26391d.c} \
"pr26391-1" \
"pr26391.out" \
"-fno-function-sections" \
] \
[list \
"Run pr26391-2" \
"-Wl,-z,unique-symbol" \
"" \
{pr26391a.c pr26391b.c pr26391c.c pr26391d.c} \
"pr26391-2" \
"pr26391.out" \
"-ffunction-sections" \
] \
[list \
"Run pr26391-3" \
"-Wl,-z,unique-symbol,--emit-relocs" \
"" \
{pr26391a.c pr26391b.c pr26391c.c pr26391d.c} \
"pr26391-3" \
"pr26391.out" \
"-fno-function-sections" \
] \
[list \
"Run pr26391-4" \
"-Wl,-z,unique-symbol,--emit-relocs" \
"" \
{pr26391a.c pr26391b.c pr26391c.c pr26391d.c} \
"pr26391-4" \
"pr26391.out" \
"-ffunction-sections" \
] \
[list \
"Run pr26391-5" \
"-Wl,-z,unique-symbol" \
"" \
{dummy.c} \
"pr26391-5" \
"pr26391.out" \
"" \
"c" \
"" \
"tmpdir/pr26391-5.o" \
] \
[list \
"Run pr26391-6" \
"-Wl,-z,unique-symbol" \
"" \
{dummy.c} \
"pr26391-6" \
"pr26391.out" \
"" \
"c" \
"" \
"tmpdir/pr26391-6.o" \
] \
]
catch "exec rm -f tmpdir/preinit tmpdir/init tmpdir/fini tmpdir/init-mixed" status