mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-03-01 13:26:47 +08:00
f8745e1cd1
This is a regression for the corner case of a hidden symbol in a PIC/PIE binary which is subject to both a new-style GOTDATA relocation and an old-style GOT relocation. In this case, depending on the link order, the R_SPARC_RELATIVE dynamic relocation for the GOT slot needed because of the old-style relocation can be replaced with R_SPARC_NONE coming from the GOTDATA relocation. The fix simply records whether an old-style GOT relocation is seen for a symbol and prevents the R_SPARC_NONE from being generated in this case. bfd/ * elfxx-sparc.c (struct _bfd_sparc_elf_link_hash_entry): Add new flag has_old_style_got_reloc. (_bfd_sparc_elf_check_relocs) <GOT relocations>: Set it for old-style relocations. Fix a couple of long lines. (_bfd_sparc_elf_relocate_section) <R_SPARC_GOTDATA_OP>: Do not generate a R_SPARC_NONE for the GOT slot if the symbol is also subject to old-style GOT relocations. ld/ * testsuite/ld-sparc/sparc.exp: Add test for mixed GOTDATA/GOT relocs. * testsuite/ld-sparc/gotop-hidden.c: New file. * testsuite/ld-sparc/got-hidden32.s: Likewise. * testsuite/ld-sparc/got-hidden64.s: Likewise. * testsuite/ld-sparc/pass.out: Likewise. |
||
|---|---|---|
| .. | ||
| config | ||
| ld-aarch64 | ||
| ld-alpha | ||
| ld-arc | ||
| ld-arm | ||
| ld-auto-import | ||
| ld-avr | ||
| ld-bootstrap | ||
| ld-cdtest | ||
| ld-checks | ||
| ld-cris | ||
| ld-crx | ||
| ld-cygwin | ||
| ld-d10v | ||
| ld-discard | ||
| ld-elf | ||
| ld-elfcomm | ||
| ld-elfvers | ||
| ld-elfvsb | ||
| ld-elfweak | ||
| ld-fastcall | ||
| ld-frv | ||
| ld-gc | ||
| ld-h8300 | ||
| ld-i386 | ||
| ld-ia64 | ||
| ld-ifunc | ||
| ld-libs | ||
| ld-linkonce | ||
| ld-m68hc11 | ||
| ld-m68k | ||
| ld-mep | ||
| ld-metag | ||
| ld-mips-elf | ||
| ld-misc | ||
| ld-mmix | ||
| ld-mn10300 | ||
| ld-msp430-elf | ||
| ld-nds32 | ||
| ld-nios2 | ||
| ld-pe | ||
| ld-pie | ||
| ld-plugin | ||
| ld-powerpc | ||
| ld-pru | ||
| ld-riscv-elf | ||
| ld-s390 | ||
| ld-scripts | ||
| ld-selective | ||
| ld-sh | ||
| ld-shared | ||
| ld-size | ||
| ld-sparc | ||
| ld-spu | ||
| ld-srec | ||
| ld-tic6x | ||
| ld-tilegx | ||
| ld-tilepro | ||
| ld-undefined | ||
| ld-unique | ||
| ld-v850 | ||
| ld-vax-elf | ||
| ld-versados | ||
| ld-visium | ||
| ld-vxworks | ||
| ld-x86-64 | ||
| ld-xc16x | ||
| ld-xstormy16 | ||
| ld-xtensa | ||
| ld-z8k | ||
| lib | ||
| ChangeLog-2004 | ||
| ChangeLog-2005 | ||
| ChangeLog-2006 | ||
| ChangeLog-2007 | ||
| ChangeLog-2008 | ||
| ChangeLog-2009 | ||
| ChangeLog-2010 | ||
| ChangeLog-2011 | ||
| ChangeLog-2012 | ||
| ChangeLog-2013 | ||
| ChangeLog-2014 | ||
| ChangeLog-2015 | ||
| ChangeLog-9303 | ||