Go to file
Sergio Durigan Junior f469e8ce11 Improve error reporting when handling SystemTap SDT probes
This patch improves the error reporting when handling SystemTap SDT
probes.  "Handling", in this case, mostly means "parsing".

On gdb/probe.h, only trivial changes on functions' comments in order
to explicitly mention that some of them can throw exceptions.  This is
just to make the API a bit more clear.

On gdb/stap-probe.c, I have s/internal_error/error/ on two functions
that are responsible for parsing specific bits of the probes'
arguments: stap_get_opcode and stap_get_expected_argument_type.  It is
not correct to call internal_error on such situations because it is
not really GDB's fault if the probes have malformed arguments.  I also
improved the error reported on stap_get_expected_argument_type by also
including the probe name on it.

Aside from that, and perhaps most importantly, I added a check on
stap_get_arg to make sure that we don't try to extract an argument
from a probe that has no arguments.  This check issues an
internal_error, because it really means that GDB is doing something it
shouldn't.

Although it can be considered almost trivial, and despite the fact
that I am the maintainer for this part of the code, I am posting this
patch for review.  I will wait a few days, and if nobody has anything
to say, I will go ahead and push it.

gdb/ChangeLog:
2015-09-01  Sergio Durigan Junior  <sergiodj@redhat.com>

	* probe.h (struct probe_ops) <get_probe_argument_count,
	evaluate_probe_argument, enable_probe, disable_probe>: Mention in
	the comment that the function can throw an exception.
	(get_probe_argument_count): Likewise.
	(evaluate_probe_argument): Likewise.
	* stap-probe.c (stap_get_opcode): Call error instead of
	internal_error.
	(stap_get_expected_argument_type): Likewise.  Add argument
	'probe'.  Improve error message by mentioning the probe's name.
	(stap_parse_probe_arguments): Adjust call to
	stap_get_expected_argument_type.
	(stap_get_arg): Add comment.  Assert that 'probe->args_parsed' is
	not zero.  Call internal_error if GDB requests an argument but the
	probe has no arguments.
2015-09-02 00:11:30 -04:00
bfd Automatic date update in version.in 2015-09-02 00:00:08 +00:00
binutils Also install readelf into tooldir/bin directory 2015-08-28 08:34:44 -07:00
config Missing parts of fixes for in-tree libiconv 2015-08-24 10:57:03 +01:00
cpu
elfcpp
etc
gas More fallout from "Allow symbol and label names to be enclosed in double quotes" 2015-08-27 23:19:59 +09:30
gdb Improve error reporting when handling SystemTap SDT probes 2015-09-02 00:11:30 -04:00
gold Fix problem where script specified both address and region for a section. 2015-08-26 00:03:04 -07:00
gprof Remove trailing spaces in gprof 2015-08-12 04:43:32 -07:00
include Reorder enum output_type for better code generation 2015-08-23 23:21:48 +09:30
intl Regen intl/configure 2015-08-31 12:53:36 +09:30
ld Skip PLT for function pointer initialization 2015-09-01 05:06:33 -07:00
libdecnumber
libiberty PR gdb/18669 libiberty demangle.test failure: strtod() on sparc-sun-solaris2.9 2015-08-11 09:14:12 +02:00
opcodes Support for the sparc %pmcdper privileged register. 2015-08-25 17:16:34 +02:00
readline
sim Fix building GDB for the M32C by providing a stub sim_info function. 2015-08-05 14:58:21 +01:00
texinfo
zlib
.cvsignore
.gitattributes
.gitignore
ChangeLog Sync config.sub and config.guess with GCC 2015-08-07 07:51:39 -07:00
compile
config-ml.in
config.guess Sync config.sub and config.guess with GCC 2015-08-07 07:51:39 -07:00
config.rpath
config.sub Sync config.sub and config.guess with GCC 2015-08-07 07:51:39 -07:00
configure
configure.ac
COPYING
COPYING3
COPYING3.LIB
COPYING.LIB
COPYING.LIBGLOSS
COPYING.NEWLIB
depcomp
djunpack.bat
install-sh
libtool.m4
lt~obsolete.m4
ltgcc.m4
ltmain.sh
ltoptions.m4
ltsugar.m4
ltversion.m4
MAINTAINERS
Makefile.def Yaakov Selkowitz: fixes for in-tree libiconv 2015-08-06 23:55:06 -04:00
Makefile.in Yaakov Selkowitz: fixes for in-tree libiconv 2015-08-06 23:55:06 -04:00
Makefile.tpl
makefile.vms
missing
mkdep
mkinstalldirs
move-if-change
README
README-maintainer-mode
setup.com
src-release.sh
symlink-tree
ylwrap

		   README for GNU development tools

This directory contains various GNU compilers, assemblers, linkers, 
debuggers, etc., plus their support routines, definitions, and documentation.

If you are receiving this as part of a GDB release, see the file gdb/README.
If with a binutils release, see binutils/README;  if with a libg++ release,
see libg++/README, etc.  That'll give you info about this
package -- supported targets, how to use it, how to report bugs, etc.

It is now possible to automatically configure and build a variety of
tools with one command.  To build all of the tools contained herein,
run the ``configure'' script here, e.g.:

	./configure 
	make

To install them (by default in /usr/local/bin, /usr/local/lib, etc),
then do:
	make install

(If the configure script can't determine your type of computer, give it
the name as an argument, for instance ``./configure sun4''.  You can
use the script ``config.sub'' to test whether a name is recognized; if
it is, config.sub translates it to a triplet specifying CPU, vendor,
and OS.)

If you have more than one compiler on your system, it is often best to
explicitly set CC in the environment before running configure, and to
also set CC when running make.  For example (assuming sh/bash/ksh):

	CC=gcc ./configure
	make

A similar example using csh:

	setenv CC gcc
	./configure
	make

Much of the code and documentation enclosed is copyright by
the Free Software Foundation, Inc.  See the file COPYING or
COPYING.LIB in the various directories, for a description of the
GNU General Public License terms under which you can copy the files.

REPORTING BUGS: Again, see gdb/README, binutils/README, etc., for info
on where and how to report problems.