mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-30 12:44:10 +08:00
f33da99a54
This commit fixes PR breakpoints/16889, which is about a bug that triggers when GDB tries to parse probes whose arguments do not contain the initial (and optional) "N@" part. For reference sake, the de facto format is described here: <https://sourceware.org/systemtap/wiki/UserSpaceProbeImplementation> Anyway, this PR actually uncovered two bugs (related) that were happening while parsing the arguments. The first one was that the parser *was* catching *some* arguments that were missing the "N@" part, but it wasn't correctly setting the argument's type. This was causing a NULL pointer being dereferenced, ouch... The second bug uncovered was that the parser was not catching all of the cases for a probe which did not provide the "N@" part. The fix for that was to simplify the check that the code was making to identify non-prefixed probes. The code is simpler and easier to read now. I am also providing a testcase for this bug, only for x86_64 architectures. gdb/ 2014-05-02 Sergio Durigan Junior <sergiodj@redhat.com> PR breakpoints/16889 * stap-probe.c (stap_parse_probe_arguments): Simplify check for non-prefixed probes (i.e., probes whose arguments do not start with "N@"). Always set the argument type to a sane value. gdb/testsuite/ 2014-05-02 Sergio Durigan Junior <sergiodj@redhat.com> PR breakpoints/16889 * gdb.arch/amd64-stap-optional-prefix.S: New file. * gdb.arch/amd64-stap-optional-prefix.exp: Likewise.
58 lines
1.7 KiB
Plaintext
58 lines
1.7 KiB
Plaintext
# Copyright 2014 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# This testcase is for PR breakpoints/16889
|
|
|
|
standard_testfile ".S"
|
|
|
|
if { ![istarget "x86_64-*-*"] } {
|
|
verbose "Skipping $testfile.exp"
|
|
return
|
|
}
|
|
|
|
if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } {
|
|
return -1
|
|
}
|
|
|
|
# Helper procedure to go to probe NAME
|
|
|
|
proc goto_probe { name } {
|
|
global decimal hex
|
|
|
|
gdb_test "break -pstap $name" "Breakpoint $decimal at $hex"
|
|
gdb_test "continue" "Breakpoint $decimal, main \\(\\) at .*\r\n.*STAP_PROBE1.*${name},.*\\)"
|
|
}
|
|
|
|
# Helper procedure to test the probe's argument
|
|
|
|
proc test_probe_value { value reg_val } {
|
|
gdb_test "print \$_probe_argc" "= 1"
|
|
gdb_test "print \$_probe_arg0" "= $value"
|
|
gdb_test "print \$_probe_arg0 == *((unsigned int *) (${reg_val}))" "= 1"
|
|
}
|
|
|
|
if { ![runto_main] } {
|
|
return -1
|
|
}
|
|
|
|
foreach probe_name [list "foo" "bar" "foo_prefix" "bar_prefix"] \
|
|
probe_val [list "42" "42" "42" "42"] \
|
|
probe_reg_val [list "\$rsp" "\$rbp - 8" "\$rsp" "\$rbp - 8"] {
|
|
with_test_prefix $probe_name {
|
|
goto_probe $probe_name
|
|
test_probe_value $probe_val $probe_reg_val
|
|
}
|
|
}
|