binutils-gdb/gdbserver
Andrew Burgess f1f0a06d5b gdbserver: fix handling of single quote arguments
I noticed that passing arguments containing single quotes to gdbserver
didn't work correctly:

  gdb -ex 'set sysroot' --args /tmp/show-args
  Reading symbols from /tmp/show-args...
  (gdb) target extended-remote | gdbserver --once --multi - /tmp/show-args
  Remote debugging using | gdbserver --once --multi - /tmp/show-args
  stdin/stdout redirected
  Process /tmp/show-args created; pid = 176054
  Remote debugging using stdio
  Reading symbols from /lib64/ld-linux-x86-64.so.2...
  (No debugging symbols found in /lib64/ld-linux-x86-64.so.2)
  0x00007ffff7fd3110 in _start () from /lib64/ld-linux-x86-64.so.2
  (gdb) set args \'
  (gdb) r
  The program being debugged has been started already.
  Start it from the beginning? (y or n) y
  Starting program: /tmp/show-args \'
  stdin/stdout redirected
  Process /tmp/show-args created; pid = 176088
  2 args are:
    /tmp/show-args
    \'
  Done.
  [Inferior 1 (process 176088) exited normally]
  (gdb) target native
  Done.  Use the "run" command to start a process.
  (gdb) run
  Starting program: /tmp/show-args \'
  2 args are:
    /tmp/show-args
    '
  Done.
  [Inferior 1 (process 176095) exited normally]
  (gdb) q

The 'shows-args' program used here just prints the arguments passed to
the inferior.

Notice that when starting the inferior using the extended-remote
target the second argument is "\'", while when running using native
target the argument is "'".  The second of these is correct, the \'
used with the "set args" command is just to show GDB that the single
quote is not opening an argument string.

It turns out that the extra backslash is injected on the gdbserver
side when gdbserver processes the arguments that GDB passes it, the
code that does this was added as part of this much larger commit:

  commit 2090129c36
  Date:   Thu Dec 22 21:11:11 2016 -0500

      Share fork_inferior et al with gdbserver

In this commit I propose removing the specific code that adds what I
believe is a stray backslash.  I've extended an existing test to cover
this case, and I now see identical behaviour when using an
extended-remote target as with the native target.

This partially fixes PR gdb/27989, though there are still some issues
with newline handling which I'll address in a later commit.

During review I was pointed to this older series:

  https://inbox.sourceware.org/gdb-patches/20211022071933.3478427-1-m.weghorn@posteo.de/

which also includes this fix as part of a larger set of changes.  I'm
giving a Co-Authored-By credit to the author of that original series.
I believe this smaller fix brings some benefits on its own, though the
original series does offer additional improvements.  Once this is
merged I'll take a look at rebasing and resubmitting the original series.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=27989

Co-Authored-By: Michael Weghorn <m.weghorn@posteo.de>
Approved-By: Tom Tromey <tom@tromey.com>
2023-10-06 13:02:36 +01:00
..
.dir-locals.el Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
.gitattributes
.gitignore
acinclude.m4
aclocal.m4
ax-result-types.def gdbserver: handle all eval_result_type values in tracepoint.cc 2023-07-10 14:42:54 +01:00
ax.cc [gdb] Fix typos 2023-06-03 22:43:57 +02:00
ax.h gdbserver: handle all eval_result_type values in tracepoint.cc 2023-07-10 14:42:54 +01:00
ChangeLog-2002-2021
config.in gdbsupport: move libxxhash configure check to gdbsupport 2023-01-05 14:38:51 -05:00
configure Set _WIN32_WINNT in common.m4 configure check 2023-01-11 11:00:42 -07:00
configure.ac Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
configure.srv sme: Enable SME registers and pseudo-registers 2023-10-04 16:23:39 +01:00
debug.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
debug.h Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
dll.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
dll.h Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
fork-child.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
gdb_proc_service.h Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
gdbreplay.cc Update copyright year in help message of gdb, gdbserver, gdbreplay 2023-01-01 17:01:15 +04:00
gdbthread.h Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
hostio.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
hostio.h Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
i387-fp.cc gdbserver: i387_cache_to_xsave: fix copy dest of zmm registers 2023-09-01 22:13:01 -04:00
i387-fp.h gdbserver: Add a function to set the XSAVE mask and size. 2023-08-28 14:18:19 -07:00
inferiors.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
inferiors.h [gdb] Fix typos 2023-06-03 22:43:57 +02:00
linux-aarch32-low.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-aarch32-low.h Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-aarch32-tdesc.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-aarch32-tdesc.h Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-aarch64-ipa.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-aarch64-low.cc sme2: Enable SME2 support in gdbserver 2023-10-04 16:23:40 +01:00
linux-aarch64-tdesc.cc sme: Add support for SME 2023-10-04 16:23:40 +01:00
linux-aarch64-tdesc.h Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-amd64-ipa.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-arc-low.cc [gdb] Fix typos 2023-06-03 22:43:57 +02:00
linux-arm-low.cc gdbserver: Add PID parameter to linux_get_auxv and linux_get_hwcap 2023-02-01 20:42:50 +00:00
linux-arm-tdesc.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-arm-tdesc.h Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-csky-low.cc [gdb] Fix typos 2023-06-03 22:43:57 +02:00
linux-i386-ipa.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-ia64-low.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-loongarch-low.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-low.cc gdbserver, linux-low: add a couple of nullptr assertions. 2023-08-30 06:32:05 +00:00
linux-low.h Remove explanatory comments from includes 2023-09-20 11:45:16 -06:00
linux-m68k-low.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-mips-low.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-nios2-low.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-or1k-low.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-ppc-ipa.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-ppc-low.cc [gdb] Fix typos 2023-06-03 22:43:57 +02:00
linux-ppc-tdesc-init.h Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-riscv-low.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-s390-ipa.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-s390-low.cc gdbserver: Add PID parameter to linux_get_auxv and linux_get_hwcap 2023-02-01 20:42:50 +00:00
linux-s390-tdesc.h Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-sh-low.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-sparc-low.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-tic6x-low.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-x86-low.cc gdbserver: Add a function to set the XSAVE mask and size. 2023-08-28 14:18:19 -07:00
linux-x86-tdesc.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-x86-tdesc.h Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
linux-xtensa-low.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
Makefile.in refactor: Rename SVE-specific files 2023-10-04 16:23:39 +01:00
mem-break.cc [gdb] Fix typos 2023-06-03 22:43:57 +02:00
mem-break.h Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
netbsd-aarch64-low.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
netbsd-amd64-low.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
netbsd-i386-low.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
netbsd-low.cc gdbserver: Add PID parameter to linux_get_auxv and linux_get_hwcap 2023-02-01 20:42:50 +00:00
netbsd-low.h gdbserver: Add PID parameter to linux_get_auxv and linux_get_hwcap 2023-02-01 20:42:50 +00:00
notif.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
notif.h Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
proc-service.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
proc-service.list Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
README
regcache.cc gdbserver: Add assert in find_register_by_number 2023-02-01 19:48:07 +00:00
regcache.h Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
remote-utils.cc Convert tdesc's expedite_regs to a string vector 2023-10-04 16:23:39 +01:00
remote-utils.h Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
server.cc gdbserver: fix handling of single quote arguments 2023-10-06 13:02:36 +01:00
server.h sme: Add support for SME 2023-10-04 16:23:40 +01:00
symbol.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
target.cc Don't use struct buffer in handle_qxfer_btrace 2023-02-24 11:52:48 -07:00
target.h Remove explanatory comments from includes 2023-09-20 11:45:16 -06:00
tdesc.cc Convert tdesc's expedite_regs to a string vector 2023-10-04 16:23:39 +01:00
tdesc.h Convert tdesc's expedite_regs to a string vector 2023-10-04 16:23:39 +01:00
thread-db.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
tracepoint.cc gdbserver: handle all eval_result_type values in tracepoint.cc 2023-07-10 14:42:54 +01:00
tracepoint.h gdbserver: allows agent_mem_read to return an error code 2023-04-03 14:46:32 +01:00
utils.cc Move implementation of perror_with_name to gdbsupport 2023-02-10 21:04:45 -05:00
utils.h Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
win32-i386-low.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
win32-low.cc [gdb] Fix typos 2023-06-03 22:43:57 +02:00
win32-low.h Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
x86-low.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
x86-low.h Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
x86-tdesc.h Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00
xtensa-xtregs.cc Update copyright year range in header of all files managed by GDB 2023-01-01 17:01:16 +04:00

		   README for GDBserver & GDBreplay
		    by Stu Grossman and Fred Fish

Introduction:

This is GDBserver, a remote server for Un*x-like systems.  It can be used to
control the execution of a program on a target system from a GDB on a different
host.  GDB and GDBserver communicate using the standard remote serial protocol.
They communicate via either a serial line or a TCP connection.

For more information about GDBserver, see the GDB manual:

    https://sourceware.org/gdb/current/onlinedocs/gdb/Remote-Protocol.html

Usage (server (target) side):

First, you need to have a copy of the program you want to debug put onto
the target system.  The program can be stripped to save space if needed, as
GDBserver doesn't care about symbols.  All symbol handling is taken care of by
the GDB running on the host system.

To use the server, you log on to the target system, and run the `gdbserver'
program.  You must tell it (a) how to communicate with GDB, (b) the name of
your program, and (c) its arguments.  The general syntax is:

	target> gdbserver COMM PROGRAM [ARGS ...]

For example, using a serial port, you might say:

	target> gdbserver /dev/com1 emacs foo.txt

This tells GDBserver to debug emacs with an argument of foo.txt, and to
communicate with GDB via /dev/com1.  GDBserver now waits patiently for the
host GDB to communicate with it.

To use a TCP connection, you could say:

	target> gdbserver host:2345 emacs foo.txt

This says pretty much the same thing as the last example, except that we are
going to communicate with the host GDB via TCP.  The `host:2345' argument means
that we are expecting to see a TCP connection to local TCP port 2345.
(Currently, the `host' part is ignored.)  You can choose any number you want for
the port number as long as it does not conflict with any existing TCP ports on
the target system.  This same port number must be used in the host GDB's
`target remote' command, which will be described shortly. Note that if you chose
a port number that conflicts with another service, GDBserver will print an error
message and exit.

On some targets, GDBserver can also attach to running programs.  This is
accomplished via the --attach argument.  The syntax is:

	target> gdbserver --attach COMM PID

PID is the process ID of a currently running process.  It isn't necessary
to point GDBserver at a binary for the running process.

Usage (host side):

You need an unstripped copy of the target program on your host system, since
GDB needs to examine it's symbol tables and such.  Start up GDB as you normally
would, with the target program as the first argument.  (You may need to use the
--baud option if the serial line is running at anything except 9600 baud.)
Ie: `gdb TARGET-PROG', or `gdb --baud BAUD TARGET-PROG'.  After that, the only
new command you need to know about is `target remote'.  It's argument is either
a device name (usually a serial device, like `/dev/ttyb'), or a HOST:PORT
descriptor.  For example:

	(gdb) target remote /dev/ttyb

communicates with the server via serial line /dev/ttyb, and:

	(gdb) target remote the-target:2345

communicates via a TCP connection to port 2345 on host `the-target', where
you previously started up GDBserver with the same port number.  Note that for
TCP connections, you must start up GDBserver prior to using the `target remote'
command, otherwise you may get an error that looks something like
`Connection refused'.

Building GDBserver:

See the `configure.srv` file for the list of host triplets you can build
GDBserver for.

Building GDBserver for your host is very straightforward.  If you build
GDB natively on a host which GDBserver supports, it will be built
automatically when you build GDB.  You can also build just GDBserver:

	% mkdir obj
	% cd obj
	% path-to-toplevel-sources/configure --disable-gdb
	% make all-gdbserver

(If you have a combined binutils+gdb tree, you may want to also
disable other directories when configuring, e.g., binutils, gas, gold,
gprof, and ld.)

If you prefer to cross-compile to your target, then you can also build
GDBserver that way.  For example:

	% export CC=your-cross-compiler
	% path-to-topevel-sources/configure --disable-gdb
	% make all-gdbserver

Using GDBreplay:

A special hacked down version of GDBserver can be used to replay remote
debug log files created by GDB.  Before using the GDB "target" command to
initiate a remote debug session, use "set remotelogfile <filename>" to tell
GDB that you want to make a recording of the serial or tcp session.  Note
that when replaying the session, GDB communicates with GDBreplay via tcp,
regardless of whether the original session was via a serial link or tcp.

Once you are done with the remote debug session, start GDBreplay and
tell it the name of the log file and the host and port number that GDB
should connect to (typically the same as the host running GDB):

	$ gdbreplay logfile host:port

Then start GDB (preferably in a different screen or window) and use the
"target" command to connect to GDBreplay:

	(gdb) target remote host:port

Repeat the same sequence of user commands to GDB that you gave in the
original debug session.  GDB should not be able to tell that it is talking
to GDBreplay rather than a real target, all other things being equal.  Note
that GDBreplay echos the command lines to stderr, as well as the contents of
the packets it sends and receives.  The last command echoed by GDBreplay is
the next command that needs to be typed to GDB to continue the session in
sync with the original session.