mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
cce0ae568c
The previous patch to add -prompt/-lbl to gdb_test introduced a regression: Before, you could specify an explicit empty message to indicate you didn't want to PASS, like so: gdb_test COMMAND PATTERN "" After said patch, gdb_test no longer distinguishes no-message-specified vs empty-message, so tests that previously would be silent on PASS, now started emitting PASS messages based on COMMAND. This in turn introduced a number of PATH/DUPLICATE violations in the testsuite. This commit fixes all the regressions I could see. This patch uses the new -nopass feature introduced in the previous commit, but tries to avoid it if possible. Most of the patch fixes DUPLICATE issues the usual way, of using with_test_prefix or explicit unique messages. See previous commit's log for more info. In addition to looking for DUPLICATEs, I also looked for cases where we would now end up with an empty message in gdb.sum, due to a gdb_test being passed both no message and empty command. E.g., this in gdb.ada/bp_reset.exp: gdb_run_cmd gdb_test "" "Breakpoint $decimal, foo\\.nested_sub \\(\\).*" was resulting in this in gdb.sum: PASS: gdb.ada/bp_reset.exp: I fixed such cases by passing an explicit message. We may want to make such cases error out. Tested on x86_64 GNU/Linux, native and native-extended-gdbserver. I see zero PATH cases now. I get zero DUPLICATEs with native testing now. I still see some DUPLICATEs with native-extended-gdbserver, but those were preexisting, unrelated to the gdb_test change. Change-Id: I5375f23f073493e0672190a0ec2e847938a580b2
135 lines
4.3 KiB
Plaintext
135 lines
4.3 KiB
Plaintext
# Copyright 1998-2022 Free Software Foundation, Inc.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# This file was written by Michael Snyder (msnyder@cygnus.com)
|
|
|
|
load_lib "trace-support.exp"
|
|
|
|
|
|
gdb_exit
|
|
gdb_start
|
|
|
|
standard_testfile actions.c
|
|
|
|
if ![gdb_trace_common_supports_arch] {
|
|
unsupported "no trace-common.h support for arch"
|
|
return -1
|
|
}
|
|
|
|
if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
|
|
executable {debug nowarnings}] != "" } {
|
|
untested "failed to compile"
|
|
return -1
|
|
}
|
|
gdb_reinitialize_dir $srcdir/$subdir
|
|
|
|
# If testing on a remote host, download the source file.
|
|
# remote_download host $srcdir/$subdir/$srcfile
|
|
|
|
gdb_file_cmd $binfile
|
|
|
|
#
|
|
# test "info tracepoints" command
|
|
#
|
|
|
|
gdb_delete_tracepoints
|
|
set c_test_num [gdb_gettpnum gdb_c_test]
|
|
set asm_test_num [gdb_gettpnum gdb_asm_test]
|
|
if { $c_test_num <= 0 || $asm_test_num <= 0 } then {
|
|
fail "setting tracepoints"
|
|
return
|
|
}
|
|
|
|
# 2.1 info tracepoints (all)
|
|
gdb_test "info tracepoints" \
|
|
"Num Type\[ \]+Disp Enb Address\[ \]+What.*
|
|
\[0-9\]+\[\t \]+tracepoint keep y.* in gdb_c_test at .*$srcfile:\[0-9\]+.
|
|
\[\t \]+not installed on target.
|
|
\[0-9\]+\[\t \]+tracepoint keep y.* in gdb_asm_test at .*$srcfile:\[0-9\]+.
|
|
\[\t \]+not installed on target." \
|
|
"2.1: info tracepoints (all)"
|
|
|
|
# 2.2 info tracepoint (specific)
|
|
gdb_test "info tracepoint $c_test_num" \
|
|
"Num Type\[ \]+Disp Enb Address\[ \]+What.*
|
|
\[0-9\]+\[\t \]+tracepoint keep y.* in gdb_c_test at .*$srcfile:\[0-9\]+.
|
|
\[\t \]+not installed on target." \
|
|
"2.2a: info tracepoint $c_test_num (gdb_c_test)"
|
|
|
|
gdb_test "info tracepoint $asm_test_num" \
|
|
"Num Type\[ \]+Disp Enb Address\[ \]+What.*
|
|
\[0-9\]+\[\t \]+tracepoint keep y.* in gdb_asm_test at .*$srcfile:\[0-9\]+.
|
|
\[\t \]+not installed on target." \
|
|
"2.2b: info tracepoint $asm_test_num (gdb_asm_test)"
|
|
|
|
# 2.3 info tracepoint (invalid tracepoint number)
|
|
gdb_test "info tracepoint [expr $c_test_num + $asm_test_num]" \
|
|
"No tracepoint matching '[expr $c_test_num + $asm_test_num]'." \
|
|
"2.3: info tracepoint (invalid tracepoint number)"
|
|
|
|
# 2.4 info tracepoints (list of numbers)
|
|
gdb_test_multiple "info tracepoints $c_test_num $asm_test_num " \
|
|
"2.4: info trace rejects multiple tracepoint numbers" {
|
|
-re "Num Enb .*$gdb_prompt $" {
|
|
fail "2.4: info trace rejects multiple tracepoint numbers"
|
|
}
|
|
-re ".*$gdb_prompt $" {
|
|
pass "2.4: info trace rejects multiple tracepoint numbers"
|
|
}
|
|
}
|
|
|
|
# 2.5 help info trace
|
|
gdb_test "help info tracepoints" \
|
|
"Status of specified tracepoints .all tracepoints if no argument.*" \
|
|
"2.5: help info tracepoints"
|
|
|
|
# 2.6 info tracepoints (check trace buffer usage). We need a live
|
|
# tracing.
|
|
|
|
# Load the binary to the target too.
|
|
gdb_load $binfile
|
|
|
|
# Can't use runto_main here, because that would delete the tracepoints
|
|
# created above.
|
|
gdb_breakpoint "main"
|
|
gdb_trace_setactions "collect on tracepoint 1" "1" \
|
|
"collect gdb_struct1_test" "^$"
|
|
gdb_run_cmd
|
|
if {[gdb_test "" "Breakpoint ${decimal}, main.*" "run to main"] != 0} {
|
|
return -1
|
|
}
|
|
|
|
if { ![gdb_target_supports_trace] } then {
|
|
unsupported "current target does not support trace"
|
|
return 1
|
|
}
|
|
|
|
gdb_breakpoint "end" qualified
|
|
gdb_test_no_output "tstart"
|
|
gdb_test "continue" "Continuing\\.\[ \r\n\]+Breakpoint.*" \
|
|
"continue to end"
|
|
gdb_test_no_output "tstop"
|
|
gdb_test "tstatus"
|
|
gdb_test "info tracepoints" \
|
|
"Num Type\[ \]+Disp Enb Address\[ \]+What.*
|
|
\[0-9\]+\[\t \]+tracepoint keep y.* in gdb_c_test at .*$srcfile:\[0-9\]+.
|
|
\[\t \]+tracepoint already hit 1 time.
|
|
\[\t \]+trace buffer usage ${decimal} bytes.
|
|
\[\t \]+collect gdb_struct1_test.
|
|
\tinstalled on target.
|
|
\[0-9\]+\[\t \]+tracepoint keep y.* in gdb_asm_test at .*$srcfile:\[0-9\]+.
|
|
\tinstalled on target." \
|
|
"2.6: info tracepoints (trace buffer usage)"
|