binutils-gdb/ld
Nelson Chu ef9d256562 RISC-V: PR27566, Do not relax when data segment phase is exp_seg_relro_adjust.
2021-05-31  Nelson Chu  <nelson.chu@sifive.com>
            Lifang Xia  <lifang_xia@c-sky.com>

The data segment phase exp_seg_relro_adjust means we are still adjusting the
relro segments, so we will get the symbol values which havn't consider the
relro.  It is dangerous and we shouldn't do the relaxations at this stage.
Otherwise, we may get the truncated fails when the relax range crossing the
data segment.

One of the solution is that, we use a pointer to monitor the data segment
phase while relaxing, to know whether the relro has been handled or not.
Once we check the phase is exp_seg_relro_adjust, we should skip this round
of relaxations, since the incorrect symbol values will affect the correctness
of relaxations.  I think we probably need to record more information about
data segment or alignments in the future, to make sure it is safe to doing
relaxations.

For the two new testcases, relro-relax-lui and relro-relax-pcrel, we get
the following truncated errors when using toolchains, which enable relro:

(.text+0x0): relocation truncated to fit: R_RISCV_GPREL_I against symbol `SymbolRodata' defined in .rodata section in test1.o

After applying this patch, the truncated errors should be resolved.
However, only linux toolchains support -z relro, so we only test these
two testcases when supporting shared library.

bfd/
    PR 27566
    * elfnn-riscv.c (struct riscv_elf_link_hash_table): New integer pointer
    to monitor the data segment phase.
    (bfd_elfNN_riscv_set_data_segment_info): New function called by
    after_allocation, to set the data_segment_phase from expld.dataseg.
    (_bfd_riscv_relax_section): Don't relax when data_segment_phase is
    exp_seg_relro_adjust (0x4).
    * elfxx-riscv.h (bfd_elf32_riscv_set_data_segment_info): New extern.
    (bfd_elf64_riscv_set_data_segment_info): Likewise.
ld/
    PR 27566
    * emultempl/riscvelf.em (after_allocation): Call
    riscv_set_data_segment_info to set data segment phase before relaxing.
    * testsuite/ld-riscv-elf/ld-riscv-elf.exp: Updated.
    * testsuite/ld-riscv-elf/relro-relax-lui.d: New testcase.
    * testsuite/ld-riscv-elf/relro-relax-lui.s: Likewise.
    * testsuite/ld-riscv-elf/relro-relax-pcrel.d: Likewise.
    * testsuite/ld-riscv-elf/relro-relax-pcrel.s: Likewise.
2021-05-31 11:29:26 +08:00
..
emulparams Use bool in ld 2021-03-31 10:49:23 +10:30
emultempl RISC-V: PR27566, Do not relax when data segment phase is exp_seg_relro_adjust. 2021-05-31 11:29:26 +08:00
po
scripttempl PRU: Add alignment for resource table, and allow sizes of memory regions to be set from the command line. 2021-05-10 13:58:17 +01:00
testsuite RISC-V: PR27566, Do not relax when data segment phase is exp_seg_relro_adjust. 2021-05-31 11:29:26 +08:00
.gitignore
aclocal.m4
ChangeLog RISC-V: PR27566, Do not relax when data segment phase is exp_seg_relro_adjust. 2021-05-31 11:29:26 +08:00
ChangeLog-0001
ChangeLog-0203
ChangeLog-2004
ChangeLog-2005
ChangeLog-2006
ChangeLog-2007
ChangeLog-2008
ChangeLog-2009
ChangeLog-2010
ChangeLog-2011
ChangeLog-2012
ChangeLog-2013
ChangeLog-2014
ChangeLog-2015
ChangeLog-2016
ChangeLog-2017
ChangeLog-2018
ChangeLog-2019
ChangeLog-2020
ChangeLog-9197
ChangeLog-9899
config.in ENABLE_CHECKING in bfd, opcodes, binutils, ld 2021-04-13 00:35:44 +09:30
configure ENABLE_CHECKING in bfd, opcodes, binutils, ld 2021-04-13 00:35:44 +09:30
configure.ac ENABLE_CHECKING in bfd, opcodes, binutils, ld 2021-04-13 00:35:44 +09:30
configure.host
configure.tgt
deffile.h
deffilep.y
dep-in.sed
elf-hints-local.h Remove bfd_stdint.h 2021-03-31 10:49:23 +10:30
fdl.texi
gen-doc.texi
genscrba.sh
genscripts.sh
h8-doc.texi
ld.h C99 ld configury 2021-04-05 15:31:53 +09:30
ld.texi ld: Add -Bno-symbolic 2021-05-13 12:53:49 +09:30
ldbuildid.c Remove strneq macro and use startswith. 2021-04-01 15:00:56 +02:00
ldbuildid.h Use bool in ld 2021-03-31 10:49:23 +10:30
ldcref.c Use bool in ld 2021-03-31 10:49:23 +10:30
ldctor.c Use bool in ld 2021-03-31 10:49:23 +10:30
ldctor.h Use bool in ld 2021-03-31 10:49:23 +10:30
ldelf.c convert elf_link_hash macros to inline functions 2021-04-12 21:19:02 +09:30
ldelf.h Use bool in ld 2021-03-31 10:49:23 +10:30
ldelfgen.c When computing section link order for a relocateable link, ignore section sizes. 2021-05-07 10:57:47 +01:00
ldelfgen.h Use bool in ld 2021-03-31 10:49:23 +10:30
ldemul.c Use bool in ld 2021-03-31 10:49:23 +10:30
ldemul.h Use bool in ld 2021-03-31 10:49:23 +10:30
ldexp.c multiple definition warnings from script symbols 2021-05-07 16:25:40 +09:30
ldexp.h Use bool in ld 2021-03-31 10:49:23 +10:30
ldfile.c Use bool in ld 2021-03-31 10:49:23 +10:30
ldfile.h Use bool in ld 2021-03-31 10:49:23 +10:30
ldgram.y Use bool in ld 2021-03-31 10:49:23 +10:30
ldint.texi
ldlang.c PR27719, lang_mark_undefineds trashes memory 2021-04-12 11:57:03 +09:30
ldlang.h Use bool in ld 2021-03-31 10:49:23 +10:30
ldlex-wrapper.c
ldlex.h ld: Add -Bno-symbolic 2021-05-13 12:53:49 +09:30
ldlex.l
ldmain.c multiple definition warnings from script symbols 2021-05-07 16:25:40 +09:30
ldmain.h Use bool in ld 2021-03-31 10:49:23 +10:30
ldmisc.c Use bool in ld 2021-03-31 10:49:23 +10:30
ldmisc.h Use bool in ld 2021-03-31 10:49:23 +10:30
ldver.c
ldver.h
ldwrite.c Use bool in ld 2021-03-31 10:49:23 +10:30
ldwrite.h
lexsup.c ld: Add -Bno-symbolic 2021-05-13 12:53:49 +09:30
libdep_plugin.c PR27722, error: array subscript has type char 2021-04-13 16:14:20 +09:30
MAINTAINERS
Makefile.am Prevent libdel.dll.a from being installed on Windows based systems. 2021-05-11 11:06:53 +01:00
Makefile.in Prevent libdel.dll.a from being installed on Windows based systems. 2021-05-11 11:06:53 +01:00
mri.c Use bool in ld 2021-03-31 10:49:23 +10:30
mri.h
NEWS ld: Add -Bno-symbolic 2021-05-13 12:53:49 +09:30
pe-dll.c ld: warn about PE base relocations to sections above .reloc 2021-04-06 10:54:57 +02:00
pe-dll.h Use bool in ld 2021-03-31 10:49:23 +10:30
pep-dll.c
pep-dll.h Use bool in ld 2021-03-31 10:49:23 +10:30
plugin.c PR27719, lang_mark_undefineds trashes memory 2021-04-12 11:57:03 +09:30
plugin.h Use bool in ld 2021-03-31 10:49:23 +10:30
README
stamp-h.in
sysdep.h C99 ld configury 2021-04-05 15:31:53 +09:30
testplug2.c Use bool in ld 2021-03-31 10:49:23 +10:30
testplug3.c Use bool in ld 2021-03-31 10:49:23 +10:30
testplug4.c Use bool in ld 2021-03-31 10:49:23 +10:30
testplug.c Use bool in ld 2021-03-31 10:49:23 +10:30
TODO

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

		README for LD

This is the GNU linker.  It is distributed with other "binary
utilities" which should be in ../binutils.  See ../binutils/README for
more general notes, including where to send bug reports.

There are many features of the linker:

* The linker uses a Binary File Descriptor library (../bfd)
  that it uses to read and write object files.  This helps
  insulate the linker itself from the format of object files.

* The linker supports a number of different object file
  formats.  It can even handle multiple formats at once:
  Read two input formats and write a third.

* The linker can be configured for cross-linking.

* The linker supports a control language.

* There is a user manual (ld.texi), as well as the
  beginnings of an internals manual (ldint.texi).

Installation
============

See ../binutils/README.

If you want to make a cross-linker, you may want to specify
a different search path of -lfoo libraries than the default.
You can do this by setting the LIB_PATH variable in ./Makefile
or using the --with-lib-path configure switch.

To build just the linker, make the target all-ld from the top level
directory (one directory above this one).

Porting to a new target
=======================

See the ldint.texi manual.

Reporting bugs etc
===========================

See ../binutils/README.

Known problems
==============

The Solaris linker normally exports all dynamic symbols from an
executable.  The GNU linker does not do this by default.  This is
because the GNU linker tries to present the same interface for all
similar targets (in this case, all native ELF targets).  This does not
matter for normal programs, but it can make a difference for programs
which try to dlopen an executable, such as PERL or Tcl.  You can make
the GNU linker export all dynamic symbols with the -E or
--export-dynamic command line option.

HP/UX 9.01 has a shell bug that causes the linker scripts to be
generated incorrectly.  The symptom of this appears to be "fatal error
- scanner input buffer overflow" error messages.  There are various
workarounds to this:
  * Build and install bash, and build with "make SHELL=bash".
  * Update to a version of HP/UX with a working shell (e.g., 9.05).
  * Replace "(. ${srcdir}/scripttempl/${SCRIPT_NAME}.sc)" in
    genscripts.sh with "sh ${srcdir}..." (no parens) and make sure the
    emulparams script used exports any shell variables it sets.

Copyright (C) 2012-2021 Free Software Foundation, Inc.

Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright
notice and this notice are preserved.