mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
db1f6cd692
PR 27614 shows that gdb-add-index fails to generate the index when its argument is a symlink. The following one liner illustrates the reported problem: $ echo 'int main(){}'|gcc -g -x c -;ln -s a.out symlink;gdb-add-index symlink gdb-add-index: No index was created for symlink gdb-add-index: [Was there no debuginfo? Was there already an index?] $ ls -l -rwxr-xr-x 1 25712 Mar 19 23:05 a.out* -rw------- 1 8277 Mar 19 23:05 a.out.gdb-index lrwxrwxrwx 1 5 Mar 19 23:05 symlink -> a.out* GDB generates the .gdb-index file with a name that matches the name of the actual program (a.out.gdb-index here), not the symlink that references it. The remaining of the script is looking for a file named after the provided argument (would be 'symlink.gdb-index' in our example). gdb/ChangeLog: PR gdb/27614 * contrib/gdb-add-index.sh: Fix when called with a symlink as an argument. gdb/testsuite/ChangeLog: PR gdb/27614 * gdb.dwarf2/gdb-add-index-symlink.exp: New test.
188 lines
4.5 KiB
Bash
Executable File
188 lines
4.5 KiB
Bash
Executable File
#! /bin/sh
|
|
|
|
# Add a .gdb_index section to a file.
|
|
|
|
# Copyright (C) 2010-2021 Free Software Foundation, Inc.
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# This program assumes gdb and objcopy are in $PATH.
|
|
# If not, or you want others, pass the following in the environment
|
|
GDB=${GDB:=gdb}
|
|
OBJCOPY=${OBJCOPY:=objcopy}
|
|
READELF=${READELF:=readelf}
|
|
|
|
myname="${0##*/}"
|
|
|
|
dwarf5=""
|
|
if [ "$1" = "-dwarf-5" ]; then
|
|
dwarf5="$1"
|
|
shift
|
|
fi
|
|
|
|
if test $# != 1; then
|
|
echo "usage: $myname [-dwarf-5] FILE" 1>&2
|
|
exit 1
|
|
fi
|
|
|
|
file="$1"
|
|
|
|
if test -L "$file"; then
|
|
if ! command -v readlink >/dev/null 2>&1; then
|
|
echo "$myname: 'readlink' missing. Failed to follow symlink $1." 1>&2
|
|
exit 1
|
|
fi
|
|
|
|
# Count number of links followed in order to detect loops.
|
|
count=0
|
|
while test -L "$file"; do
|
|
target=$(readlink "$file")
|
|
|
|
case "$target" in
|
|
/*)
|
|
file="$target"
|
|
;;
|
|
*)
|
|
file="$(dirname "$file")/$target"
|
|
;;
|
|
esac
|
|
|
|
count="$((count + 1))"
|
|
if test "$count" -gt 10; then
|
|
echo "$myname: Detected loop while following link $file"
|
|
exit 1
|
|
fi
|
|
done
|
|
fi
|
|
|
|
if test ! -r "$file"; then
|
|
echo "$myname: unable to access: $file" 1>&2
|
|
exit 1
|
|
fi
|
|
|
|
dir="${file%/*}"
|
|
test "$dir" = "$file" && dir="."
|
|
|
|
dwz_file=""
|
|
if $READELF -S "$file" | grep -q " \.gnu_debugaltlink "; then
|
|
dwz_file=$($READELF --string-dump=.gnu_debugaltlink "$file" \
|
|
| grep -A1 "'\.gnu_debugaltlink':" \
|
|
| tail -n +2 \
|
|
| sed 's/.*]//')
|
|
dwz_file=$(echo $dwz_file)
|
|
if $READELF -S "$dwz_file" | grep -E -q " \.(gdb_index|debug_names) "; then
|
|
# Already has an index, skip it.
|
|
dwz_file=""
|
|
fi
|
|
fi
|
|
|
|
set_files ()
|
|
{
|
|
fpath="$1"
|
|
|
|
index4="${fpath}.gdb-index"
|
|
index5="${fpath}.debug_names"
|
|
debugstr="${fpath}.debug_str"
|
|
debugstrmerge="${fpath}.debug_str.merge"
|
|
debugstrerr="${fpath}.debug_str.err"
|
|
}
|
|
|
|
tmp_files=
|
|
for f in "$file" "$dwz_file"; do
|
|
if [ "$f" = "" ]; then
|
|
continue
|
|
fi
|
|
set_files "$f"
|
|
tmp_files="$tmp_files $index4 $index5 $debugstr $debugstrmerge $debugstrerr"
|
|
done
|
|
|
|
rm -f $tmp_files
|
|
|
|
# Ensure intermediate index file is removed when we exit.
|
|
trap "rm -f $tmp_files" 0
|
|
|
|
$GDB --batch -nx -iex 'set auto-load no' \
|
|
-ex "file $file" -ex "save gdb-index $dwarf5 $dir" || {
|
|
# Just in case.
|
|
status=$?
|
|
echo "$myname: gdb error generating index for $file" 1>&2
|
|
exit $status
|
|
}
|
|
|
|
# In some situations gdb can exit without creating an index. This is
|
|
# not an error.
|
|
# E.g., if $file is stripped. This behaviour is akin to stripping an
|
|
# already stripped binary, it's a no-op.
|
|
status=0
|
|
|
|
handle_file ()
|
|
{
|
|
fpath="$1"
|
|
|
|
set_files "$fpath"
|
|
|
|
if test -f "$index4" -a -f "$index5"; then
|
|
echo "$myname: Both index types were created for $fpath" 1>&2
|
|
status=1
|
|
elif test -f "$index4" -o -f "$index5"; then
|
|
if test -f "$index4"; then
|
|
index="$index4"
|
|
section=".gdb_index"
|
|
else
|
|
index="$index5"
|
|
section=".debug_names"
|
|
fi
|
|
debugstradd=false
|
|
debugstrupdate=false
|
|
if test -s "$debugstr"; then
|
|
if ! $OBJCOPY --dump-section .debug_str="$debugstrmerge" "$fpath" \
|
|
/dev/null 2>$debugstrerr; then
|
|
cat >&2 $debugstrerr
|
|
exit 1
|
|
fi
|
|
if grep -q "can't dump section '.debug_str' - it does not exist" \
|
|
$debugstrerr; then
|
|
debugstradd=true
|
|
else
|
|
debugstrupdate=true
|
|
cat >&2 $debugstrerr
|
|
fi
|
|
cat "$debugstr" >>"$debugstrmerge"
|
|
fi
|
|
|
|
$OBJCOPY --add-section $section="$index" \
|
|
--set-section-flags $section=readonly \
|
|
$(if $debugstradd; then \
|
|
echo --add-section .debug_str="$debugstrmerge"; \
|
|
echo --set-section-flags .debug_str=readonly; \
|
|
fi; \
|
|
if $debugstrupdate; then \
|
|
echo --update-section .debug_str="$debugstrmerge"; \
|
|
fi) \
|
|
"$fpath" "$fpath"
|
|
|
|
status=$?
|
|
else
|
|
echo "$myname: No index was created for $fpath" 1>&2
|
|
echo "$myname: [Was there no debuginfo? Was there already an index?]" \
|
|
1>&2
|
|
fi
|
|
}
|
|
|
|
handle_file "$file"
|
|
if [ "$dwz_file" != "" ]; then
|
|
handle_file "$dwz_file"
|
|
fi
|
|
|
|
exit $status
|