binutils-gdb/bfd
Tom Tromey eac61af65b Allow BFD to recognize macOS universal libraries
Bug #13157 is about a gdb regression, where previously it could handle
universal libraries, but now cannot.

gdb isn't working for me on macOS for other reasons, so I wrote this
small test program to show the problem:

    #include <config.h>
    #include <stdio.h>
    #include <stdlib.h>
    #include <bfd.h>

    void
    die (const char *what)
    {
      fprintf (stderr, "die: %s\n", what);
      exit (1);
    }

    int
    main (int argc, char **argv)
    {
      bfd *file = bfd_openr (argv[1], NULL);
      if (file == NULL)
	die ("couldn't open");

      if (!bfd_check_format (file, bfd_archive))
	die ("not an archive");

      printf ("yay\n");

      bfd_close (file);
      return 0;
    }

Then I built a simple universal binary.  With git master BFD, I get:

    $ ./doit ./universal-exe
    die: not an archive

Jeff Muizelaar tracked this down to the BFD change for PR binutils/21787.
This patch changed bfd_generic_archive_p to sometimes reset the BFD's
"format" field.

However, simply changing bfd_generic_archive_p regressed the test case
in that bug.

Debugging PR binutils/21787 again, what I saw is that the mach-o
universal binary support acts like a bfd_archive but does not provide
a _close_and_cleanup function.  However, if a BFD appears as an
archive member, it must always remove its own entry from its parent's
map.  Otherwise, when the parent is destroyed, the already-destroyed
child BFD will be referenced.  mach-o does not use the usual archive
member support, so simply using _bfd_archive_close_and_cleanup (as
other targets do) will not work.

This patch fixes the problem by introducing a new
_bfd_unlink_from_archive_parent function, then arranging for it to be
called in the mach-o case.

Ok?

bfd/ChangeLog
2018-07-02  Jeff Muizelaar  <jrmuizel@gmail.com>
	    Tom Tromey  <tom@tromey.com>

	PR 13157
	PR 21787
	* mach-o.c (bfd_mach_o_fat_close_and_cleanup): New function.
	(bfd_mach_o_close_and_cleanup): Redefine.
	* archive.c (_bfd_unlink_from_archive_parent): New function,
	extracted from..
	(_bfd_archive_close_and_cleanup): ..here.
	(bfd_generic_archive_p): Do not clear archive's format.
	* libbfd-in.h (_bfd_unlink_from_archive_parent): Declare.
	* libbfd.h: Regenerate.
2018-07-02 08:24:32 -06:00
..
doc Fix use of "command line X" in binutils doc 2018-07-02 11:18:24 +01:00
hosts
po Updated translations. 2018-06-26 14:03:16 +01:00
.gitignore
acinclude.m4
aclocal.m4 Bump to autoconf 2.69 and automake 1.15.1 2018-06-19 16:55:06 -04:00
aix5ppc-core.c
aix386-core.c
aout32.c
aout64.c
aout-cris.c
aout-ns32k.c
aout-target.h ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN 2018-05-21 20:39:30 -07:00
aout-tic30.c ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN 2018-05-21 20:39:30 -07:00
aoutx.h Prevent an illegal memory access in gprof by ensuring that string tables for aout format files are always zero-terminated. 2018-04-23 12:52:42 +01:00
arc-got.h
arc-plt.def
arc-plt.h
archive64.c
archive.c Allow BFD to recognize macOS universal libraries 2018-07-02 08:24:32 -06:00
archures.c [ARM] Update bfd's Tag_CPU_arch knowledge 2018-07-02 11:22:20 +01:00
bfd-in2.h [ARM] Update bfd's Tag_CPU_arch knowledge 2018-07-02 11:22:20 +01:00
bfd-in.h Use DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION to silence GCC 8.1 2018-06-04 10:01:46 -07:00
bfd.c Tidy bfdio to consistenly use containing archive 2018-06-05 22:39:12 +09:30
bfd.m4
bfdio.c PR23282, Reinstate seek optimization 2018-06-14 11:32:01 +09:30
bfdwin.c
binary.c ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN 2018-05-21 20:39:30 -07:00
cache.c Tidy bfdio to consistenly use containing archive 2018-06-05 22:39:12 +09:30
cf-i386lynx.c
ChangeLog Allow BFD to recognize macOS universal libraries 2018-07-02 08:24:32 -06:00
ChangeLog-0001
ChangeLog-0203
ChangeLog-2004
ChangeLog-2005
ChangeLog-2006
ChangeLog-2007
ChangeLog-2008
ChangeLog-2009
ChangeLog-2010
ChangeLog-2011
ChangeLog-2012
ChangeLog-2013
ChangeLog-2014
ChangeLog-2015
ChangeLog-2016
ChangeLog-2017
ChangeLog-9193
ChangeLog-9495
ChangeLog-9697
ChangeLog-9899
cisco-core.c
coff64-rs6000.c ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN 2018-05-21 20:39:30 -07:00
coff-alpha.c ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN 2018-05-21 20:39:30 -07:00
coff-arm.c
coff-bfd.c
coff-bfd.h
coff-go32.c
coff-i386.c
coff-ia64.c
coff-mcore.c
coff-mips.c ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN 2018-05-21 20:39:30 -07:00
coff-ppc.c
coff-rs6000.c ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN 2018-05-21 20:39:30 -07:00
coff-sh.c
coff-stgo32.c
coff-tic4x.c
coff-tic30.c
coff-tic54x.c
coff-tic80.c
coff-x86_64.c
coff-z8k.c
coff-z80.c
coffcode.h Tidy bfdio to consistenly use containing archive 2018-06-05 22:39:12 +09:30
coffgen.c
cofflink.c Replace uses of strncmp with memcmp 2018-05-07 12:33:26 +09:30
coffswap.h
compress.c
config.bfd 2018-05-30 Amaan Cheval <amaan.cheval@gmail.com> 2018-05-30 10:04:28 -05:00
config.in Bump to autoconf 2.69 and automake 1.15.1 2018-06-19 16:55:06 -04:00
configure Update version number on development (aka HEAD) branch. 2018-06-24 18:46:33 +01:00
configure.ac Bump to autoconf 2.69 and automake 1.15.1 2018-06-19 16:55:06 -04:00
configure.com
configure.host
COPYING
corefile.c
cpu-aarch64.c
cpu-alpha.c
cpu-arc.c
cpu-arm.c [ARM] Update bfd's Tag_CPU_arch knowledge 2018-07-02 11:22:20 +01:00
cpu-avr.c
cpu-bfin.c
cpu-cr16.c
cpu-cr16c.c
cpu-cris.c
cpu-crx.c
cpu-d10v.c
cpu-d30v.c
cpu-dlx.c
cpu-epiphany.c
cpu-fr30.c
cpu-frv.c
cpu-ft32.c
cpu-h8300.c
cpu-hppa.c
cpu-i386.c
cpu-ia64-opc.c
cpu-ia64.c
cpu-iamcu.c
cpu-ip2k.c
cpu-iq2000.c
cpu-k1om.c
cpu-l1om.c
cpu-lm32.c
cpu-m9s12x.c
cpu-m9s12xg.c
cpu-m32c.c
cpu-m32r.c
cpu-m68hc11.c
cpu-m68hc12.c
cpu-m68k.c
cpu-m10200.c
cpu-m10300.c
cpu-mcore.c
cpu-mep.c
cpu-metag.c
cpu-microblaze.c
cpu-mips.c
cpu-mmix.c
cpu-moxie.c
cpu-msp430.c
cpu-mt.c
cpu-nds32.c
cpu-nfp.c This patch adds support to objdump for disassembly of NFP (Netronome Flow Processor) ELF files (.nffw) as well as some basic readelf support. 2018-04-30 17:02:59 +01:00
cpu-nios2.c
cpu-ns32k.c
cpu-or1k.c
cpu-pdp11.c
cpu-pj.c
cpu-plugin.c
cpu-powerpc.c
cpu-pru.c
cpu-riscv.c
cpu-rl78.c
cpu-rs6000.c
cpu-rx.c
cpu-s12z.c Add support for the Freescale s12z processor. 2018-05-18 15:26:18 +01:00
cpu-s390.c
cpu-score.c
cpu-sh.c
cpu-sparc.c
cpu-spu.c
cpu-tic4x.c
cpu-tic6x.c
cpu-tic30.c
cpu-tic54x.c
cpu-tic80.c
cpu-tilegx.c
cpu-tilepro.c
cpu-v850_rh850.c
cpu-v850.c
cpu-vax.c
cpu-visium.c
cpu-wasm32.c
cpu-xc16x.c
cpu-xgate.c
cpu-xstormy16.c
cpu-xtensa.c
cpu-z8k.c
cpu-z80.c
dep-in.sed
development.sh
dwarf1.c
dwarf2.c
ecoff.c
ecofflink.c
ecoffswap.h
elf32-am33lin.c
elf32-arc.c ld: Unify STT_GNU_IFUNC handling 2018-05-28 08:15:21 -07:00
elf32-arm.c [ARM] Update bfd's Tag_CPU_arch knowledge 2018-07-02 11:22:20 +01:00
elf32-avr.c
elf32-avr.h
elf32-bfin.c
elf32-cr16.c
elf32-cr16c.c
elf32-cris.c
elf32-crx.c
elf32-d10v.c
elf32-d30v.c
elf32-dlx.c
elf32-dlx.h
elf32-epiphany.c
elf32-fr30.c
elf32-frv.c
elf32-ft32.c
elf32-gen.c
elf32-h8300.c
elf32-hppa.c PR23207, hppa ld SIGSEGVs on invalid object files 2018-05-22 19:37:06 +09:30
elf32-hppa.h
elf32-i386.c x86-64: Add TLSDESC fields to elf_x86_lazy_plt_layout 2018-05-28 10:46:16 -07:00
elf32-ip2k.c
elf32-iq2000.c
elf32-lm32.c
elf32-m32c.c
elf32-m32r.c
elf32-m68hc1x.c
elf32-m68hc1x.h
elf32-m68hc11.c
elf32-m68hc12.c
elf32-m68k.c ld: Unify STT_GNU_IFUNC handling 2018-05-28 08:15:21 -07:00
elf32-mcore.c
elf32-mep.c
elf32-metag.c
elf32-metag.h
elf32-microblaze.c
elf32-mips.c BFD: Prevent writing the MIPS _gp_disp symbol into symbol tables 2018-05-03 17:17:46 +01:00
elf32-moxie.c
elf32-msp430.c
elf32-mt.c
elf32-nds32.c NDS32/BFD: Fix build error in `nds32_convert_32_to_16' 2018-05-16 20:43:29 +01:00
elf32-nds32.h
elf32-nios2.c
elf32-nios2.h
elf32-or1k.c
elf32-pj.c
elf32-ppc.c Use DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION to silence GCC 8.1 2018-06-04 10:01:46 -07:00
elf32-ppc.h
elf32-pru.c Fix binary compatibility between GCC and the TI compiler for the PRU target. 2018-05-09 11:39:32 +01:00
elf32-rl78.c
elf32-rx.c
elf32-rx.h
elf32-s12z.c Add support for the Freescale s12z processor. 2018-05-18 15:26:18 +01:00
elf32-s390.c Use DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION to silence GCC 8.1 2018-06-04 10:01:46 -07:00
elf32-score7.c
elf32-score.c
elf32-score.h
elf32-sh-relocs.h
elf32-sh.c
elf32-sparc.c ld: Unify STT_GNU_IFUNC handling 2018-05-28 08:15:21 -07:00
elf32-spu.c
elf32-spu.h
elf32-tic6x.c TIC6X __c6xabi_DSBT_BASE 2018-06-07 09:07:32 +09:30
elf32-tic6x.h
elf32-tilegx.c
elf32-tilegx.h
elf32-tilepro.c
elf32-tilepro.h
elf32-v850.c
elf32-vax.c
elf32-visium.c
elf32-wasm32.c
elf32-xc16x.c
elf32-xgate.c
elf32-xgate.h
elf32-xstormy16.c
elf32-xtensa.c xtensa: use property tables for correct disassembly 2018-06-04 10:38:55 -07:00
elf32.c
elf64-alpha.c
elf64-gen.c
elf64-hppa.c
elf64-hppa.h
elf64-ia64-vms.c
elf64-mips.c
elf64-mmix.c
elf64-nfp.c This patch adds support to objdump for disassembly of NFP (Netronome Flow Processor) ELF files (.nffw) as well as some basic readelf support. 2018-04-30 17:02:59 +01:00
elf64-ppc.c Use DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION to silence GCC 8.1 2018-06-04 10:01:46 -07:00
elf64-ppc.h
elf64-s390.c Use DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION to silence GCC 8.1 2018-06-04 10:01:46 -07:00
elf64-sparc.c ld: Unify STT_GNU_IFUNC handling 2018-05-28 08:15:21 -07:00
elf64-tilegx.c
elf64-tilegx.h
elf64-x86-64.c x86-64: Add TLSDESC fields to elf_x86_lazy_plt_layout 2018-05-28 10:46:16 -07:00
elf64.c
elf-attrs.c Prevent a memory exhaustion failure when running objdump on a fuzzed input file with corrupt string and attribute sections. 2018-05-08 12:51:06 +01:00
elf-bfd.h ELF dynsyms 2018-06-14 11:32:01 +09:30
elf-eh-frame.c
elf-hppa.h
elf-ifunc.c x86; Allow IFUNC pointer defined in PDE 2018-05-14 03:55:50 -07:00
elf-linux-core.h -Wstringop-truncation warnings 2018-05-04 18:58:23 +09:30
elf-m10200.c
elf-m10300.c
elf-nacl.c
elf-nacl.h
elf-properties.c
elf-s390-common.c ld: Unify STT_GNU_IFUNC handling 2018-05-28 08:15:21 -07:00
elf-s390.h
elf-strtab.c
elf-vxworks.c
elf-vxworks.h
elf.c elf: Check if the first symbol version is base version 2018-06-14 05:37:33 -07:00
elfcode.h
elfcore.h
elflink.c ELF dynsyms 2018-06-14 11:32:01 +09:30
elfn32-mips.c
elfnn-aarch64.c Fix compile time warning message for the AArch64 BFD backend, about a possible attempt to call sprintf on a NULL buffer pointer. 2018-06-25 12:49:14 +01:00
elfnn-ia64.c
elfnn-riscv.c RISC-V: Fix 3 PIE related ld testsuite failures. 2018-06-21 11:45:43 -07:00
elfxx-aarch64.c [BFD][AARCH64]Properly truncate no overflow checking relocation value for load/store immediate. 2018-06-20 14:47:37 +01:00
elfxx-aarch64.h ld: Unify STT_GNU_IFUNC handling 2018-05-28 08:15:21 -07:00
elfxx-ia64.c
elfxx-ia64.h
elfxx-mips.c MIPS/BFD: Remove extraneous undefined weak symbol visibility check 2018-06-29 15:45:28 +01:00
elfxx-mips.h
elfxx-riscv.c
elfxx-riscv.h
elfxx-sparc.c
elfxx-sparc.h
elfxx-target.h ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN 2018-05-21 20:39:30 -07:00
elfxx-tilegx.c
elfxx-tilegx.h
elfxx-x86.c ld/x86: Remove hidden _edata, __bss_start, and _end 2018-06-08 12:41:54 -07:00
elfxx-x86.h x86-64: Add TLSDESC fields to elf_x86_lazy_plt_layout 2018-05-28 10:46:16 -07:00
format.c PR22458, failure to choose a matching ELF target 2018-05-16 21:42:58 +09:30
gen-aout.c
genlink.h
go32stub.h
hash.c
host-aout.c
hppabsd-core.c
hpux-core.c
i386aout.c
i386bsd.c
i386lynx.c
i386msdos.c ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN 2018-05-21 20:39:30 -07:00
ihex.c ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN 2018-05-21 20:39:30 -07:00
init.c
irix-core.c
libaout.h
libbfd-in.h Allow BFD to recognize macOS universal libraries 2018-07-02 08:24:32 -06:00
libbfd.c Add support for the Freescale s12z processor. 2018-05-18 15:26:18 +01:00
libbfd.h Allow BFD to recognize macOS universal libraries 2018-07-02 08:24:32 -06:00
libcoff-in.h libbfd.h and libcoff.h include guards 2018-05-18 13:07:21 +09:30
libcoff.h libbfd.h and libcoff.h include guards 2018-05-18 13:07:21 +09:30
libecoff.h
libhppa.h
libpei.h
libxcoff.h
linker.c ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN 2018-05-21 20:39:30 -07:00
lynx-core.c
mach-o-aarch64.c
mach-o-arm.c
mach-o-i386.c
mach-o-target.c Stop objcopy from corrupting mach-o files. 2018-06-20 10:43:00 +01:00
mach-o-x86-64.c Add support for the TLV relocation generated by LLVM for x86_64 MACH-O targets. 2018-06-18 12:56:44 +01:00
mach-o.c Allow BFD to recognize macOS universal libraries 2018-07-02 08:24:32 -06:00
mach-o.h Stop objcopy from corrupting mach-o files. 2018-06-20 10:43:00 +01:00
MAINTAINERS
Makefile.am Bump to autoconf 2.69 and automake 1.15.1 2018-06-19 16:55:06 -04:00
Makefile.in Bump to autoconf 2.69 and automake 1.15.1 2018-06-19 16:55:06 -04:00
makefile.vms
mep-relocs.pl
merge.c
mmo.c ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN 2018-05-21 20:39:30 -07:00
netbsd-core.c
netbsd.h
ns32k.h
ns32knetbsd.c
opncls.c Fix potential illegal memroy access when using a build-id note with a negative size. 2018-06-20 16:30:05 +01:00
osf-core.c
pc532-mach.c
pdp11.c
pe-arm-wince.c
pe-arm.c
pe-i386.c
pe-mcore.c
pe-ppc.c
pe-sh.c
pe-x86_64.c
pef-traceback.h
pef.c ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN 2018-05-21 20:39:30 -07:00
pef.h
pei-arm-wince.c
pei-arm.c
pei-i386.c
pei-ia64.c
pei-mcore.c
pei-ppc.c
pei-sh.c
pei-x86_64.c
peicode.h
peXXigen.c PR23148, Heap buffer overflow in pe_print_edata 2018-05-09 14:14:10 +09:30
plugin.c PR23254, ld.bfd mishandles file pointers while scanning archive 2018-06-05 22:39:11 +09:30
plugin.h
PORTING
ppcboot.c ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN 2018-05-21 20:39:30 -07:00
ptrace-core.c
README
reloc16.c
reloc.c Add support for the TLV relocation generated by LLVM for x86_64 MACH-O targets. 2018-06-18 12:56:44 +01:00
rs6000-core.c
sco5-core.c
section.c PR22458, failure to choose a matching ELF target 2018-05-16 21:42:58 +09:30
simple.c
som.c ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN 2018-05-21 20:39:30 -07:00
som.h
srec.c ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN 2018-05-21 20:39:30 -07:00
stab-syms.c
stabs.c
stamp-h.in
syms.c
sysdep.h PR23254, ld.bfd mishandles file pointers while scanning archive 2018-06-05 22:39:11 +09:30
targets.c ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN 2018-05-21 20:39:30 -07:00
targmatch.sed
tekhex.c ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN 2018-05-21 20:39:30 -07:00
TODO
trad-core.c
vax1knetbsd.c
vaxnetbsd.c
verilog.c
version.h Automatic date update in version.in 2018-07-02 00:00:53 +00:00
version.m4 Update version number on development (aka HEAD) branch. 2018-06-24 18:46:33 +01:00
vms-alpha.c ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN 2018-05-21 20:39:30 -07:00
vms-lib.c
vms-misc.c
vms.h
warning.m4
wasm-module.c
wasm-module.h
xcofflink.c
xsym.c ld: Hide symbols defined by HIDDEN/PROVIDE_HIDDEN 2018-05-21 20:39:30 -07:00
xsym.h
xtensa-isa.c
xtensa-modules.c

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

BFD is an object file library.  It permits applications to use the
same routines to process object files regardless of their format.

BFD is used by the GNU debugger, assembler, linker, and the binary
utilities.

The documentation on using BFD is scanty and may be occasionally
incorrect.  Pointers to documentation problems, or an entirely
rewritten manual, would be appreciated.

There is some BFD internals documentation in doc/bfdint.texi which may
help programmers who want to modify BFD.

BFD is normally built as part of another package.  See the build
instructions for that package, probably in a README file in the
appropriate directory.

BFD supports the following configure options:

  --target=TARGET
	The default target for which to build the library.  TARGET is
	a configuration target triplet, such as sparc-sun-solaris.
  --enable-targets=TARGET,TARGET,TARGET...
	Additional targets the library should support.  To include
	support for all known targets, use --enable-targets=all.
  --enable-64-bit-bfd
	Include support for 64 bit targets.  This is automatically
	turned on if you explicitly request a 64 bit target, but not
	for --enable-targets=all.  This requires a compiler with a 64
	bit integer type, such as gcc.
  --enable-shared
	Build BFD as a shared library.
  --with-mmap
	Use mmap when accessing files.  This is faster on some hosts,
	but slower on others.  It may not work on all hosts.

Report bugs with BFD to bug-binutils@gnu.org.

Patches are encouraged.  When sending patches, always send the output
of diff -u or diff -c from the original file to the new file.  Do not
send default diff output.  Do not make the diff from the new file to
the original file.  Remember that any patch must not break other
systems.  Remember that BFD must support cross compilation from any
host to any target, so patches which use ``#ifdef HOST'' are not
acceptable.  Please also read the ``Reporting Bugs'' section of the
gcc manual.

Bug reports without patches will be remembered, but they may never get
fixed until somebody volunteers to fix them.

Copyright (C) 2012-2018 Free Software Foundation, Inc.

Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright
notice and this notice are preserved.