mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-21 04:42:53 +08:00
a068643d69
Currently the target pid_to_str method returns a const char *, so many implementations have a static buffer that they update. This patch changes these methods to return a std::string instead. I think this is cleaner and avoids possible gotchas when calling pid_to_str on different ptids in a single statement. (Though no such calls exist currently.) This also updates various helper functions, and the gdbarch pid_to_str methods. I also made a best effort to fix all the callers, but I can't build some of the *-nat.c files. Tested by the buildbot. gdb/ChangeLog 2019-03-13 Tom Tromey <tromey@adacore.com> * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers) (i386_gnu_nat_target::store_registers): Update. * target-debug.h (target_debug_print_std_string): New macro. * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update. * windows-tdep.c (display_one_tib): Update. * tui/tui-stack.c (tui_make_status_line): Update. * top.c (print_inferior_quit_action): Update. * thread.c (thr_try_catch_cmd): Update. (add_thread_with_info): Update. (thread_target_id_str): Update. (thr_try_catch_cmd): Update. (thread_command): Update. (thread_find_command): Update. * record-btrace.c (record_btrace_target::info_record) (record_btrace_resume_thread, record_btrace_target::resume) (record_btrace_cancel_resume, record_btrace_step_thread) (record_btrace_target::wait, record_btrace_target::wait) (record_btrace_target::wait, record_btrace_target::stop): Update. * progspace.c (print_program_space): Update. * process-stratum-target.c (process_stratum_target::thread_address_space): Update. * linux-fork.c (linux_fork_mourn_inferior) (detach_checkpoint_command, info_checkpoints_command) (linux_fork_context): Update. (linux_fork_detach): Update. (class scoped_switch_fork_info): Update. (delete_checkpoint_command): Update. * infrun.c (follow_fork_inferior): Update. (follow_fork_inferior): Update. (proceed_after_vfork_done): Update. (handle_vfork_child_exec_or_exit): Update. (follow_exec): Update. (displaced_step_prepare_throw): Update. (displaced_step_restore): Update. (start_step_over): Update. (resume_1): Update. (clear_proceed_status_thread): Update. (proceed): Update. (print_target_wait_results): Update. (do_target_wait): Update. (context_switch): Update. (stop_all_threads): Update. (restart_threads): Update. (finish_step_over): Update. (handle_signal_stop): Update. (switch_back_to_stepped_thread): Update. (keep_going_pass_signal): Update. (print_exited_reason): Update. (normal_stop): Update. * inferior.c (inferior_pid_to_str): Change return type. (print_selected_inferior): Update. (add_inferior): Update. (detach_inferior): Update. * dummy-frame.c (fprint_dummy_frames): Update. * dcache.c (dcache_info_1): Update. * btrace.c (btrace_enable, btrace_disable, btrace_teardown) (btrace_fetch, btrace_clear): Update. * linux-tdep.c (linux_core_pid_to_str): Change return type. * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return type. * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type. * sol2-tdep.h (sol2_core_pid_to_str): Change return type. * sol2-tdep.c (sol2_core_pid_to_str): Change return type. * gdbarch.c, gdbarch.h: Rebuild. * gdbarch.sh (core_pid_to_str): Change return type. * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change return type. (windows_nat_target::pid_to_str): Change return type. (windows_delete_thread): Update. (windows_nat_target::attach): Update. (windows_nat_target::files_info): Update. * target-delegates.c: Rebuild. * sol-thread.c (class sol_thread_target) <pid_to_str>: Change return type. (sol_thread_target::pid_to_str): Change return type. * remote.c (class remote_target) <pid_to_str>: Change return type. (remote_target::pid_to_str): Change return type. (extended_remote_target::attach, remote_target::remote_stop_ns) (remote_target::remote_notif_remove_queued_reply) (remote_target::push_stop_reply, remote_target::disable_btrace): Update. (extended_remote_target::attach): Update. * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return type. (gdbsim_target::pid_to_str): Change return type. * ravenscar-thread.c (struct ravenscar_thread_target) <pid_to_str>: Change return type. (ravenscar_thread_target::pid_to_str): Change return type. * procfs.c (class procfs_target) <pid_to_str>: Change return type. (procfs_target::pid_to_str): Change return type. (procfs_target::attach): Update. (procfs_target::detach): Update. (procfs_target::fetch_registers): Update. (procfs_target::store_registers): Update. (procfs_target::wait): Update. (procfs_target::files_info): Update. * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type. * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change return type. (nto_procfs_target::pid_to_str): Change return type. (nto_procfs_target::files_info, nto_procfs_target::attach): Update. * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change return type. * linux-nat.c (linux_nat_target::pid_to_str): Change return type. (exit_lwp): Update. (attach_proc_task_lwp_callback, get_detach_signal) (detach_one_lwp, resume_lwp, linux_nat_target::resume) (linux_nat_target::resume, wait_lwp, stop_callback) (maybe_clear_ignore_sigint, stop_wait_callback, status_callback) (save_stop_reason, select_event_lwp, linux_nat_filter_event) (linux_nat_wait_1, resume_stopped_resumed_lwps) (linux_nat_target::wait, linux_nat_stop_lwp): Update. * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return type. (inf_ptrace_target::attach): Update. (inf_ptrace_target::files_info): Update. * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return type. (go32_nat_target::pid_to_str): Change return type. * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type. (gnu_nat_target::wait): Update. (gnu_nat_target::wait): Update. (gnu_nat_target::resume): Update. * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type. (fbsd_nat_target::wait): Update. * darwin-nat.c (darwin_nat_target::pid_to_str): Change return type. (darwin_nat_target::attach): Update. * corelow.c (class core_target) <pid_to_str>: Change return type. (core_target::pid_to_str): Change return type. * target.c (normal_pid_to_str): Change return type. (default_pid_to_str): Likewise. (target_pid_to_str): Change return type. (target_translate_tls_address): Update. (target_announce_detach): Update. * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change return type. (bsd_uthread_target::pid_to_str): Change return type. * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return type. (bsd_kvm_target::pid_to_str): Change return type. * aix-thread.c (class aix_thread_target) <pid_to_str>: Change return type. (aix_thread_target::pid_to_str): Change return type. * target.h (struct target_ops) <pid_to_str>: Change return type. (target_pid_to_str, normal_pid_to_str): Likewise. * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return type. * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return type. * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change return type. * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return type. * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return type. * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change return type.
228 lines
9.6 KiB
C++
228 lines
9.6 KiB
C++
/* GDB target debugging macros
|
||
|
||
Copyright (C) 2014-2019 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#ifndef TARGET_DEBUG_H
|
||
#define TARGET_DEBUG_H
|
||
|
||
/* Printers for the debug target. Each prints an object of a given
|
||
type to a string that needn't be freed. Most printers are macros,
|
||
for brevity, but a few are static functions where more complicated
|
||
behavior is needed.
|
||
|
||
References to these printers are automatically generated by
|
||
make-target-delegates. See the generated file target-delegates.c.
|
||
|
||
In a couple cases, a special printing function is defined and then
|
||
used via the TARGET_DEBUG_PRINTER macro. See target.h.
|
||
|
||
A few methods still have some explicit targetdebug code in
|
||
target.c. In most cases this is because target delegation hasn't
|
||
been done for the method; but individual cases vary. For instance,
|
||
target_store_registers does some special register printing that is
|
||
more simply done there, and target_xfer_partial additionally
|
||
bypasses the debug target. */
|
||
|
||
|
||
/* Helper macro. */
|
||
|
||
#define target_debug_do_print(E) \
|
||
fputs_unfiltered ((E), gdb_stdlog);
|
||
|
||
#define target_debug_print_struct_target_ops_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_enum_target_object(X) \
|
||
target_debug_do_print (plongest (X))
|
||
#define target_debug_print_CORE_ADDR(X) \
|
||
target_debug_do_print (core_addr_to_string (X))
|
||
#define target_debug_print_const_char_p(X) \
|
||
target_debug_do_print (((X) ? (X) : "(null)"))
|
||
#define target_debug_print_char_p(X) \
|
||
target_debug_do_print (((X) ? (X) : "(null)"))
|
||
#define target_debug_print_int(X) \
|
||
target_debug_do_print (plongest (X))
|
||
#define target_debug_print_bool(X) \
|
||
target_debug_do_print ((X) ? "true" : "false")
|
||
#define target_debug_print_long(X) \
|
||
target_debug_do_print (plongest (X))
|
||
#define target_debug_print_enum_target_xfer_status(X) \
|
||
target_debug_do_print (plongest (X))
|
||
#define target_debug_print_enum_exec_direction_kind(X) \
|
||
target_debug_do_print (plongest (X))
|
||
#define target_debug_print_enum_trace_find_type(X) \
|
||
target_debug_do_print (plongest (X))
|
||
#define target_debug_print_enum_btrace_read_type(X) \
|
||
target_debug_do_print (plongest (X))
|
||
#define target_debug_print_enum_btrace_error(X) \
|
||
target_debug_do_print (plongest (X))
|
||
#define target_debug_print_ptid_t(X) \
|
||
target_debug_do_print (plongest (X.pid ()))
|
||
#define target_debug_print_struct_gdbarch_p(X) \
|
||
target_debug_do_print (gdbarch_bfd_arch_info (X)->printable_name)
|
||
#define target_debug_print_const_gdb_byte_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_gdb_byte_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_gdb_byte_pp(X) \
|
||
target_debug_do_print (host_address_to_string (*(X)))
|
||
#define target_debug_print_enum_gdb_signal(X) \
|
||
target_debug_do_print (gdb_signal_to_name (X))
|
||
#define target_debug_print_ULONGEST(X) \
|
||
target_debug_do_print (hex_string (X))
|
||
#define target_debug_print_ULONGEST_p(X) \
|
||
target_debug_do_print (hex_string (*(X)))
|
||
#define target_debug_print_LONGEST(X) \
|
||
target_debug_do_print (phex (X, 0))
|
||
#define target_debug_print_LONGEST_p(X) \
|
||
target_debug_do_print (phex (*(X), 0))
|
||
#define target_debug_print_struct_address_space_p(X) \
|
||
target_debug_do_print (plongest (address_space_num (X)))
|
||
#define target_debug_print_struct_bp_target_info_p(X) \
|
||
target_debug_do_print (core_addr_to_string ((X)->placed_address))
|
||
#define target_debug_print_struct_expression_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_CORE_ADDR_p(X) \
|
||
target_debug_do_print (core_addr_to_string (*(X)))
|
||
#define target_debug_print_int_p(X) \
|
||
target_debug_do_print (plongest (*(X)))
|
||
#define target_debug_print_struct_regcache_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_struct_thread_info_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_struct_ui_file_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_struct_target_section_table_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_async_callback_ftype_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_void_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_find_memory_region_ftype(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_bfd_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_std_vector_mem_region(X) \
|
||
target_debug_do_print (host_address_to_string (X.data ()))
|
||
#define target_debug_print_std_vector_static_tracepoint_marker(X) \
|
||
target_debug_do_print (host_address_to_string (X.data ()))
|
||
#define target_debug_print_const_struct_target_desc_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_struct_bp_location_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_struct_trace_state_variable_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_const_trace_state_variable_r(X) \
|
||
target_debug_do_print (host_address_to_string (&X))
|
||
#define target_debug_print_struct_trace_status_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_struct_breakpoint_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_struct_uploaded_tp_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_struct_uploaded_tp_pp(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_struct_uploaded_tsv_pp(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_static_tracepoint_marker_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_struct_traceframe_info_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_struct_btrace_target_info_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_VEC__btrace_block_s__pp(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_const_struct_frame_unwind_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_struct_btrace_data_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_enum_btrace_format(X) \
|
||
target_debug_do_print (plongest (X))
|
||
#define target_debug_print_enum_record_method(X) \
|
||
target_debug_do_print (plongest (X))
|
||
#define target_debug_print_const_struct_btrace_config_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_const_struct_btrace_target_info_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_enum_target_hw_bp_type(X) \
|
||
target_debug_do_print (plongest (X))
|
||
#define target_debug_print_enum_bptype(X) \
|
||
target_debug_do_print (plongest (X))
|
||
#define target_debug_print_struct_inferior_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_enum_remove_bp_reason(X) \
|
||
target_debug_do_print (plongest (X))
|
||
#define target_debug_print_gdb_disassembly_flags(X) \
|
||
target_debug_do_print (plongest (X))
|
||
#define target_debug_print_traceframe_info_up(X) \
|
||
target_debug_do_print (host_address_to_string (X.get ()))
|
||
#define target_debug_print_gdb_array_view_const_int(X) \
|
||
target_debug_do_print (host_address_to_string (X.data ()))
|
||
#define target_debug_print_inferior_p(inf) \
|
||
target_debug_do_print (host_address_to_string (inf))
|
||
#define target_debug_print_record_print_flags(X) \
|
||
target_debug_do_print (plongest (X))
|
||
#define target_debug_print_enum_info_proc_what(X) \
|
||
target_debug_do_print (plongest (X))
|
||
#define target_debug_print_thread_control_capabilities(X) \
|
||
target_debug_do_print (plongest (X))
|
||
#define target_debug_print_thread_info_p(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_thread_info_pp(X) \
|
||
target_debug_do_print (host_address_to_string (X))
|
||
#define target_debug_print_std_string(X) \
|
||
target_debug_do_print ((X).c_str ())
|
||
|
||
static void
|
||
target_debug_print_struct_target_waitstatus_p (struct target_waitstatus *status)
|
||
{
|
||
std::string str = target_waitstatus_to_string (status);
|
||
|
||
fputs_unfiltered (str.c_str (), gdb_stdlog);
|
||
}
|
||
|
||
|
||
|
||
/* Macros or functions that are used via TARGET_DEBUG_PRINTER. */
|
||
|
||
#define target_debug_print_step(X) \
|
||
target_debug_do_print ((X) ? "step" : "continue")
|
||
|
||
static void
|
||
target_debug_print_options (int options)
|
||
{
|
||
std::string str = target_options_to_string (options);
|
||
|
||
fputs_unfiltered (str.c_str (), gdb_stdlog);
|
||
}
|
||
|
||
static void
|
||
target_debug_print_signals (gdb::array_view<const unsigned char> sigs)
|
||
{
|
||
fputs_unfiltered ("{", gdb_stdlog);
|
||
|
||
for (size_t i = 0; i < sigs.size (); i++)
|
||
if (sigs[i] != 0)
|
||
{
|
||
fprintf_unfiltered (gdb_stdlog, " %s",
|
||
gdb_signal_to_name ((enum gdb_signal) i));
|
||
}
|
||
fputs_unfiltered (" }", gdb_stdlog);
|
||
}
|
||
|
||
#endif /* TARGET_DEBUG_H */
|