binutils-gdb/gdb/common/gdb_unlinker.h
Pedro Alves 15c22686d0 gdb: Fix ATTRIBUTE_NONNULL usage
Should fix the build failure with Clang mentioned at
	<https://sourceware.org/bugzilla/show_bug.cgi?id=21206#c2>:

 In file included from ../../binutils-gdb/gdb/dwarf2read.c:72:
 ../../binutils-gdb/gdb/common/gdb_unlinker.h:35:35: error: '__nonnull__' attribute is invalid for the implicit this argument
   unlinker (const char *filename) ATTRIBUTE_NONNULL (1)
				   ^                  ~
 ../../binutils-gdb/gdb/../include/ansidecl.h:169:48: note: expanded from macro 'ATTRIBUTE_NONNULL'
 #  define ATTRIBUTE_NONNULL(m) __attribute__ ((__nonnull__ (m)))

gdb/ChangeLog:
2017-03-08  Pedro Alves  <palves@redhat.com>

	PR 21206
	* common/gdb_unlinker.h (unlinker::unlinker): Attribute nonnull
	goes to argument 2, not 1.
2017-03-08 15:52:16 +00:00

61 lines
1.4 KiB
C++

/* Unlinking class
Copyright (C) 2016 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#ifndef GDB_UNLINKER_H
#define GDB_UNLINKER_H
namespace gdb
{
/* An object of this class holds a filename and, when the object goes
of scope, the file is removed using unlink.
A user of this class can request that the file be preserved using
the "keep" method. */
class unlinker
{
public:
unlinker (const char *filename) ATTRIBUTE_NONNULL (2)
: m_filename (filename)
{
gdb_assert (filename != NULL);
}
~unlinker ()
{
if (m_filename != NULL)
unlink (m_filename);
}
/* Keep the file, rather than unlink it. */
void keep ()
{
m_filename = NULL;
}
private:
const char *m_filename;
};
}
#endif /* GDB_UNLINKER_H */