mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-12 12:16:04 +08:00
0c4e2c6c88
When running test-case gdb.arch/i386-mpx.exp with target board unix/-m32, we
run into:
...
(gdb) print $bndstatus^M
$3 = {raw = 0xf7ca7ff2, status = {bde = 1039310844, error = 2}}^M
(gdb) FAIL: gdb.arch/i386-mpx.exp: bndstatus formating
print $bndstatus.raw^M
$4 = (void *) 0xf7ca7ff2^M
(gdb) FAIL: gdb.arch/i386-mpx.exp: bndstatus is zero by startup
...
The failure does not occur with -m64, there we have instead:
...
(gdb) print $bndstatus^M
$3 = {raw = 0x0, status = {bde = 0, error = 0}}^M
(gdb) PASS: gdb.arch/i386-mpx.exp: bndstatus formating
print $bndstatus.raw^M
$4 = (void *) 0x0^M
(gdb) PASS: gdb.arch/i386-mpx.exp: bndstatus is zero by startup
...
The difference is as follows. At the point of issuing the print commands, we
have run to main, so in the case of -m64 we have executed:
...
00000000004004c7 <main>:
4004c7: 55 push %rbp
4004c8: 48 89 e5 mov %rsp,%rbp
4004cb: 89 7d fc mov %edi,-0x4(%rbp)
4004ce: 48 89 75 f0 mov %rsi,-0x10(%rbp)
4004d2: 66 0f 1b 45 e0 bndmov %bnd0,-0x20(%rbp)
...
and in the case of -m32:
...
08048426 <main>:
8048426: 55 push %ebp
8048427: 89 e5 mov %esp,%ebp
8048429: 83 ec 08 sub $0x8,%esp
804842c: 8d 45 0c lea 0xc(%ebp),%eax
804842f: 8b 55 0c mov 0xc(%ebp),%edx
8048432: 0f 1a 04 10 bndldx (%eax,%edx,1),%bnd0
8048436: 66 0f 1b 45 f8 bndmov %bnd0,-0x8(%ebp)
...
In both cases, the bnd instructions attempt to save the bound for pointer
argument argv to stack. However, there's no such bound set.
In the -m64 case, that means we just save some random value to stack.
In the -m32 case, that means that when executing bndldx the corresponding
entry in the Bounds Directory is invalid, and $bndstatus is updated to reflect
that.
Fix this by dropping the unnecessary argv parameter to main, similar to all
other gdb.arch/i386-mpx*.c test-cases.
Tested on x86_64-linux.
gdb/testsuite/ChangeLog:
2021-01-19 Tom de Vries <tdevries@suse.de>
* gdb.arch/i386-mpx.c (main): Drop argc/argv parameter.
60 lines
1.7 KiB
C
60 lines
1.7 KiB
C
/* Test program for MPX registers.
|
|
|
|
Copyright 2013-2021 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
int
|
|
main (void)
|
|
{
|
|
#ifdef __x86_64__
|
|
asm ("mov $10, %rax\n\t"
|
|
"mov $9, %rdx\n\t"
|
|
"bndmk (%rax,%rdx), %bnd0\n\t"
|
|
"mov $20, %rax\n\t"
|
|
"mov $9, %rdx\n\t"
|
|
"bndmk (%rax,%rdx), %bnd1\n\t"
|
|
"mov $30, %rax\n\t"
|
|
"mov $9, %rdx\n\t"
|
|
"bndmk (%rax,%rdx), %bnd2\n\t"
|
|
"mov $40, %rax\n\t"
|
|
"mov $9, %rdx\n\t"
|
|
"bndmk (%rax,%rdx), %bnd3\n\t"
|
|
"bndstx %bnd3, (%rax) \n\t"
|
|
"nop\n\t"
|
|
);
|
|
#else
|
|
asm ("mov $10, %eax\n\t"
|
|
"mov $9, %edx\n\t"
|
|
"bndmk (%eax,%edx), %bnd0\n\t"
|
|
"mov $20, %eax\n\t"
|
|
"mov $9, %edx\n\t"
|
|
"bndmk (%eax,%edx), %bnd1\n\t"
|
|
"mov $30, %eax\n\t"
|
|
"mov $9, %edx\n\t"
|
|
"bndmk (%eax,%edx), %bnd2\n\t"
|
|
"mov $40, %eax\n\t"
|
|
"mov $9, %edx\n\t"
|
|
"bndmk (%eax,%edx), %bnd3\n\t"
|
|
"bndstx %bnd3, (%eax)\n\t"
|
|
"nop\n\t"
|
|
);
|
|
#endif
|
|
asm ("nop\n\t"); /* break here. */
|
|
|
|
return 0;
|
|
}
|