binutils-gdb/gdb/xtensa-linux-tdep.c
Simon Marchi 345bd07cce gdb: fix gdbarch_tdep ODR violation
I would like to be able to use non-trivial types in gdbarch_tdep types.
This is not possible at the moment (in theory), because of the one
definition rule.

To allow it, rename all gdbarch_tdep types to <arch>_gdbarch_tdep, and
make them inherit from a gdbarch_tdep base class.  The inheritance is
necessary to be able to pass pointers to all these <arch>_gdbarch_tdep
objects to gdbarch_alloc, which takes a pointer to gdbarch_tdep.

These objects are never deleted through a base class pointer, so I
didn't include a virtual destructor.  In the future, if gdbarch objects
deletable, I could imagine that the gdbarch_tdep objects could become
owned by the gdbarch objects, and then it would become useful to have a
virtual destructor (so that the gdbarch object can delete the owned
gdbarch_tdep object).  But that's not necessary right now.

It turns out that RISC-V already has a gdbarch_tdep that is
non-default-constructible, so that provides a good motivation for this
change.

Most changes are fairly straightforward, mostly needing to add some
casts all over the place.  There is however the xtensa architecture,
doing its own little weird thing to define its gdbarch_tdep.  I did my
best to adapt it, but I can't test those changes.

Change-Id: Ic001903f91ddd106bd6ca09a79dabe8df2d69f3b
2021-11-15 11:29:39 -05:00

135 lines
3.8 KiB
C

/* Target-dependent code for GNU/Linux on Xtensa processors.
Copyright (C) 2007-2021 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "defs.h"
#include "xtensa-tdep.h"
#include "osabi.h"
#include "linux-tdep.h"
#include "solib-svr4.h"
#include "symtab.h"
#include "gdbarch.h"
/* This enum represents the signals' numbers on the Xtensa
architecture. It just contains the signal definitions which are
different from the generic implementation.
It is derived from the file <arch/xtensa/include/uapi/asm/signal.h>,
from the Linux kernel tree. */
enum
{
XTENSA_LINUX_SIGRTMIN = 32,
XTENSA_LINUX_SIGRTMAX = 63,
};
/* Implementation of `gdbarch_gdb_signal_from_target', as defined in
gdbarch.h. */
static enum gdb_signal
xtensa_linux_gdb_signal_from_target (struct gdbarch *gdbarch,
int signal)
{
if (signal >= XTENSA_LINUX_SIGRTMIN && signal <= XTENSA_LINUX_SIGRTMAX)
{
int offset = signal - XTENSA_LINUX_SIGRTMIN;
if (offset == 0)
return GDB_SIGNAL_REALTIME_32;
else
return (enum gdb_signal) (offset - 1
+ (int) GDB_SIGNAL_REALTIME_33);
}
else if (signal > XTENSA_LINUX_SIGRTMAX)
return GDB_SIGNAL_UNKNOWN;
return linux_gdb_signal_from_target (gdbarch, signal);
}
/* Implementation of `gdbarch_gdb_signal_to_target', as defined in
gdbarch.h. */
static int
xtensa_linux_gdb_signal_to_target (struct gdbarch *gdbarch,
enum gdb_signal signal)
{
switch (signal)
{
/* GDB_SIGNAL_REALTIME_32 is not continuous in <gdb/signals.def>,
therefore we have to handle it here. */
case GDB_SIGNAL_REALTIME_32:
return XTENSA_LINUX_SIGRTMIN;
/* GDB_SIGNAL_REALTIME_64 is not valid on Xtensa. */
case GDB_SIGNAL_REALTIME_64:
return -1;
}
/* GDB_SIGNAL_REALTIME_33 to _63 are continuous.
Xtensa does not have _64. */
if (signal >= GDB_SIGNAL_REALTIME_33
&& signal <= GDB_SIGNAL_REALTIME_63)
{
int offset = signal - GDB_SIGNAL_REALTIME_33;
return XTENSA_LINUX_SIGRTMIN + 1 + offset;
}
return linux_gdb_signal_to_target (gdbarch, signal);
}
/* OS specific initialization of gdbarch. */
static void
xtensa_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
{
xtensa_gdbarch_tdep *tdep = (xtensa_gdbarch_tdep *) gdbarch_tdep (gdbarch);
if (tdep->num_nopriv_regs < tdep->num_regs)
{
tdep->num_pseudo_regs += tdep->num_regs - tdep->num_nopriv_regs;
tdep->num_regs = tdep->num_nopriv_regs;
set_gdbarch_num_regs (gdbarch, tdep->num_regs);
set_gdbarch_num_pseudo_regs (gdbarch, tdep->num_pseudo_regs);
}
linux_init_abi (info, gdbarch, 0);
set_solib_svr4_fetch_link_map_offsets
(gdbarch, linux_ilp32_fetch_link_map_offsets);
set_gdbarch_gdb_signal_from_target (gdbarch,
xtensa_linux_gdb_signal_from_target);
set_gdbarch_gdb_signal_to_target (gdbarch,
xtensa_linux_gdb_signal_to_target);
/* Enable TLS support. */
set_gdbarch_fetch_tls_load_module_address (gdbarch,
svr4_fetch_objfile_link_map);
}
void _initialize_xtensa_linux_tdep ();
void
_initialize_xtensa_linux_tdep ()
{
gdbarch_register_osabi (bfd_arch_xtensa, bfd_mach_xtensa, GDB_OSABI_LINUX,
xtensa_linux_init_abi);
}