mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-27 03:51:15 +08:00
cfa8e270c9
The past commit d1e93af64a
("gdb: set current thread in
sparc_{fetch,collect}_inferior_registers (PR gdb/27147)") changed
sparc_fetch_inferior_registers and sparc_store_inferior_registers to
look up the thread corresponding to the regcache's ptid and make it the
current thread. The reason being that down the call chain, some
functions (like sparc_supply_rwindow) can do some memory reads or write,
through target_read_memory/target_write_memory, and those rely on the
current global context.
There is one small problem with this approach: when debugging a
multi-threaded program, the regcache for a new thread is created just
before the corresponding thread_info is created. In fact, the regcache
is created somewhere during the call to thread_from_lwp, which is
responsible for creating the thread_info:
#8 0x0000010000ab9968 in internal_error (file=0x10000bfca20 "/home/simark/src/binutils-gdb/gdb/thread.c", line=1346, fmt=0x10000bfc918 "%s: Assertion `%s' failed.") at /home/simark/src/binutils-gdb/gdbsupport/errors.cc:55
#9 0x0000010000827f3c in switch_to_thread (thr=0x0) at /home/simark/src/binutils-gdb/gdb/thread.c:1346
#10 0x0000010000753444 in sparc_fetch_inferior_registers (proc_target=0x10000fa8cb0 <the_sparc64_linux_nat_target>, regcache=0x10000ff03c0, regnum=-1) at /home/simark/src/binutils-gdb/gdb/sparc-nat.c:175
#11 0x000001000075b908 in sparc64_linux_nat_target::fetch_registers (this=0x10000fa8cb0 <the_sparc64_linux_nat_target>, regcache=0x10000ff03c0, regnum=-1) at /home/simark/src/binutils-gdb/gdb/sparc64-linux-nat.c:38
#12 0x00000100007fe6f4 in target_ops::fetch_registers (this=0x10000f7feb0 <the_thread_db_target>, arg0=0x10000ff03c0, arg1=-1) at /home/simark/src/binutils-gdb/gdb/target-delegates.c:496
#13 0x00000100008162a0 in target_fetch_registers (regcache=0x10000ff03c0, regno=-1) at /home/simark/src/binutils-gdb/gdb/target.c:3287
#14 0x000001000060a4bc in ps_lgetregs (ph=0x10001264368, lwpid=458727, gregset=0x7feff97d388) at /home/simark/src/binutils-gdb/gdb/proc-service.c:158
#15 0xffff800103e32420 in __td_ta_lookup_th_unique (ta_arg=0x100012d7080, lwpid=<optimized out>, th=0x7feff97d7c8) at td_ta_map_lwp2thr.c:119
#16 0xffff800103e32604 in td_ta_map_lwp2thr (ta_arg=0x100012d7080, lwpid=<optimized out>, th=0x7feff97d7c8) at td_ta_map_lwp2thr.c:207
#17 0x000001000051fee8 in thread_from_lwp (stopped=0x100011a3650, ptid=...) at /home/simark/src/binutils-gdb/gdb/linux-thread-db.c:415
#18 0x0000010000520150 in thread_db_notice_clone (parent=..., child=...) at /home/simark/src/binutils-gdb/gdb/linux-thread-db.c:446
#19 0x00000100005068a8 in linux_handle_extended_wait (lp=0x10001230700, status=4479) at /home/simark/src/binutils-gdb/gdb/linux-nat.c:1978
#20 0x000001000050a278 in linux_nat_filter_event (lwpid=458724, status=198015) at /home/simark/src/binutils-gdb/gdb/linux-nat.c:2913
#21 0x000001000050b818 in linux_nat_wait_1 (ptid=..., ourstatus=0x7feff97e8d0, target_options=...) at /home/simark/src/binutils-gdb/gdb/linux-nat.c:3194
#22 0x000001000050ca4c in linux_nat_target::wait (this=0x10000fa8cb0 <the_sparc64_linux_nat_target>, ptid=..., ourstatus=0x7feff97e8d0, target_options=...) at /home/simark/src/binutils-gdb/gdb/linux-nat.c:3432
#23 0x00000100005237ec in thread_db_target::wait (this=0x10000f7feb0 <the_thread_db_target>, ptid=..., ourstatus=0x7feff97e8d0, options=...) at /home/simark/src/binutils-gdb/gdb/linux-thread-db.c:1379
#24 0x00000100007fa668 in target_wait (ptid=..., status=0x7feff97e8d0, options=...) at /home/simark/src/binutils-gdb/gdb/target.c:2000
#25 0x00000100004adb0c in do_target_wait_1 (inf=0x10001173170, ptid=..., status=0x7feff97e8d0, options=...) at /home/simark/src/binutils-gdb/gdb/infrun.c:3464
#26 0x00000100004add48 in operator() (__closure=0x7feff97e658, inf=0x10001173170) at /home/simark/src/binutils-gdb/gdb/infrun.c:3527
#27 0x00000100004ae15c in do_target_wait (wait_ptid=..., ecs=0x7feff97e8a8, options=...) at /home/simark/src/binutils-gdb/gdb/infrun.c:3540
#28 0x00000100004af254 in fetch_inferior_event () at /home/simark/src/binutils-gdb/gdb/infrun.c:3880
#29 0x0000010000486ef8 in inferior_event_handler (event_type=INF_REG_EVENT) at /home/simark/src/binutils-gdb/gdb/inf-loop.c:42
The problem is that while sparc_fetch_inferior_registers runs and is
asked to read the registers of a given ptid, there isn't a thread_info
with that ptid yet. So, find_thread_ptid returns nullptr, and
switch_to_thread gives an internal error.
Fix this by only setting inferior_ptid, instead of the whole global
context, as switch_to_thread does. This is sufficient for
target_read_memory / target_write_memory to work down the line.
Ideally, it would be nice to be able to pass the ptid down the whole
call chain and to target_read_memory / target_write_memory, so that this
setting of inferior_ptid would not be necessary. But this is not going
to happen soon.
This fixes running a multi-threaded program, which would hit the
internal error show in the call stack above.
gdb/ChangeLog:
PR gdb/27899
* sparc-nat.c (sparc_fetch_inferior_registers): Set
inferior_ptid instead of using switch_to_thread.
(sparc_store_inferior_registers): Likewise.
Change-Id: I0b6ddb3af9b11f67b10ee46a734fb82ecc6462d5
337 lines
10 KiB
C
337 lines
10 KiB
C
/* Native-dependent code for SPARC.
|
||
|
||
Copyright (C) 2003-2021 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#include "defs.h"
|
||
#include "inferior.h"
|
||
#include "regcache.h"
|
||
#include "target.h"
|
||
|
||
#include <signal.h>
|
||
#include <sys/ptrace.h>
|
||
#include "gdbsupport/gdb_wait.h"
|
||
#ifdef HAVE_MACHINE_REG_H
|
||
#include <machine/reg.h>
|
||
#endif
|
||
|
||
#include "sparc-tdep.h"
|
||
#include "sparc-nat.h"
|
||
#include "inf-ptrace.h"
|
||
|
||
/* With some trickery we can use the code in this file for most (if
|
||
not all) ptrace(2) based SPARC systems, which includes SunOS 4,
|
||
GNU/Linux and the various SPARC BSD's.
|
||
|
||
First, we need a data structure for use with ptrace(2). SunOS has
|
||
`struct regs' and `struct fp_status' in <machine/reg.h>. BSD's
|
||
have `struct reg' and `struct fpreg' in <machine/reg.h>. GNU/Linux
|
||
has the same structures as SunOS 4, but they're in <asm/reg.h>,
|
||
which is a kernel header. As a general rule we avoid including
|
||
GNU/Linux kernel headers. Fortunately GNU/Linux has a `gregset_t'
|
||
and a `fpregset_t' that are equivalent to `struct regs' and `struct
|
||
fp_status' in <sys/ucontext.h>, which is automatically included by
|
||
<signal.h>. Settling on using the `gregset_t' and `fpregset_t'
|
||
typedefs, providing them for the other systems, therefore solves
|
||
the puzzle. */
|
||
|
||
#ifdef HAVE_MACHINE_REG_H
|
||
#ifdef HAVE_STRUCT_REG
|
||
typedef struct reg gregset_t;
|
||
typedef struct fpreg fpregset_t;
|
||
#else
|
||
typedef struct regs gregset_t;
|
||
typedef struct fp_status fpregset_t;
|
||
#endif
|
||
#endif
|
||
|
||
/* Second, we need to remap the BSD ptrace(2) requests to their SunOS
|
||
equivalents. GNU/Linux already follows SunOS here. */
|
||
|
||
#ifndef PTRACE_GETREGS
|
||
#define PTRACE_GETREGS PT_GETREGS
|
||
#endif
|
||
|
||
#ifndef PTRACE_SETREGS
|
||
#define PTRACE_SETREGS PT_SETREGS
|
||
#endif
|
||
|
||
#ifndef PTRACE_GETFPREGS
|
||
#define PTRACE_GETFPREGS PT_GETFPREGS
|
||
#endif
|
||
|
||
#ifndef PTRACE_SETFPREGS
|
||
#define PTRACE_SETFPREGS PT_SETFPREGS
|
||
#endif
|
||
|
||
static PTRACE_TYPE_RET
|
||
gdb_ptrace (PTRACE_TYPE_ARG1 request, ptid_t ptid, PTRACE_TYPE_ARG3 addr)
|
||
{
|
||
#ifdef __NetBSD__
|
||
/* Support for NetBSD threads: unlike other ptrace implementations in this
|
||
file, NetBSD requires that we pass both the pid and lwp. */
|
||
return ptrace (request, ptid.pid (), addr, ptid.lwp ());
|
||
#else
|
||
pid_t pid = get_ptrace_pid (ptid);
|
||
return ptrace (request, pid, addr, 0);
|
||
#endif
|
||
}
|
||
|
||
/* Register set description. */
|
||
const struct sparc_gregmap *sparc_gregmap;
|
||
const struct sparc_fpregmap *sparc_fpregmap;
|
||
void (*sparc_supply_gregset) (const struct sparc_gregmap *,
|
||
struct regcache *, int , const void *);
|
||
void (*sparc_collect_gregset) (const struct sparc_gregmap *,
|
||
const struct regcache *, int, void *);
|
||
void (*sparc_supply_fpregset) (const struct sparc_fpregmap *,
|
||
struct regcache *, int , const void *);
|
||
void (*sparc_collect_fpregset) (const struct sparc_fpregmap *,
|
||
const struct regcache *, int , void *);
|
||
int (*sparc_gregset_supplies_p) (struct gdbarch *, int);
|
||
int (*sparc_fpregset_supplies_p) (struct gdbarch *, int);
|
||
|
||
/* Determine whether `gregset_t' contains register REGNUM. */
|
||
|
||
int
|
||
sparc32_gregset_supplies_p (struct gdbarch *gdbarch, int regnum)
|
||
{
|
||
/* Integer registers. */
|
||
if ((regnum >= SPARC_G1_REGNUM && regnum <= SPARC_G7_REGNUM)
|
||
|| (regnum >= SPARC_O0_REGNUM && regnum <= SPARC_O7_REGNUM)
|
||
|| (regnum >= SPARC_L0_REGNUM && regnum <= SPARC_L7_REGNUM)
|
||
|| (regnum >= SPARC_I0_REGNUM && regnum <= SPARC_I7_REGNUM))
|
||
return 1;
|
||
|
||
/* Control registers. */
|
||
if (regnum == SPARC32_PC_REGNUM
|
||
|| regnum == SPARC32_NPC_REGNUM
|
||
|| regnum == SPARC32_PSR_REGNUM
|
||
|| regnum == SPARC32_Y_REGNUM)
|
||
return 1;
|
||
|
||
return 0;
|
||
}
|
||
|
||
/* Determine whether `fpregset_t' contains register REGNUM. */
|
||
|
||
int
|
||
sparc32_fpregset_supplies_p (struct gdbarch *gdbarch, int regnum)
|
||
{
|
||
/* Floating-point registers. */
|
||
if (regnum >= SPARC_F0_REGNUM && regnum <= SPARC_F31_REGNUM)
|
||
return 1;
|
||
|
||
/* Control registers. */
|
||
if (regnum == SPARC32_FSR_REGNUM)
|
||
return 1;
|
||
|
||
return 0;
|
||
}
|
||
|
||
/* Fetch register REGNUM from the inferior. If REGNUM is -1, do this
|
||
for all registers (including the floating-point registers). */
|
||
|
||
void
|
||
sparc_fetch_inferior_registers (process_stratum_target *proc_target,
|
||
regcache *regcache, int regnum)
|
||
{
|
||
struct gdbarch *gdbarch = regcache->arch ();
|
||
ptid_t ptid = regcache->ptid ();
|
||
|
||
if (regnum == SPARC_G0_REGNUM)
|
||
{
|
||
gdb_byte zero[8] = { 0 };
|
||
|
||
regcache->raw_supply (SPARC_G0_REGNUM, &zero);
|
||
return;
|
||
}
|
||
|
||
if (regnum == -1 || sparc_gregset_supplies_p (gdbarch, regnum))
|
||
{
|
||
gregset_t regs;
|
||
|
||
if (gdb_ptrace (PTRACE_GETREGS, ptid, (PTRACE_TYPE_ARG3) ®s) == -1)
|
||
perror_with_name (_("Couldn't get registers"));
|
||
|
||
/* Deep down, sparc_supply_rwindow reads memory, so needs the global
|
||
thread context to be set. */
|
||
scoped_restore restore_inferior_ptid
|
||
= make_scoped_restore (&inferior_ptid, ptid);
|
||
|
||
sparc_supply_gregset (sparc_gregmap, regcache, -1, ®s);
|
||
if (regnum != -1)
|
||
return;
|
||
}
|
||
|
||
if (regnum == -1 || sparc_fpregset_supplies_p (gdbarch, regnum))
|
||
{
|
||
fpregset_t fpregs;
|
||
|
||
if (gdb_ptrace (PTRACE_GETFPREGS, ptid, (PTRACE_TYPE_ARG3) &fpregs) == -1)
|
||
perror_with_name (_("Couldn't get floating point status"));
|
||
|
||
sparc_supply_fpregset (sparc_fpregmap, regcache, -1, &fpregs);
|
||
}
|
||
}
|
||
|
||
void
|
||
sparc_store_inferior_registers (process_stratum_target *proc_target,
|
||
regcache *regcache, int regnum)
|
||
{
|
||
struct gdbarch *gdbarch = regcache->arch ();
|
||
ptid_t ptid = regcache->ptid ();
|
||
|
||
if (regnum == -1 || sparc_gregset_supplies_p (gdbarch, regnum))
|
||
{
|
||
gregset_t regs;
|
||
|
||
if (gdb_ptrace (PTRACE_GETREGS, ptid, (PTRACE_TYPE_ARG3) ®s) == -1)
|
||
perror_with_name (_("Couldn't get registers"));
|
||
|
||
sparc_collect_gregset (sparc_gregmap, regcache, regnum, ®s);
|
||
|
||
if (gdb_ptrace (PTRACE_SETREGS, ptid, (PTRACE_TYPE_ARG3) ®s) == -1)
|
||
perror_with_name (_("Couldn't write registers"));
|
||
|
||
/* Deal with the stack regs. */
|
||
if (regnum == -1 || regnum == SPARC_SP_REGNUM
|
||
|| (regnum >= SPARC_L0_REGNUM && regnum <= SPARC_I7_REGNUM))
|
||
{
|
||
ULONGEST sp;
|
||
|
||
regcache_cooked_read_unsigned (regcache, SPARC_SP_REGNUM, &sp);
|
||
|
||
/* Deep down, sparc_collect_rwindow writes memory, so needs the global
|
||
thread context to be set. */
|
||
scoped_restore restore_inferior_ptid
|
||
= make_scoped_restore (&inferior_ptid, ptid);
|
||
|
||
sparc_collect_rwindow (regcache, sp, regnum);
|
||
}
|
||
|
||
if (regnum != -1)
|
||
return;
|
||
}
|
||
|
||
if (regnum == -1 || sparc_fpregset_supplies_p (gdbarch, regnum))
|
||
{
|
||
fpregset_t fpregs, saved_fpregs;
|
||
|
||
if (gdb_ptrace (PTRACE_GETFPREGS, ptid, (PTRACE_TYPE_ARG3) &fpregs) == -1)
|
||
perror_with_name (_("Couldn't get floating-point registers"));
|
||
|
||
memcpy (&saved_fpregs, &fpregs, sizeof (fpregs));
|
||
sparc_collect_fpregset (sparc_fpregmap, regcache, regnum, &fpregs);
|
||
|
||
/* Writing the floating-point registers will fail on NetBSD with
|
||
EINVAL if the inferior process doesn't have an FPU state
|
||
(i.e. if it didn't use the FPU yet). Therefore we don't try
|
||
to write the registers if nothing changed. */
|
||
if (memcmp (&saved_fpregs, &fpregs, sizeof (fpregs)) != 0)
|
||
{
|
||
if (gdb_ptrace (PTRACE_SETFPREGS, ptid,
|
||
(PTRACE_TYPE_ARG3) &fpregs) == -1)
|
||
perror_with_name (_("Couldn't write floating-point registers"));
|
||
}
|
||
|
||
if (regnum != -1)
|
||
return;
|
||
}
|
||
}
|
||
|
||
|
||
/* Implement the to_xfer_partial target_ops method for
|
||
TARGET_OBJECT_WCOOKIE. Fetch StackGhost Per-Process XOR cookie. */
|
||
|
||
enum target_xfer_status
|
||
sparc_xfer_wcookie (enum target_object object,
|
||
const char *annex, gdb_byte *readbuf,
|
||
const gdb_byte *writebuf, ULONGEST offset, ULONGEST len,
|
||
ULONGEST *xfered_len)
|
||
{
|
||
unsigned long wcookie = 0;
|
||
char *buf = (char *)&wcookie;
|
||
|
||
gdb_assert (object == TARGET_OBJECT_WCOOKIE);
|
||
gdb_assert (readbuf && writebuf == NULL);
|
||
|
||
if (offset == sizeof (unsigned long))
|
||
return TARGET_XFER_EOF; /* Signal EOF. */
|
||
if (offset > sizeof (unsigned long))
|
||
return TARGET_XFER_E_IO;
|
||
|
||
#ifdef PT_WCOOKIE
|
||
/* If PT_WCOOKIE is defined (by <sys/ptrace.h>), assume we're
|
||
running on an OpenBSD release that uses StackGhost (3.1 or
|
||
later). Since release 3.6, OpenBSD uses a fully randomized
|
||
cookie. */
|
||
{
|
||
int pid = inferior_ptid.pid ();
|
||
|
||
/* Sanity check. The proper type for a cookie is register_t, but
|
||
we can't assume that this type exists on all systems supported
|
||
by the code in this file. */
|
||
gdb_assert (sizeof (wcookie) == sizeof (register_t));
|
||
|
||
/* Fetch the cookie. */
|
||
if (ptrace (PT_WCOOKIE, pid, (PTRACE_TYPE_ARG3) &wcookie, 0) == -1)
|
||
{
|
||
if (errno != EINVAL)
|
||
perror_with_name (_("Couldn't get StackGhost cookie"));
|
||
|
||
/* Although PT_WCOOKIE is defined on OpenBSD 3.1 and later,
|
||
the request wasn't implemented until after OpenBSD 3.4. If
|
||
the kernel doesn't support the PT_WCOOKIE request, assume
|
||
we're running on a kernel that uses non-randomized cookies. */
|
||
wcookie = 0x3;
|
||
}
|
||
}
|
||
#endif /* PT_WCOOKIE */
|
||
|
||
if (len > sizeof (unsigned long) - offset)
|
||
len = sizeof (unsigned long) - offset;
|
||
|
||
memcpy (readbuf, buf + offset, len);
|
||
*xfered_len = (ULONGEST) len;
|
||
return TARGET_XFER_OK;
|
||
}
|
||
|
||
|
||
void _initialize_sparc_nat ();
|
||
void
|
||
_initialize_sparc_nat ()
|
||
{
|
||
/* Default to using SunOS 4 register sets. */
|
||
if (sparc_gregmap == NULL)
|
||
sparc_gregmap = &sparc32_sunos4_gregmap;
|
||
if (sparc_fpregmap == NULL)
|
||
sparc_fpregmap = &sparc32_sunos4_fpregmap;
|
||
if (sparc_supply_gregset == NULL)
|
||
sparc_supply_gregset = sparc32_supply_gregset;
|
||
if (sparc_collect_gregset == NULL)
|
||
sparc_collect_gregset = sparc32_collect_gregset;
|
||
if (sparc_supply_fpregset == NULL)
|
||
sparc_supply_fpregset = sparc32_supply_fpregset;
|
||
if (sparc_collect_fpregset == NULL)
|
||
sparc_collect_fpregset = sparc32_collect_fpregset;
|
||
if (sparc_gregset_supplies_p == NULL)
|
||
sparc_gregset_supplies_p = sparc32_gregset_supplies_p;
|
||
if (sparc_fpregset_supplies_p == NULL)
|
||
sparc_fpregset_supplies_p = sparc32_fpregset_supplies_p;
|
||
}
|