mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-21 04:42:53 +08:00
66bd1b294d
In a later commit in this series I will propose removing all of the explicit gdbpy_initialize_* calls from python.c and replace these calls with a more generic mechanism. One of the side effects of this generic mechanism is that the order in which the various Python sub-systems within GDB are initialized is no longer guaranteed. On the whole I don't think this matters, most of the sub-systems are independent of each other, though testing did reveal a few places where we did have dependencies, though I don't think those dependencies were explicitly documented in a comment anywhere. This commit removes the first dependency issue, with this and the next commit, all of the implicit inter-sub-system dependencies will be replaced by explicit dependencies, which will allow me to, I think, clean up how the sub-systems are initialized. The dependency is around the py_insn_type. This type is setup in gdbpy_initialize_instruction and used in gdbpy_initialize_record. Rather than depend on the calls to these two functions being in a particular order, in this commit I propose adding a new function py_insn_get_insn_type. This function will take care of setting up the py_insn_type type and calling PyType_Ready. This helper function can be called from gdbpy_initialize_record and gdbpy_initialize_instruction, and the py_insn_type will be initialized just once. To me this is better, the dependency is now really obvious, but also, we no longer care in which order gdbpy_initialize_record and gdbpy_initialize_instruction are called. There should be no user visible changes after this commit.
36 lines
1.4 KiB
C
36 lines
1.4 KiB
C
/* Python interface to instruction objects.
|
|
|
|
Copyright 2017-2022 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef PYTHON_PY_INSTRUCTION_H
|
|
#define PYTHON_PY_INSTRUCTION_H
|
|
|
|
#include "python-internal.h"
|
|
|
|
/* Return a pointer to the py_insn_type object (see py-instruction.c), but
|
|
ensure that PyType_Ready has been called for the type first. If the
|
|
PyType_Ready call is successful then subsequent calls to this function
|
|
will not call PyType_Ready, the type pointer will just be returned.
|
|
|
|
If the PyType_Ready call is not successful then nullptr is returned and
|
|
subsequent calls to this function will call PyType_Ready again. */
|
|
|
|
extern PyTypeObject *py_insn_get_insn_type ();
|
|
|
|
#endif /* PYTHON_PY_INSTRUCTION_H */
|