binutils-gdb/gas
Thomas Preud'homme 4d354d8b89 [ARM] Clean up selection of feature bits
I've always found the code in ARM backend of gas to control what
CPU/architecture and FPU are selected by the user and to support
autodetection of features complex and confusing. Chief among the
issues I have with that code is the lack of comments to explain
the meaning of the various variables. This patch addresses that
and much more:

- add comments to explain meaning of all arm_feature_set variables
- keep track of currently selected CPU, extensions and FPU in a separate
  set of new variables
- make naming of variable more consistent
- remove dead code
- simplify handling of extensions

The overall approach is as follows:

* restrict m*_opt variable to hold the feature bits of the
  corresponding mcpu/march/mfpu command-line options
* record selected CPU, extensions and FPU in new selected_* during
  md_begin
* whenever a .cpu/.arch/.arch_extension/.fpu directive is met, update
  the corresponding selected_* variables (eg. selected_arch, then
  selected_cpu for a .cpu or .arch directive) and then finally
  cpu_variant from them
* pass extension feature set pointer by value to arm_parse_extension
  since it's only ever called from arm_parse_cpu and arm_parse_arch
  which allocate the extension feature set themselves
* likewise, remove allocation from s_arm_arch_extension since the use
  of arm_feature_set structure for selected_ext rather than a pointer
  alleviate the need for it
* in autodetection mode, only set all CPU fits in cpu_variant but leave
  selected_cpu* variables unset
* in md_begin, remove dead "else if" to set a default FPU when no FPU
  was selected. Setting a default FPU based on CPU as did the code
  before it turn dead should be based on the default FPU field of the
  CPU and architecture table as will be done in a separate patch. Logic
  is wrong anyway since it sets VFP2 as default FPU for Armv6-M and
  Armv7-M

Hopefully that should be enough to understand the change but if not feel
free to ask questions about the patch. While I believe the new code is
easier to understand, it remains complex and the old one was even more
complex so the change is difficult to understand.

2018-03-01  Thomas Preud'homme  <thomas.preudhomme@arm.com>

	gas/
	* config/tc-arm.c (cpu_variant, arm_arch_used, thumb_arch_used,
	legacy_cpu, legacy_fpu, mcpu_cpu_opt, dyn_mcpu_ext_opt,
	mcpu_fpu_opt, march_cpu_opt, dyn_march_ext_opt, march_fpu_opt,
	mfpu_opt, object_arch, selected_cpu): Comment meaning of variables.
	(dyn_mcpu_ext_opt): Also rename into ...
	(mcpu_ext_opt): This.
	(dyn_march_ext_opt): Also rename into ...
	(march_ext_opt): This.
	(object_arch): Also rename into ...
	(selected_object_arch): This and make it a plain arm_feature_set
	structure.
	(selected_arch, selected_ext, selected_fpu): New static variables.
	(mark_feature_used): Fix comments, feature is marked as used iff it is
	currently allowed.
	(do_bx): Adapt to change in name and type of object_arch.
	(md_begin): Set selected_arch rather than mcpu_cpu_opt, selected_ext
	rather than dyn_mcpu_ext_opt and selected_fpu rather than mfpu_opt.
	Remove dead code to set default FPU if architecture version is greater
	than 5.  Set all CPU bits of cpu_variant directly in autodection
	leaving mcpu_cpu_opt, selected_arch and selected_cpu unset.
	(arm_parse_extension): Take extension feature set pointer parameter by
	value rather than by pointer.  Remove allocation code.  Adapt code
	accordingly.
	(arm_parse_cpu): Adapt to variable renaming and changes in
	arm_parse_extension () signature.
	(arm_parse_arch): Likewise.
	(aeabi_set_public_attributes): Also set selected_arch and selected_ext
	in addition to selected_cpu.  Set flags_arch and flags_ext from them
	instead of selected_cpu.  Adapt to variables renaming and type change.
	(arm_md_post_relax): Adapt to variable renaming.
	(s_arm_cpu): Set selcted_cpu_cpu and selected_ext instead of
	mcpu_cpu_opt and dyn_mcpu_ext_opt.  Set selected_cpu from them and
	cpu_variant from selected_cpu and selected_fpu.
	(s_arm_arch): Likewise.
	(s_arm_object_arch): Adapt to variable renaming.
	(s_arm_arch_extension): Use ARM_CPU_IS_ANY instead of checking feature
	set against arm_any.  Check selected_arch rather than *mcpu_cpu_opt.
	Set selected_ext rather than *dyn_mcpu_ext_opt and remove allocation
	code.
	(s_arm_fpu): Set selected_fpu instead of mfpu_opt.  Set all CPU feature
	bits if in autodetection mode.
2018-03-01 16:23:38 +00:00
..
config [ARM] Clean up selection of feature bits 2018-03-01 16:23:38 +00:00
doc gas: Rename .nop directive to .nops 2018-02-27 14:46:03 -08:00
po Add a new Portuguese translation for the binutils sub-directory, and update the Russian translation for the gas sub-directory. 2018-02-27 12:27:30 +00:00
testsuite x86: Encode AVX256/AVX512 vpsub[bwdq] with VEX128/EVEX128 2018-03-01 06:08:31 -08:00
.gitignore
acinclude.m4
aclocal.m4
app.c PR22714, Assembler preprocessor loses track of \@ 2018-01-31 16:58:26 +10:30
as.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
as.h Add .nop assembler directive 2018-02-17 05:20:57 -08:00
asintl.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
atof-generic.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
bignum.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
bit_fix.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
cgen.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
cgen.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
ChangeLog [ARM] Clean up selection of feature bits 2018-03-01 16:23:38 +00:00
ChangeLog-0001
ChangeLog-0203
ChangeLog-2004
ChangeLog-2005
ChangeLog-2006
ChangeLog-2007
ChangeLog-2008
ChangeLog-2009
ChangeLog-2010
ChangeLog-2011
ChangeLog-2012
ChangeLog-2013
ChangeLog-2014
ChangeLog-2015
ChangeLog-2016
ChangeLog-2017 ChangeLog rotation 2018-01-03 17:49:42 +10:30
ChangeLog-9295
ChangeLog-9697
ChangeLog-9899
compress-debug.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
compress-debug.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
cond.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
config.in
configure Add missing translations to ALL_LINGUAS 2018-03-01 09:17:02 +10:30
configure.ac Add missing translations to ALL_LINGUAS 2018-03-01 09:17:02 +10:30
configure.com Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
configure.tgt MIPS/GAS: Correct `mips-*-windiss' target emulation configuration 2018-01-26 23:05:05 +00:00
CONTRIBUTORS Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
COPYING
debug.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
dep-in.sed
depend.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
dw2gencfi.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
dw2gencfi.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
dwarf2dbg.c Fix compile time warning messages from gcc version 8 about cast between incompatible function types. 2018-02-13 13:14:47 +00:00
dwarf2dbg.h Fix compile time warning messages from gcc version 8 about cast between incompatible function types. 2018-02-13 13:14:47 +00:00
ecoff.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
ecoff.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
ehopt.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
emul-target.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
emul.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
expr.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
expr.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
flonum-copy.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
flonum-konst.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
flonum-mult.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
flonum.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
frags.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
frags.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
gdbinit.in
hash.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
hash.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
input-file.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
input-file.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
input-scrub.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
itbl-lex-wrapper.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
itbl-lex.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
itbl-lex.l Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
itbl-ops.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
itbl-ops.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
itbl-parse.y Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
listing.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
listing.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
literal.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
macro.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
macro.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
MAINTAINERS Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
Makefile.am Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
Makefile.in Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
makefile.vms Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
messages.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
NEWS gas: Rename .nop directive to .nops 2018-02-27 14:46:03 -08:00
obj.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
output-file.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
output-file.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
read.c gas: Rename .nop directive to .nops 2018-02-27 14:46:03 -08:00
read.h gas: Rename .nop directive to .nops 2018-02-27 14:46:03 -08:00
README Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
remap.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
sb.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
sb.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
stabs.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
stamp-h.in
struc-symbol.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
subsegs.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
subsegs.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
symbols.c Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
symbols.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
tc.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30
write.c gas: Rename .nop directive to .nops 2018-02-27 14:46:03 -08:00
write.h Update year range in copyright notice of binutils files 2018-01-03 17:49:56 +10:30

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

		README for GAS

A number of things have changed since version 1 and the wonderful
world of gas looks very different.  There's still a lot of irrelevant
garbage lying around that will be cleaned up in time.  Documentation
is scarce, as are logs of the changes made since the last gas release.
My apologies, and I'll try to get something useful.

Unpacking and Installation - Summary
====================================

See ../binutils/README.

To build just the assembler, make the target all-gas.

Documentation
=============

The GAS release includes texinfo source for its manual, which can be processed
into `info' or `dvi' forms.

The DVI form is suitable for printing or displaying; the commands for doing
this vary from system to system.  On many systems, `lpr -d' will print a DVI
file.  On others, you may need to run a program such as `dvips' to convert the
DVI file into a form your system can print.

If you wish to build the DVI file, you will need to have TeX installed on your
system.  You can rebuild it by typing:

	cd gas/doc
	make as.dvi

The Info form is viewable with the GNU Emacs `info' subsystem, or the
stand-alone `info' program, available as part of the GNU Texinfo distribution.
To build the info files, you will need the `makeinfo' program.  Type:

	cd gas/doc
	make info

Specifying names for hosts and targets
======================================

   The specifications used for hosts and targets in the `configure'
script are based on a three-part naming scheme, but some short
predefined aliases are also supported.  The full naming scheme encodes
three pieces of information in the following pattern:

     ARCHITECTURE-VENDOR-OS

   For example, you can use the alias `sun4' as a HOST argument or in a
`--target=TARGET' option.  The equivalent full name is
`sparc-sun-sunos4'.

   The `configure' script accompanying GAS does not provide any query
facility to list all supported host and target names or aliases.
`configure' calls the Bourne shell script `config.sub' to map
abbreviations to full names; you can read the script, if you wish, or
you can use it to test your guesses on abbreviations--for example:

     % sh config.sub i386v
     i386-unknown-sysv
     % sh config.sub i786v
     Invalid configuration `i786v': machine `i786v' not recognized


`configure' options
===================

   Here is a summary of the `configure' options and arguments that are
most often useful for building GAS.  `configure' also has several other
options not listed here.

     configure [--help]
               [--prefix=DIR]
               [--srcdir=PATH]
               [--host=HOST]
               [--target=TARGET]
               [--with-OPTION]
               [--enable-OPTION]

You may introduce options with a single `-' rather than `--' if you
prefer; but you may abbreviate option names if you use `--'.

`--help'
     Print a summary of the options to `configure', and exit.

`-prefix=DIR'
     Configure the source to install programs and files under directory
     `DIR'.

`--srcdir=PATH'
     Look for the package's source code in directory DIR.  Usually
     `configure' can determine that directory automatically.

`--host=HOST'
     Configure GAS to run on the specified HOST.  Normally the
     configure script can figure this out automatically.

     There is no convenient way to generate a list of all available
     hosts.

`--target=TARGET'
     Configure GAS for cross-assembling programs for the specified
     TARGET.  Without this option, GAS is configured to assemble .o files
     that run on the same machine (HOST) as GAS itself.

     There is no convenient way to generate a list of all available
     targets.

`--enable-OPTION'
     These flags tell the program or library being configured to
     configure itself differently from the default for the specified
     host/target combination.  See below for a list of `--enable'
     options recognized in the gas distribution.

`configure' accepts other options, for compatibility with configuring
other GNU tools recursively; but these are the only options that affect
GAS or its supporting libraries.

The `--enable' options recognized by software in the gas distribution are:

`--enable-targets=...'
     This causes one or more specified configurations to be added to those for
     which BFD support is compiled.  Currently gas cannot use any format other
     than its compiled-in default, so this option is not very useful.

`--enable-bfd-assembler'
     This causes the assembler to use the new code being merged into it to use
     BFD data structures internally, and use BFD for writing object files.
     For most targets, this isn't supported yet.  For most targets where it has
     been done, it's already the default.  So generally you won't need to use
     this option.

Compiler Support Hacks
======================

On a few targets, the assembler has been modified to support a feature
that is potentially useful when assembling compiler output, but which
may confuse assembly language programmers.  If assembler encounters a
.word pseudo-op of the form symbol1-symbol2 (the difference of two
symbols), and the difference of those two symbols will not fit in 16
bits, the assembler will create a branch around a long jump to
symbol1, and insert this into the output directly before the next
label: The .word will (instead of containing garbage, or giving an
error message) contain (the address of the long jump)-symbol2.  This
allows the assembler to assemble jump tables that jump to locations
very far away into code that works properly.  If the next label is
more than 32K away from the .word, you lose (silently); RMS claims
this will never happen.  If the -K option is given, you will get a
warning message when this happens.


REPORTING BUGS IN GAS
=====================

Bugs in gas should be reported to:

   bug-binutils@gnu.org.

They may be cross-posted to gcc-bugs@gnu.org if they affect the use of
gas with gcc.  They should not be reported just to gcc-bugs, since not
all of the maintainers read that list.

See ../binutils/README for what we need in a bug report.

Copyright (C) 2012-2018 Free Software Foundation, Inc.

Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright
notice and this notice are preserved.