binutils-gdb/gdb/testsuite/gdb.trace
Tom de Vries d1e36019c1 [gdb/testsuite] Remove superfluous 3rd argument from gdb_test call (2)
There's a pattern:
...
gdb_test <command> <pattern> <command>
...
that can be written shorter as:
...
gdb_test <command> <pattern>
...

Detect this pattern in proc gdb_test:
...
     global gdb_prompt
     upvar timeout timeout

     if [llength $args]>2 then {
        set message [lindex $args 2]
+       if { $message == [lindex $args 0] && [llength $args] == 3 } {
+           error "HERE"
+       }
     } else {
         set message [lindex $args 0]
     }
...
and fix all occurrences in some gdb testsuite subdirs.

Tested on x86_64-linux.

gdb/testsuite/ChangeLog:

2019-10-31  Tom de Vries  <tdevries@suse.de>

	* gdb.arch/amd64-disp-step-avx.exp: Drop superfluous 3rd argument to
	gdb_test.
	* gdb.arch/amd64-disp-step.exp: Same.
	* gdb.asm/asm-source.exp: Same.
	* gdb.btrace/buffer-size.exp: Same.
	* gdb.btrace/cpu.exp: Same.
	* gdb.btrace/enable.exp: Same.
	* gdb.dwarf2/count.exp: Same.
	* gdb.dwarf2/dw2-ranges-func.exp: Same.
	* gdb.dwarf2/dw2-ranges-psym.exp: Same.
	* gdb.fortran/vla-datatypes.exp: Same.
	* gdb.fortran/vla-history.exp: Same.
	* gdb.fortran/vla-ptype.exp: Same.
	* gdb.fortran/vla-value.exp: Same.
	* gdb.fortran/whatis_type.exp: Same.
	* gdb.guile/guile.exp: Same.
	* gdb.multi/tids.exp: Same.
	* gdb.python/py-finish-breakpoint.exp: Same.
	* gdb.python/py-framefilter.exp: Same.
	* gdb.python/py-pp-registration.exp: Same.
	* gdb.python/py-xmethods.exp: Same.
	* gdb.python/python.exp: Same.
	* gdb.server/connect-with-no-symbol-file.exp: Same.
	* gdb.server/no-thread-db.exp: Same.
	* gdb.server/run-without-local-binary.exp: Same.
	* gdb.stabs/weird.exp: Same.
	* gdb.threads/attach-many-short-lived-threads.exp: Same.
	* gdb.threads/thread-find.exp: Same.
	* gdb.threads/tls-shared.exp: Same.
	* gdb.threads/tls.exp: Same.
	* gdb.threads/wp-replication.exp: Same.
	* gdb.trace/ax.exp: Same.
	* lib/gdb.exp (gdb_test_exact, help_test_raw): Same.

Change-Id: I2fa544c68f8c0099a77e03ff04ddc010eb2b6c7c
2019-10-31 23:03:25 +01:00
..
actions-changed.c
actions-changed.exp
actions.c
actions.exp
ax.exp
backtrace.exp
change-loc-1.c
change-loc-2.c
change-loc.c
change-loc.exp
change-loc.h
circ.c
circ.exp
collection.c
collection.exp
deltrace.exp
disconnected-tracing.c
disconnected-tracing.exp
entry-values.c
entry-values.exp
ftrace-lock.c
ftrace-lock.exp
ftrace.c
ftrace.exp
infotrace.exp
mi-trace-frame-collected.exp
mi-trace-save.exp
mi-trace-unavailable.exp
mi-traceframe-changed.exp
mi-tracepoint-changed.exp
mi-tsv-changed.exp
no-attach-trace.c
no-attach-trace.exp
packetlen.exp
passc-dyn.exp
passcount.exp
pending.c
pending.exp
pendshr1.c
pendshr2.c
pr16508.exp
qtro.c
qtro.exp
range-stepping.c
range-stepping.exp
read-memory.c
read-memory.exp
report.exp
save-trace.exp
signal.c
signal.exp
stap-trace.c
stap-trace.exp
status-stop.c
status-stop.exp
strace.c
strace.exp
tfile.c
tfile.exp
tfind.exp
trace-break.c
trace-break.exp
trace-buffer-size.c
trace-buffer-size.exp
trace-common.h
trace-condition.c
trace-condition.exp
trace-enable-disable.c
trace-enable-disable.exp
trace-mt.c
trace-mt.exp
trace-unavailable.c
tracecmd.exp
tracefile-pseudo-reg.c
tracefile-pseudo-reg.exp
tspeed.c
tspeed.exp
tstatus.exp
tsv.exp
unavailable-dwarf-piece.c
unavailable-dwarf-piece.exp
unavailable.cc
unavailable.exp
while-dyn.exp
while-stepping.exp