mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-02-17 13:10:12 +08:00
0fcf331bb1
Match the condition used in `elf_vax_instantiate_got_entries' for the
creation of GOT entries in the processing of R_VAX_GOT32 relocations in
`elf_vax_check_relocs', removing incorrect warnings about a GOT addend
mismatch like:
./ld-new: tmpdir/got-local-ref-off-r.o: warning: GOT addend of 1 to `bar_hidden' does not match previous GOT addend of 0
./ld-new: tmpdir/got-local-ref-off-r.o: warning: GOT addend of 2 to `bar_hidden' does not match previous GOT addend of 0
and corresponding failures with the test cases newly added here:
FAIL: GOT test (executable hidden reference with offset)
FAIL: GOT test (executable visible reference with offset)
for symbols that are considered local for reasons other than having been
forced local with a version script, which is usually the ELF visibility.
Correct code is produced regardless, but the warning breaks `-Werror'
compilation and may upset people regardless.
Interestingly this shows with executable links only, because in shared
library links code from `elf_link_add_object_symbols' triggers:
/* If the symbol already has a dynamic index, but
visibility says it should not be visible, turn it into
a local symbol. */
switch (ELF_ST_VISIBILITY (h->other))
{
case STV_INTERNAL:
case STV_HIDDEN:
(*bed->elf_backend_hide_symbol) (info, h, TRUE);
dynsym = FALSE;
break;
}
that sets `h->forced_local' like with a version script.
Add suitable test cases including disassembly to verify correct code has
been produced where no warnings have been issued, and that warnings do
get issued where necessary. Do not verify (broken) code produced in the
latter case; we should probably make the warning an error, or preferably
actually start supporting GOT references with different addends as they
appear feasible with explicitly relocated GOT that we use.
bfd/
* elf32-vax.c (elf_vax_check_relocs) <R_VAX_GOT32>: Use
SYMBOL_REFERENCES_LOCAL rather than `h->forced_local' to check
whether the symbol referred is local or not.
ld/
* testsuite/ld-vax-elf/got-local-exe-off-hidden.dd: New test
dump.
* testsuite/ld-vax-elf/got-local-exe-off-visible.dd: New test
dump.
* testsuite/ld-vax-elf/got-local-lib-off-hidden.dd: New test
dump.
* testsuite/ld-vax-elf/got-local-lib-off-visible.ed: New test
dump.
* testsuite/ld-vax-elf/got-local-off-external.ed: New test dump.
* testsuite/ld-vax-elf/got-local-exe-off.xd: New test dump.
* testsuite/ld-vax-elf/got-local-lib-off.xd: New test dump.
* testsuite/ld-vax-elf/got-local.ld: New test linker script.
* testsuite/ld-vax-elf/got-local-aux-off.s: New test source.
* testsuite/ld-vax-elf/got-local-def-off.s: New test source.
* testsuite/ld-vax-elf/got-local-ref-off-external.s: New test
source.
* testsuite/ld-vax-elf/got-local-ref-off-hidden.s: New test
source.
* testsuite/ld-vax-elf/got-local-ref-off-visible.s: New test
source.
* testsuite/ld-vax-elf/vax-elf.exp: Run the new tests.
192 lines
6.0 KiB
Plaintext
192 lines
6.0 KiB
Plaintext
# Expect script for VAX ELF linker tests
|
|
# Copyright (C) 2012-2020 Free Software Foundation, Inc.
|
|
#
|
|
# This file is part of the GNU Binutils.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program; if not, write to the Free Software
|
|
# Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
|
|
# MA 02110-1301, USA.
|
|
#
|
|
|
|
if { ![istarget vax-*-*] || ![is_elf_format] } {
|
|
return
|
|
}
|
|
|
|
run_ld_link_tests [list \
|
|
[list "PLT test (shared library)" \
|
|
"-shared -T plt-local-lib.ld --hash-style=sysv" "" \
|
|
"-k" \
|
|
{ plt-local-lib.s } \
|
|
{ { objdump -d plt-local-lib.dd } } \
|
|
"plt-local-lib.so"] \
|
|
[list "PLT test (object 1)" \
|
|
"-r" "" \
|
|
"-k" \
|
|
{ plt-local-hidden-pic.s } \
|
|
{} \
|
|
"plt-local-hidden-pic-r.o"] \
|
|
[list "PLT test (object 2)" \
|
|
"-r" "" \
|
|
"-k" \
|
|
{ plt-local-rehidden-pic.s } \
|
|
{} \
|
|
"plt-local-rehidden-pic-r.o"] \
|
|
[list "PLT test (executable)" \
|
|
"-T plt-local.ld --hash-style=sysv tmpdir/plt-local-hidden-pic-r.o \
|
|
tmpdir/plt-local-rehidden-pic-r.o tmpdir/plt-local-lib.so" "" \
|
|
"" \
|
|
{ plt-local.s } \
|
|
{ { objdump -d plt-local.dd } } \
|
|
"plt-local"]]
|
|
|
|
# Global offset table tests. Make sure hidden symbols do not get GOT
|
|
# assignments. Also verify offset references.
|
|
run_ld_link_tests [list \
|
|
[list "GOT test (auxiliary shared library)" \
|
|
"-shared" "" \
|
|
"-k" \
|
|
{ got-local-aux.s } \
|
|
{} \
|
|
"got-local-aux.so"] \
|
|
[list "GOT test (auxiliary shared library for offsets)" \
|
|
"-shared" "" \
|
|
"-k" \
|
|
{ got-local-aux-off.s } \
|
|
{} \
|
|
"got-local-aux-off.so"] \
|
|
[list "GOT test (object 1)" \
|
|
"-r" "" \
|
|
"-k" \
|
|
{ got-local-ref.s } \
|
|
{} \
|
|
"got-local-ref-r.o"] \
|
|
[list "GOT test (object 1 hidden reference with offset)" \
|
|
"-r" "" \
|
|
"-k" \
|
|
{ got-local-ref-off-hidden.s } \
|
|
{} \
|
|
"got-local-ref-off-hidden-r.o"] \
|
|
[list "GOT test (object 1 visible reference with offset)" \
|
|
"-r" "" \
|
|
"-k" \
|
|
{ got-local-ref-off-visible.s } \
|
|
{} \
|
|
"got-local-ref-off-visible-r.o"] \
|
|
[list "GOT test (object 1 external reference with offset)" \
|
|
"-r" "" \
|
|
"-k" \
|
|
{ got-local-ref-off-external.s } \
|
|
{} \
|
|
"got-local-ref-off-external-r.o"] \
|
|
[list "GOT test (object 2)" \
|
|
"-r" "" \
|
|
"-k" \
|
|
{ got-local-def.s } \
|
|
{} \
|
|
"got-local-def-r.o"] \
|
|
[list "GOT test (object 2 for offsets)" \
|
|
"-r" "" \
|
|
"-k" \
|
|
{ got-local-def-off.s } \
|
|
{} \
|
|
"got-local-def-off-r.o"] \
|
|
[list "GOT test (executable)" \
|
|
"-e 0 tmpdir/got-local-aux.so tmpdir/got-local-ref-r.o \
|
|
tmpdir/got-local-def-r.o" "" \
|
|
"" \
|
|
{} \
|
|
{ { readelf "-x .got" got-local-exe.xd } } \
|
|
"got-local-exe"] \
|
|
[list "GOT test (shared library)" \
|
|
"-shared tmpdir/got-local-aux.so tmpdir/got-local-ref-r.o \
|
|
tmpdir/got-local-def-r.o" "" \
|
|
"" \
|
|
{} \
|
|
{ { readelf "-x .got" got-local-lib.xd } } \
|
|
"got-local-lib.so"] \
|
|
[list "GOT test (executable hidden reference with offset)" \
|
|
"-e 0 -T got-local.ld tmpdir/got-local-aux-off.so \
|
|
tmpdir/got-local-ref-off-hidden-r.o \
|
|
tmpdir/got-local-def-off-r.o" "" \
|
|
"" \
|
|
{} \
|
|
{ { readelf "-x .got" got-local-exe-off.xd } \
|
|
{ objdump -d got-local-exe-off-hidden.dd } } \
|
|
"got-local-exe-off-hidden"] \
|
|
[list "GOT test (shared library hidden reference with offset)" \
|
|
"-shared -T got-local.ld tmpdir/got-local-aux-off.so \
|
|
tmpdir/got-local-ref-off-hidden-r.o \
|
|
tmpdir/got-local-def-off-r.o" "" \
|
|
"" \
|
|
{} \
|
|
{ { readelf "-x .got" got-local-lib-off.xd } \
|
|
{ objdump -d got-local-lib-off-hidden.dd } } \
|
|
"got-local-lib-off-hidden.so"] \
|
|
[list "GOT test (executable visible reference with offset)" \
|
|
"-e 0 -T got-local.ld tmpdir/got-local-aux-off.so \
|
|
tmpdir/got-local-ref-off-visible-r.o \
|
|
tmpdir/got-local-def-off-r.o" "" \
|
|
"" \
|
|
{} \
|
|
{ { readelf "-x .got" got-local-exe-off.xd } \
|
|
{ objdump -d got-local-exe-off-visible.dd } } \
|
|
"got-local-exe-off-visible"] \
|
|
[list "GOT test (shared library visible reference with offset)" \
|
|
"-shared -T got-local.ld tmpdir/got-local-aux-off.so \
|
|
tmpdir/got-local-ref-off-visible-r.o \
|
|
tmpdir/got-local-def-off-r.o" "" \
|
|
"" \
|
|
{} \
|
|
{ { ld got-local-lib-off-visible.ed } } \
|
|
"got-local-lib-off-visible.so"] \
|
|
[list "GOT test (executable external reference with offset)" \
|
|
"-e 0 -T got-local.ld tmpdir/got-local-aux-off.so \
|
|
tmpdir/got-local-ref-off-external-r.o \
|
|
tmpdir/got-local-def-off-r.o" "" \
|
|
"" \
|
|
{} \
|
|
{ { ld got-local-off-external.ed } } \
|
|
"got-local-exe-off-external"] \
|
|
[list "GOT test (shared library external reference with offset)" \
|
|
"-shared -T got-local.ld tmpdir/got-local-aux-off.so \
|
|
tmpdir/got-local-ref-off-external-r.o \
|
|
tmpdir/got-local-def-off-r.o" "" \
|
|
"" \
|
|
{} \
|
|
{ { ld got-local-off-external.ed } } \
|
|
"got-local-lib-off-external.so"]]
|
|
|
|
# Export class relocation tests.
|
|
run_ld_link_tests [list \
|
|
[list \
|
|
"VAX export class call relocation test" \
|
|
"-shared -Ttext 0x12340000 -T export-class.ld --hash-style=sysv" "" \
|
|
"-k" \
|
|
[list export-class-call.s export-class-def.s] \
|
|
[list \
|
|
[list objdump -d export-class-call.dd] \
|
|
[list readelf -r export-class-call.rd] \
|
|
[list readelf "-x .got" export-class-call.xd]] \
|
|
"export-class-call.so"] \
|
|
[list \
|
|
"VAX export class data relocation test" \
|
|
"-shared -Ttext 0x12340000 -T export-class.ld --hash-style=sysv" "" \
|
|
"-k" \
|
|
[list export-class-data.s export-class-def.s] \
|
|
[list \
|
|
[list objdump -d export-class-data.dd] \
|
|
[list readelf -r export-class-data.rd] \
|
|
[list readelf "-x .got" export-class-data.xd]] \
|
|
"export-class-data.so"]]
|