mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-15 04:31:49 +08:00
0ac85db529
There is a lot of support code for the test suppression mechanism. But
as far as I know, it is not useful. The gdb_suppress_tests proc is in
fact disabled with this comment that has been there since forever:
return; # fnf - disable pending review of results where
# testsuite ran better without this
I suggest to just remove everything related to test suppression, that
removes some unnecessary complexity from the support code and the tests.
gdb/testsuite/ChangeLog:
* lib/gdb.exp (gdb_test_multiple): Remove things related to test
suppression.
(default_gdb_exit): Likewise.
(default_gdb_spawn): Likewise.
(send_gdb): Likewise.
(gdb_expect): Likewise.
(gdb_expect_list): Likewise.
(default_gdb_init): Likewise.
(gdb_suppress_entire_file): Remove.
(gdb_suppress_tests): Remove.
(gdb_stop_suppressing_tests): Remove.
(gdb_clear_suppressed): Remove.
* lib/mi-support.exp (mi_uncatched_gdb_exit): Remove things
related to test suppression.
(default_mi_gdb_start): Likewise.
(mi_gdb_reinitialize_dir): Likewise.
(mi_gdb_test): Likewise.
(mi_run_cmd_full): Likewise.
(mi_runto_helper): Likewise.
(mi_execute_to): Likewise.
* lib/prompt.exp (default_prompt_gdb_start): Likewise.
* gdb.base/bitfields.exp: Likewise.
* gdb.base/bitfields2.exp: Likewise.
* gdb.base/break.exp: Likewise.
* gdb.base/call-sc.exp: Likewise.
* gdb.base/callfuncs.exp: Likewise.
* gdb.base/dfp-test.exp: Likewise.
* gdb.base/endian.exp: Likewise.
* gdb.base/exprs.exp: Likewise.
* gdb.base/funcargs.exp: Likewise.
* gdb.base/hbreak2.exp: Likewise.
* gdb.base/recurse.exp: Likewise.
* gdb.base/scope.exp: Likewise.
* gdb.base/sepdebug.exp: Likewise.
* gdb.base/structs.exp: Likewise.
* gdb.base/until.exp: Likewise.
* gdb.cp/misc.exp: Likewise.
Change-Id: Ie6d3025091691ba72010faa28b85ebd417b738f7
90 lines
2.4 KiB
Plaintext
90 lines
2.4 KiB
Plaintext
# Copyright (C) 2011-2021 Free Software Foundation, Inc.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Specialized subroutines for launching gdb and testing the very first prompt.
|
|
|
|
|
|
#
|
|
# start gdb -- start gdb running, prompt procedure
|
|
# this procedure differs from the default in that you must pass 'set height 0',
|
|
# and 'set width 0', yourself in GDBFLAGS, and it has a gdb_prompt_fail variable,
|
|
#
|
|
# uses pass if it sees $gdb_prompt, and fail if it sees $gdb_prompt_fail.
|
|
#
|
|
proc default_prompt_gdb_start { } {
|
|
global GDB
|
|
global INTERNAL_GDBFLAGS GDBFLAGS
|
|
global gdb_prompt
|
|
global gdb_prompt_fail
|
|
global timeout
|
|
global gdb_spawn_id
|
|
|
|
verbose "Spawning $GDB $INTERNAL_GDBFLAGS $GDBFLAGS"
|
|
|
|
if [info exists gdb_spawn_id] {
|
|
return 0
|
|
}
|
|
|
|
if ![is_remote host] {
|
|
if { [which $GDB] == 0 } then {
|
|
perror "$GDB does not exist."
|
|
exit 1
|
|
}
|
|
}
|
|
set res [remote_spawn host "$GDB $INTERNAL_GDBFLAGS $GDBFLAGS [host_info gdb_opts]"]
|
|
if { $res < 0 || $res == "" } {
|
|
perror "Spawning $GDB failed."
|
|
return 1
|
|
}
|
|
gdb_expect 360 {
|
|
-re ".*$gdb_prompt_fail.*$gdb_prompt_fail.*" {
|
|
fail "double prompted fail prompt"
|
|
}
|
|
-re ".*$gdb_prompt.*$gdb_prompt.*" {
|
|
fail "double prompted"
|
|
}
|
|
-re "\[\r\n\]$gdb_prompt_fail $" {
|
|
fail "GDB initializing first prompt"
|
|
}
|
|
-re "\[\r\n\]$gdb_prompt $" {
|
|
pass "GDB initializing first prompt"
|
|
}
|
|
-re "$gdb_prompt $" {
|
|
perror "GDB never initialized."
|
|
return -1
|
|
}
|
|
-re "$gdb_prompt_fail $" {
|
|
perror "GDB never initialized."
|
|
return -1
|
|
}
|
|
timeout {
|
|
perror "(timeout) GDB never initialized after 10 seconds."
|
|
remote_close host
|
|
return -1
|
|
}
|
|
}
|
|
set gdb_spawn_id $res
|
|
return 0
|
|
}
|
|
|
|
#
|
|
# Overridable function. You can override this function in your
|
|
# baseboard file.
|
|
#
|
|
proc prompt_gdb_start { } {
|
|
default_prompt_gdb_start
|
|
}
|
|
|