mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-24 12:35:55 +08:00
14897d65b5
Currently, the gdb.base/fork-running-state.exp testcase leaves a few
processes lingering until a 3 minutes alarm kills them:
pedro 28308 1 0 13:55 ? 00:00:00 /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/outputs/gdb.base/fork-running-state/fork-running-state
pedro 28340 1 0 13:55 ? 00:00:00 /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/outputs/gdb.base/fork-running-state/fork-running-state
pedro 28372 1 0 13:55 ? 00:00:00 /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/outputs/gdb.base/fork-running-state/fork-running-state
pedro 28400 1 0 13:55 ? 00:00:00 /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/outputs/gdb.base/fork-running-state/fork-running-state
pedro 28431 1 0 13:55 ? 00:00:00 /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/outputs/gdb.base/fork-running-state/fork-running-state
pedro 28463 1 0 13:55 ? 00:00:00 /home/pedro/gdb/binutils-gdb/build/gdb/testsuite/outputs/gdb.base/fork-running-state/fork-running-state
Those processes used to kill themselves, but that was changed by
commit f50d8a2eae ("Fix gdb.base/fork-running-state.exp race").
This commit restores the self-killing, but only in the cases gdb won't
try killing the processes, thus avoiding the old race.
(The restored code in fork_parent isn't exactly the same as it was.
In this version, we're exiting immediately when 'wait' returns
success, while in the old version we'd loop again and end up in the
perror call. The output from that perror call is not expected by the
"kill inferior" tests, and would result in a test FAIL.)
gdb/testsuite/ChangeLog:
2018-06-14 Pedro Alves <palves@redhat.com>
* gdb.base/fork-running-state.c: Include <errno.h>.
(exit_if_relative_exits): New.
(fork_child): If 'exit_if_relative_exits' is true, exit if the parent
exits.
(fork_parent): If 'exit_if_relative_exits' is true, exit if the
child exits.
110 lines
2.3 KiB
C
110 lines
2.3 KiB
C
/* This testcase is part of GDB, the GNU debugger.
|
|
|
|
Copyright 2015-2018 Free Software Foundation, Inc.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include <unistd.h>
|
|
#include <stdio.h>
|
|
#include <sys/types.h>
|
|
#include <sys/wait.h>
|
|
#include <errno.h>
|
|
|
|
int save_parent;
|
|
|
|
/* Variable set by GDB. If true, then a fork child (or parent) exits
|
|
if its parent (or child) exits. Otherwise the process waits
|
|
forever until either GDB or the alarm kills it. */
|
|
volatile int exit_if_relative_exits = 0;
|
|
|
|
/* The fork child. Just runs forever. */
|
|
|
|
static int
|
|
fork_child (void)
|
|
{
|
|
/* Don't run forever. */
|
|
alarm (180);
|
|
|
|
while (1)
|
|
{
|
|
if (exit_if_relative_exits)
|
|
{
|
|
sleep (1);
|
|
|
|
/* Exit if GDB kills the parent. */
|
|
if (getppid () != save_parent)
|
|
break;
|
|
if (kill (getppid (), 0) != 0)
|
|
break;
|
|
}
|
|
else
|
|
pause ();
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
/* The fork parent. Just runs forever. */
|
|
|
|
static int
|
|
fork_parent (void)
|
|
{
|
|
/* Don't run forever. */
|
|
alarm (180);
|
|
|
|
while (1)
|
|
{
|
|
if (exit_if_relative_exits)
|
|
{
|
|
int res = wait (NULL);
|
|
if (res == -1 && errno == EINTR)
|
|
continue;
|
|
else if (res == -1)
|
|
{
|
|
perror ("wait");
|
|
return 1;
|
|
}
|
|
else
|
|
return 0;
|
|
}
|
|
else
|
|
pause ();
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int
|
|
main (void)
|
|
{
|
|
pid_t pid;
|
|
|
|
save_parent = getpid ();
|
|
|
|
/* The parent and child should basically run forever without
|
|
tripping on any debug event. We want to check that GDB updates
|
|
the parent and child running states correctly right after the
|
|
fork. */
|
|
pid = fork ();
|
|
if (pid > 0)
|
|
return fork_parent ();
|
|
else if (pid == 0)
|
|
return fork_child ();
|
|
else
|
|
{
|
|
perror ("fork");
|
|
return 1;
|
|
}
|
|
}
|