mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-21 04:42:53 +08:00
d82b3862f1
As mentioned here: https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Avoid_non-const_reference_parameters.2C_use_pointers_instead we prefer to avoid non-const references. This patch changes the non-const references I could find in the compile/ directory, either by making them rvalue-reference (&&) or changing them to pointers. I'd say all the changes are pretty obvious, except the one in compile_cplus_instance::enter_scope which might require more attention. gdb/ChangeLog: * compile/compile-c.h (generate_c_for_variable_locations): Change reference to pointer. * compile/compile-c-support.c (compile_program) <compute>: Likewise. * compile/compile-c-symbols.c (generate_vla_size): Likewise. (generate_c_for_for_one_variable): Likewise (generate_c_for_variable_locations): Likewise * compile/compile-c-types.c (compile_c_instance::convert_type): Likewise * compile/compile-cplus-symbols.c (convert_one_symbol): std::move the scope passed to enter_scope. * compile/compile-cplus-types.c (compile_cplus_instance::enter_scope): Make parameter rvalue-reference. (compile_cplus_instance::new_scope): Change reference to pointer. (compile_cplus_instance::convert_type): Likewise (compile_cplus_convert_typedef): std::move the scope passed to enter_scope. (compile_cplus_convert_struct_or_union): Likewise. (compile_cplus_convert_enum): Likewise. (compile_cplus_convert_namespace): Likewise. * compile/compile-cplus.h (compile_cplus_instance) <enter_scope>: Make parameter rvalue-reference. * compile/compile-internal.h (compile_instance) <get_cached_type>: Likewise * compile/compile-loc2c.c (push): Likewise (pushf): Likewise (unary): Likewise (binary): Likewise (print_label): Likewise (pushf_register_address): Likewise (pushf_register): Likewise (do_compile_dwarf_expr_to_c): Likewise (compile_dwarf_expr_to_c): Likewise (compile_dwarf_bounds_to_c): Likewise * compile/compile.c (compile_instance::get_cached_type): Likewise * compile/compile.h (compile_dwarf_expr_to_c): Likewise. (compile_dwarf_bounds_to_c): Likewise * dwarf2loc.c (locexpr_generate_c_location): Likewise. (dwarf2_compile_property_to_c): Likewise * dwarf2loc.h (dwarf2_compile_property_to_c): Likewise * symtab.h (struct symbol_computed_ops) <generate_c_location>: Likewise
107 lines
3.5 KiB
C
107 lines
3.5 KiB
C
/* Header file for Compile and inject module.
|
|
|
|
Copyright (C) 2014-2018 Free Software Foundation, Inc.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef GDB_COMPILE_H
|
|
#define GDB_COMPILE_H
|
|
|
|
struct ui_file;
|
|
struct gdbarch;
|
|
struct dwarf2_per_cu_data;
|
|
struct symbol;
|
|
struct dynamic_prop;
|
|
|
|
/* Public function that is called from compile_control case in the
|
|
expression command. GDB returns either a CMD, or a CMD_STRING, but
|
|
never both. */
|
|
|
|
extern void eval_compile_command (struct command_line *cmd,
|
|
const char *cmd_string,
|
|
enum compile_i_scope_types scope,
|
|
void *scope_data);
|
|
|
|
/* Compile a DWARF location expression to C, suitable for use by the
|
|
compiler.
|
|
|
|
STREAM is the stream where the code should be written.
|
|
|
|
RESULT_NAME is the name of a variable in the resulting C code. The
|
|
result of the expression will be assigned to this variable.
|
|
|
|
SYM is the symbol corresponding to this expression.
|
|
PC is the location at which the expression is being evaluated.
|
|
ARCH is the architecture to use.
|
|
|
|
REGISTERS_USED is an out parameter which is updated to note which
|
|
registers were needed by this expression.
|
|
|
|
ADDR_SIZE is the DWARF address size to use.
|
|
|
|
OPT_PTR and OP_END are the bounds of the DWARF expression.
|
|
|
|
PER_CU is the per-CU object used for looking up various other
|
|
things. */
|
|
|
|
extern void compile_dwarf_expr_to_c (string_file *stream,
|
|
const char *result_name,
|
|
struct symbol *sym,
|
|
CORE_ADDR pc,
|
|
struct gdbarch *arch,
|
|
unsigned char *registers_used,
|
|
unsigned int addr_size,
|
|
const gdb_byte *op_ptr,
|
|
const gdb_byte *op_end,
|
|
struct dwarf2_per_cu_data *per_cu);
|
|
|
|
/* Compile a DWARF bounds expression to C, suitable for use by the
|
|
compiler.
|
|
|
|
STREAM is the stream where the code should be written.
|
|
|
|
RESULT_NAME is the name of a variable in the resulting C code. The
|
|
result of the expression will be assigned to this variable.
|
|
|
|
PROP is the dynamic property for which we're compiling.
|
|
|
|
SYM is the symbol corresponding to this expression.
|
|
PC is the location at which the expression is being evaluated.
|
|
ARCH is the architecture to use.
|
|
|
|
REGISTERS_USED is an out parameter which is updated to note which
|
|
registers were needed by this expression.
|
|
|
|
ADDR_SIZE is the DWARF address size to use.
|
|
|
|
OPT_PTR and OP_END are the bounds of the DWARF expression.
|
|
|
|
PER_CU is the per-CU object used for looking up various other
|
|
things. */
|
|
|
|
extern void compile_dwarf_bounds_to_c (string_file *stream,
|
|
const char *result_name,
|
|
const struct dynamic_prop *prop,
|
|
struct symbol *sym, CORE_ADDR pc,
|
|
struct gdbarch *arch,
|
|
unsigned char *registers_used,
|
|
unsigned int addr_size,
|
|
const gdb_byte *op_ptr,
|
|
const gdb_byte *op_end,
|
|
struct dwarf2_per_cu_data *per_cu);
|
|
|
|
extern void compile_print_value (struct value *val, void *data_voidp);
|
|
|
|
#endif /* GDB_COMPILE_H */
|