mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-06 12:09:26 +08:00
dda83cd783
Many spots incorrectly use only spaces for indentation (for example, there are a lot of spots in ada-lang.c). I've always found it awkward when I needed to edit one of these spots: do I keep the original wrong indentation, or do I fix it? What if the lines around it are also wrong, do I fix them too? I probably don't want to fix them in the same patch, to avoid adding noise to my patch. So I propose to fix as much as possible once and for all (hopefully). One typical counter argument for this is that it makes code archeology more difficult, because git-blame will show this commit as the last change for these lines. My counter counter argument is: when git-blaming, you often need to do "blame the file at the parent commit" anyway, to go past some other refactor that touched the line you are interested in, but is not the change you are looking for. So you already need a somewhat efficient way to do this. Using some interactive tool, rather than plain git-blame, makes this trivial. For example, I use "tig blame <file>", where going back past the commit that changed the currently selected line is one keystroke. It looks like Magit in Emacs does it too (though I've never used it). Web viewers of Github and Gitlab do it too. My point is that it won't really make archeology more difficult. The other typical counter argument is that it will cause conflicts with existing patches. That's true... but it's a one time cost, and those are not conflicts that are difficult to resolve. I have also tried "git rebase --ignore-whitespace", it seems to work well. Although that will re-introduce the faulty indentation, so one needs to take care of fixing the indentation in the patch after that (which is easy). gdb/ChangeLog: * aarch64-linux-tdep.c: Fix indentation. * aarch64-ravenscar-thread.c: Fix indentation. * aarch64-tdep.c: Fix indentation. * aarch64-tdep.h: Fix indentation. * ada-lang.c: Fix indentation. * ada-lang.h: Fix indentation. * ada-tasks.c: Fix indentation. * ada-typeprint.c: Fix indentation. * ada-valprint.c: Fix indentation. * ada-varobj.c: Fix indentation. * addrmap.c: Fix indentation. * addrmap.h: Fix indentation. * agent.c: Fix indentation. * aix-thread.c: Fix indentation. * alpha-bsd-nat.c: Fix indentation. * alpha-linux-tdep.c: Fix indentation. * alpha-mdebug-tdep.c: Fix indentation. * alpha-nbsd-tdep.c: Fix indentation. * alpha-obsd-tdep.c: Fix indentation. * alpha-tdep.c: Fix indentation. * amd64-bsd-nat.c: Fix indentation. * amd64-darwin-tdep.c: Fix indentation. * amd64-linux-nat.c: Fix indentation. * amd64-linux-tdep.c: Fix indentation. * amd64-nat.c: Fix indentation. * amd64-obsd-tdep.c: Fix indentation. * amd64-tdep.c: Fix indentation. * amd64-windows-tdep.c: Fix indentation. * annotate.c: Fix indentation. * arc-tdep.c: Fix indentation. * arch-utils.c: Fix indentation. * arch/arm-get-next-pcs.c: Fix indentation. * arch/arm.c: Fix indentation. * arm-linux-nat.c: Fix indentation. * arm-linux-tdep.c: Fix indentation. * arm-nbsd-tdep.c: Fix indentation. * arm-pikeos-tdep.c: Fix indentation. * arm-tdep.c: Fix indentation. * arm-tdep.h: Fix indentation. * arm-wince-tdep.c: Fix indentation. * auto-load.c: Fix indentation. * auxv.c: Fix indentation. * avr-tdep.c: Fix indentation. * ax-gdb.c: Fix indentation. * ax-general.c: Fix indentation. * bfin-linux-tdep.c: Fix indentation. * block.c: Fix indentation. * block.h: Fix indentation. * blockframe.c: Fix indentation. * bpf-tdep.c: Fix indentation. * break-catch-sig.c: Fix indentation. * break-catch-syscall.c: Fix indentation. * break-catch-throw.c: Fix indentation. * breakpoint.c: Fix indentation. * breakpoint.h: Fix indentation. * bsd-uthread.c: Fix indentation. * btrace.c: Fix indentation. * build-id.c: Fix indentation. * buildsym-legacy.h: Fix indentation. * buildsym.c: Fix indentation. * c-typeprint.c: Fix indentation. * c-valprint.c: Fix indentation. * c-varobj.c: Fix indentation. * charset.c: Fix indentation. * cli/cli-cmds.c: Fix indentation. * cli/cli-decode.c: Fix indentation. * cli/cli-decode.h: Fix indentation. * cli/cli-script.c: Fix indentation. * cli/cli-setshow.c: Fix indentation. * coff-pe-read.c: Fix indentation. * coffread.c: Fix indentation. * compile/compile-cplus-types.c: Fix indentation. * compile/compile-object-load.c: Fix indentation. * compile/compile-object-run.c: Fix indentation. * completer.c: Fix indentation. * corefile.c: Fix indentation. * corelow.c: Fix indentation. * cp-abi.h: Fix indentation. * cp-namespace.c: Fix indentation. * cp-support.c: Fix indentation. * cp-valprint.c: Fix indentation. * cris-linux-tdep.c: Fix indentation. * cris-tdep.c: Fix indentation. * darwin-nat-info.c: Fix indentation. * darwin-nat.c: Fix indentation. * darwin-nat.h: Fix indentation. * dbxread.c: Fix indentation. * dcache.c: Fix indentation. * disasm.c: Fix indentation. * dtrace-probe.c: Fix indentation. * dwarf2/abbrev.c: Fix indentation. * dwarf2/attribute.c: Fix indentation. * dwarf2/expr.c: Fix indentation. * dwarf2/frame.c: Fix indentation. * dwarf2/index-cache.c: Fix indentation. * dwarf2/index-write.c: Fix indentation. * dwarf2/line-header.c: Fix indentation. * dwarf2/loc.c: Fix indentation. * dwarf2/macro.c: Fix indentation. * dwarf2/read.c: Fix indentation. * dwarf2/read.h: Fix indentation. * elfread.c: Fix indentation. * eval.c: Fix indentation. * event-top.c: Fix indentation. * exec.c: Fix indentation. * exec.h: Fix indentation. * expprint.c: Fix indentation. * f-lang.c: Fix indentation. * f-typeprint.c: Fix indentation. * f-valprint.c: Fix indentation. * fbsd-nat.c: Fix indentation. * fbsd-tdep.c: Fix indentation. * findvar.c: Fix indentation. * fork-child.c: Fix indentation. * frame-unwind.c: Fix indentation. * frame-unwind.h: Fix indentation. * frame.c: Fix indentation. * frv-linux-tdep.c: Fix indentation. * frv-tdep.c: Fix indentation. * frv-tdep.h: Fix indentation. * ft32-tdep.c: Fix indentation. * gcore.c: Fix indentation. * gdb_bfd.c: Fix indentation. * gdbarch.sh: Fix indentation. * gdbarch.c: Re-generate * gdbarch.h: Re-generate. * gdbcore.h: Fix indentation. * gdbthread.h: Fix indentation. * gdbtypes.c: Fix indentation. * gdbtypes.h: Fix indentation. * glibc-tdep.c: Fix indentation. * gnu-nat.c: Fix indentation. * gnu-nat.h: Fix indentation. * gnu-v2-abi.c: Fix indentation. * gnu-v3-abi.c: Fix indentation. * go32-nat.c: Fix indentation. * guile/guile-internal.h: Fix indentation. * guile/scm-cmd.c: Fix indentation. * guile/scm-frame.c: Fix indentation. * guile/scm-iterator.c: Fix indentation. * guile/scm-math.c: Fix indentation. * guile/scm-ports.c: Fix indentation. * guile/scm-pretty-print.c: Fix indentation. * guile/scm-value.c: Fix indentation. * h8300-tdep.c: Fix indentation. * hppa-linux-nat.c: Fix indentation. * hppa-linux-tdep.c: Fix indentation. * hppa-nbsd-nat.c: Fix indentation. * hppa-nbsd-tdep.c: Fix indentation. * hppa-obsd-nat.c: Fix indentation. * hppa-tdep.c: Fix indentation. * hppa-tdep.h: Fix indentation. * i386-bsd-nat.c: Fix indentation. * i386-darwin-nat.c: Fix indentation. * i386-darwin-tdep.c: Fix indentation. * i386-dicos-tdep.c: Fix indentation. * i386-gnu-nat.c: Fix indentation. * i386-linux-nat.c: Fix indentation. * i386-linux-tdep.c: Fix indentation. * i386-nto-tdep.c: Fix indentation. * i386-obsd-tdep.c: Fix indentation. * i386-sol2-nat.c: Fix indentation. * i386-tdep.c: Fix indentation. * i386-tdep.h: Fix indentation. * i386-windows-tdep.c: Fix indentation. * i387-tdep.c: Fix indentation. * i387-tdep.h: Fix indentation. * ia64-libunwind-tdep.c: Fix indentation. * ia64-libunwind-tdep.h: Fix indentation. * ia64-linux-nat.c: Fix indentation. * ia64-linux-tdep.c: Fix indentation. * ia64-tdep.c: Fix indentation. * ia64-tdep.h: Fix indentation. * ia64-vms-tdep.c: Fix indentation. * infcall.c: Fix indentation. * infcmd.c: Fix indentation. * inferior.c: Fix indentation. * infrun.c: Fix indentation. * iq2000-tdep.c: Fix indentation. * language.c: Fix indentation. * linespec.c: Fix indentation. * linux-fork.c: Fix indentation. * linux-nat.c: Fix indentation. * linux-tdep.c: Fix indentation. * linux-thread-db.c: Fix indentation. * lm32-tdep.c: Fix indentation. * m2-lang.c: Fix indentation. * m2-typeprint.c: Fix indentation. * m2-valprint.c: Fix indentation. * m32c-tdep.c: Fix indentation. * m32r-linux-tdep.c: Fix indentation. * m32r-tdep.c: Fix indentation. * m68hc11-tdep.c: Fix indentation. * m68k-bsd-nat.c: Fix indentation. * m68k-linux-nat.c: Fix indentation. * m68k-linux-tdep.c: Fix indentation. * m68k-tdep.c: Fix indentation. * machoread.c: Fix indentation. * macrocmd.c: Fix indentation. * macroexp.c: Fix indentation. * macroscope.c: Fix indentation. * macrotab.c: Fix indentation. * macrotab.h: Fix indentation. * main.c: Fix indentation. * mdebugread.c: Fix indentation. * mep-tdep.c: Fix indentation. * mi/mi-cmd-catch.c: Fix indentation. * mi/mi-cmd-disas.c: Fix indentation. * mi/mi-cmd-env.c: Fix indentation. * mi/mi-cmd-stack.c: Fix indentation. * mi/mi-cmd-var.c: Fix indentation. * mi/mi-cmds.c: Fix indentation. * mi/mi-main.c: Fix indentation. * mi/mi-parse.c: Fix indentation. * microblaze-tdep.c: Fix indentation. * minidebug.c: Fix indentation. * minsyms.c: Fix indentation. * mips-linux-nat.c: Fix indentation. * mips-linux-tdep.c: Fix indentation. * mips-nbsd-tdep.c: Fix indentation. * mips-tdep.c: Fix indentation. * mn10300-linux-tdep.c: Fix indentation. * mn10300-tdep.c: Fix indentation. * moxie-tdep.c: Fix indentation. * msp430-tdep.c: Fix indentation. * namespace.h: Fix indentation. * nat/fork-inferior.c: Fix indentation. * nat/gdb_ptrace.h: Fix indentation. * nat/linux-namespaces.c: Fix indentation. * nat/linux-osdata.c: Fix indentation. * nat/netbsd-nat.c: Fix indentation. * nat/x86-dregs.c: Fix indentation. * nbsd-nat.c: Fix indentation. * nbsd-tdep.c: Fix indentation. * nios2-linux-tdep.c: Fix indentation. * nios2-tdep.c: Fix indentation. * nto-procfs.c: Fix indentation. * nto-tdep.c: Fix indentation. * objfiles.c: Fix indentation. * objfiles.h: Fix indentation. * opencl-lang.c: Fix indentation. * or1k-tdep.c: Fix indentation. * osabi.c: Fix indentation. * osabi.h: Fix indentation. * osdata.c: Fix indentation. * p-lang.c: Fix indentation. * p-typeprint.c: Fix indentation. * p-valprint.c: Fix indentation. * parse.c: Fix indentation. * ppc-linux-nat.c: Fix indentation. * ppc-linux-tdep.c: Fix indentation. * ppc-nbsd-nat.c: Fix indentation. * ppc-nbsd-tdep.c: Fix indentation. * ppc-obsd-nat.c: Fix indentation. * ppc-ravenscar-thread.c: Fix indentation. * ppc-sysv-tdep.c: Fix indentation. * ppc64-tdep.c: Fix indentation. * printcmd.c: Fix indentation. * proc-api.c: Fix indentation. * producer.c: Fix indentation. * producer.h: Fix indentation. * prologue-value.c: Fix indentation. * prologue-value.h: Fix indentation. * psymtab.c: Fix indentation. * python/py-arch.c: Fix indentation. * python/py-bpevent.c: Fix indentation. * python/py-event.c: Fix indentation. * python/py-event.h: Fix indentation. * python/py-finishbreakpoint.c: Fix indentation. * python/py-frame.c: Fix indentation. * python/py-framefilter.c: Fix indentation. * python/py-inferior.c: Fix indentation. * python/py-infthread.c: Fix indentation. * python/py-objfile.c: Fix indentation. * python/py-prettyprint.c: Fix indentation. * python/py-registers.c: Fix indentation. * python/py-signalevent.c: Fix indentation. * python/py-stopevent.c: Fix indentation. * python/py-stopevent.h: Fix indentation. * python/py-threadevent.c: Fix indentation. * python/py-tui.c: Fix indentation. * python/py-unwind.c: Fix indentation. * python/py-value.c: Fix indentation. * python/py-xmethods.c: Fix indentation. * python/python-internal.h: Fix indentation. * python/python.c: Fix indentation. * ravenscar-thread.c: Fix indentation. * record-btrace.c: Fix indentation. * record-full.c: Fix indentation. * record.c: Fix indentation. * reggroups.c: Fix indentation. * regset.h: Fix indentation. * remote-fileio.c: Fix indentation. * remote.c: Fix indentation. * reverse.c: Fix indentation. * riscv-linux-tdep.c: Fix indentation. * riscv-ravenscar-thread.c: Fix indentation. * riscv-tdep.c: Fix indentation. * rl78-tdep.c: Fix indentation. * rs6000-aix-tdep.c: Fix indentation. * rs6000-lynx178-tdep.c: Fix indentation. * rs6000-nat.c: Fix indentation. * rs6000-tdep.c: Fix indentation. * rust-lang.c: Fix indentation. * rx-tdep.c: Fix indentation. * s12z-tdep.c: Fix indentation. * s390-linux-tdep.c: Fix indentation. * score-tdep.c: Fix indentation. * ser-base.c: Fix indentation. * ser-mingw.c: Fix indentation. * ser-uds.c: Fix indentation. * ser-unix.c: Fix indentation. * serial.c: Fix indentation. * sh-linux-tdep.c: Fix indentation. * sh-nbsd-tdep.c: Fix indentation. * sh-tdep.c: Fix indentation. * skip.c: Fix indentation. * sol-thread.c: Fix indentation. * solib-aix.c: Fix indentation. * solib-darwin.c: Fix indentation. * solib-frv.c: Fix indentation. * solib-svr4.c: Fix indentation. * solib.c: Fix indentation. * source.c: Fix indentation. * sparc-linux-tdep.c: Fix indentation. * sparc-nbsd-tdep.c: Fix indentation. * sparc-obsd-tdep.c: Fix indentation. * sparc-ravenscar-thread.c: Fix indentation. * sparc-tdep.c: Fix indentation. * sparc64-linux-tdep.c: Fix indentation. * sparc64-nbsd-tdep.c: Fix indentation. * sparc64-obsd-tdep.c: Fix indentation. * sparc64-tdep.c: Fix indentation. * stabsread.c: Fix indentation. * stack.c: Fix indentation. * stap-probe.c: Fix indentation. * stubs/ia64vms-stub.c: Fix indentation. * stubs/m32r-stub.c: Fix indentation. * stubs/m68k-stub.c: Fix indentation. * stubs/sh-stub.c: Fix indentation. * stubs/sparc-stub.c: Fix indentation. * symfile-mem.c: Fix indentation. * symfile.c: Fix indentation. * symfile.h: Fix indentation. * symmisc.c: Fix indentation. * symtab.c: Fix indentation. * symtab.h: Fix indentation. * target-float.c: Fix indentation. * target.c: Fix indentation. * target.h: Fix indentation. * tic6x-tdep.c: Fix indentation. * tilegx-linux-tdep.c: Fix indentation. * tilegx-tdep.c: Fix indentation. * top.c: Fix indentation. * tracefile-tfile.c: Fix indentation. * tracepoint.c: Fix indentation. * tui/tui-disasm.c: Fix indentation. * tui/tui-io.c: Fix indentation. * tui/tui-regs.c: Fix indentation. * tui/tui-stack.c: Fix indentation. * tui/tui-win.c: Fix indentation. * tui/tui-winsource.c: Fix indentation. * tui/tui.c: Fix indentation. * typeprint.c: Fix indentation. * ui-out.h: Fix indentation. * unittests/copy_bitwise-selftests.c: Fix indentation. * unittests/memory-map-selftests.c: Fix indentation. * utils.c: Fix indentation. * v850-tdep.c: Fix indentation. * valarith.c: Fix indentation. * valops.c: Fix indentation. * valprint.c: Fix indentation. * valprint.h: Fix indentation. * value.c: Fix indentation. * value.h: Fix indentation. * varobj.c: Fix indentation. * vax-tdep.c: Fix indentation. * windows-nat.c: Fix indentation. * windows-tdep.c: Fix indentation. * xcoffread.c: Fix indentation. * xml-syscall.c: Fix indentation. * xml-tdesc.c: Fix indentation. * xstormy16-tdep.c: Fix indentation. * xtensa-config.c: Fix indentation. * xtensa-linux-nat.c: Fix indentation. * xtensa-linux-tdep.c: Fix indentation. * xtensa-tdep.c: Fix indentation. gdbserver/ChangeLog: * ax.cc: Fix indentation. * dll.cc: Fix indentation. * inferiors.h: Fix indentation. * linux-low.cc: Fix indentation. * linux-nios2-low.cc: Fix indentation. * linux-ppc-ipa.cc: Fix indentation. * linux-ppc-low.cc: Fix indentation. * linux-x86-low.cc: Fix indentation. * linux-xtensa-low.cc: Fix indentation. * regcache.cc: Fix indentation. * server.cc: Fix indentation. * tracepoint.cc: Fix indentation. gdbsupport/ChangeLog: * common-exceptions.h: Fix indentation. * event-loop.cc: Fix indentation. * fileio.cc: Fix indentation. * filestuff.cc: Fix indentation. * gdb-dlfcn.cc: Fix indentation. * gdb_string_view.h: Fix indentation. * job-control.cc: Fix indentation. * signals.cc: Fix indentation. Change-Id: I4bad7ae6be0fbe14168b8ebafb98ffe14964a695
621 lines
18 KiB
C
621 lines
18 KiB
C
/* Everything about syscall catchpoints, for GDB.
|
|
|
|
Copyright (C) 2009-2020 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include <ctype.h>
|
|
#include "breakpoint.h"
|
|
#include "gdbcmd.h"
|
|
#include "inferior.h"
|
|
#include "cli/cli-utils.h"
|
|
#include "annotate.h"
|
|
#include "mi/mi-common.h"
|
|
#include "valprint.h"
|
|
#include "arch-utils.h"
|
|
#include "observable.h"
|
|
#include "xml-syscall.h"
|
|
#include "cli/cli-style.h"
|
|
|
|
/* An instance of this type is used to represent a syscall catchpoint.
|
|
A breakpoint is really of this type iff its ops pointer points to
|
|
CATCH_SYSCALL_BREAKPOINT_OPS. */
|
|
|
|
struct syscall_catchpoint : public breakpoint
|
|
{
|
|
/* Syscall numbers used for the 'catch syscall' feature. If no
|
|
syscall has been specified for filtering, it is empty.
|
|
Otherwise, it holds a list of all syscalls to be caught. */
|
|
std::vector<int> syscalls_to_be_caught;
|
|
};
|
|
|
|
struct catch_syscall_inferior_data
|
|
{
|
|
/* We keep a count of the number of times the user has requested a
|
|
particular syscall to be tracked, and pass this information to the
|
|
target. This lets capable targets implement filtering directly. */
|
|
|
|
/* Number of times that "any" syscall is requested. */
|
|
int any_syscall_count;
|
|
|
|
/* Count of each system call. */
|
|
std::vector<int> syscalls_counts;
|
|
|
|
/* This counts all syscall catch requests, so we can readily determine
|
|
if any catching is necessary. */
|
|
int total_syscalls_count;
|
|
};
|
|
|
|
static const struct inferior_key<struct catch_syscall_inferior_data>
|
|
catch_syscall_inferior_data;
|
|
|
|
static struct catch_syscall_inferior_data *
|
|
get_catch_syscall_inferior_data (struct inferior *inf)
|
|
{
|
|
struct catch_syscall_inferior_data *inf_data;
|
|
|
|
inf_data = catch_syscall_inferior_data.get (inf);
|
|
if (inf_data == NULL)
|
|
inf_data = catch_syscall_inferior_data.emplace (inf);
|
|
|
|
return inf_data;
|
|
}
|
|
|
|
/* Implement the "insert" breakpoint_ops method for syscall
|
|
catchpoints. */
|
|
|
|
static int
|
|
insert_catch_syscall (struct bp_location *bl)
|
|
{
|
|
struct syscall_catchpoint *c = (struct syscall_catchpoint *) bl->owner;
|
|
struct inferior *inf = current_inferior ();
|
|
struct catch_syscall_inferior_data *inf_data
|
|
= get_catch_syscall_inferior_data (inf);
|
|
|
|
++inf_data->total_syscalls_count;
|
|
if (c->syscalls_to_be_caught.empty ())
|
|
++inf_data->any_syscall_count;
|
|
else
|
|
{
|
|
for (int iter : c->syscalls_to_be_caught)
|
|
{
|
|
if (iter >= inf_data->syscalls_counts.size ())
|
|
inf_data->syscalls_counts.resize (iter + 1);
|
|
++inf_data->syscalls_counts[iter];
|
|
}
|
|
}
|
|
|
|
return target_set_syscall_catchpoint (inferior_ptid.pid (),
|
|
inf_data->total_syscalls_count != 0,
|
|
inf_data->any_syscall_count,
|
|
inf_data->syscalls_counts);
|
|
}
|
|
|
|
/* Implement the "remove" breakpoint_ops method for syscall
|
|
catchpoints. */
|
|
|
|
static int
|
|
remove_catch_syscall (struct bp_location *bl, enum remove_bp_reason reason)
|
|
{
|
|
struct syscall_catchpoint *c = (struct syscall_catchpoint *) bl->owner;
|
|
struct inferior *inf = current_inferior ();
|
|
struct catch_syscall_inferior_data *inf_data
|
|
= get_catch_syscall_inferior_data (inf);
|
|
|
|
--inf_data->total_syscalls_count;
|
|
if (c->syscalls_to_be_caught.empty ())
|
|
--inf_data->any_syscall_count;
|
|
else
|
|
{
|
|
for (int iter : c->syscalls_to_be_caught)
|
|
{
|
|
if (iter >= inf_data->syscalls_counts.size ())
|
|
/* Shouldn't happen. */
|
|
continue;
|
|
--inf_data->syscalls_counts[iter];
|
|
}
|
|
}
|
|
|
|
return target_set_syscall_catchpoint (inferior_ptid.pid (),
|
|
inf_data->total_syscalls_count != 0,
|
|
inf_data->any_syscall_count,
|
|
inf_data->syscalls_counts);
|
|
}
|
|
|
|
/* Implement the "breakpoint_hit" breakpoint_ops method for syscall
|
|
catchpoints. */
|
|
|
|
static int
|
|
breakpoint_hit_catch_syscall (const struct bp_location *bl,
|
|
const address_space *aspace, CORE_ADDR bp_addr,
|
|
const struct target_waitstatus *ws)
|
|
{
|
|
/* We must check if we are catching specific syscalls in this
|
|
breakpoint. If we are, then we must guarantee that the called
|
|
syscall is the same syscall we are catching. */
|
|
int syscall_number = 0;
|
|
const struct syscall_catchpoint *c
|
|
= (const struct syscall_catchpoint *) bl->owner;
|
|
|
|
if (ws->kind != TARGET_WAITKIND_SYSCALL_ENTRY
|
|
&& ws->kind != TARGET_WAITKIND_SYSCALL_RETURN)
|
|
return 0;
|
|
|
|
syscall_number = ws->value.syscall_number;
|
|
|
|
/* Now, checking if the syscall is the same. */
|
|
if (!c->syscalls_to_be_caught.empty ())
|
|
{
|
|
for (int iter : c->syscalls_to_be_caught)
|
|
if (syscall_number == iter)
|
|
return 1;
|
|
|
|
return 0;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
/* Implement the "print_it" breakpoint_ops method for syscall
|
|
catchpoints. */
|
|
|
|
static enum print_stop_action
|
|
print_it_catch_syscall (bpstat bs)
|
|
{
|
|
struct ui_out *uiout = current_uiout;
|
|
struct breakpoint *b = bs->breakpoint_at;
|
|
/* These are needed because we want to know in which state a
|
|
syscall is. It can be in the TARGET_WAITKIND_SYSCALL_ENTRY
|
|
or TARGET_WAITKIND_SYSCALL_RETURN, and depending on it we
|
|
must print "called syscall" or "returned from syscall". */
|
|
struct target_waitstatus last;
|
|
struct syscall s;
|
|
struct gdbarch *gdbarch = bs->bp_location_at->gdbarch;
|
|
|
|
get_last_target_status (nullptr, nullptr, &last);
|
|
|
|
get_syscall_by_number (gdbarch, last.value.syscall_number, &s);
|
|
|
|
annotate_catchpoint (b->number);
|
|
maybe_print_thread_hit_breakpoint (uiout);
|
|
|
|
if (b->disposition == disp_del)
|
|
uiout->text ("Temporary catchpoint ");
|
|
else
|
|
uiout->text ("Catchpoint ");
|
|
if (uiout->is_mi_like_p ())
|
|
{
|
|
uiout->field_string ("reason",
|
|
async_reason_lookup (last.kind == TARGET_WAITKIND_SYSCALL_ENTRY
|
|
? EXEC_ASYNC_SYSCALL_ENTRY
|
|
: EXEC_ASYNC_SYSCALL_RETURN));
|
|
uiout->field_string ("disp", bpdisp_text (b->disposition));
|
|
}
|
|
uiout->field_signed ("bkptno", b->number);
|
|
|
|
if (last.kind == TARGET_WAITKIND_SYSCALL_ENTRY)
|
|
uiout->text (" (call to syscall ");
|
|
else
|
|
uiout->text (" (returned from syscall ");
|
|
|
|
if (s.name == NULL || uiout->is_mi_like_p ())
|
|
uiout->field_signed ("syscall-number", last.value.syscall_number);
|
|
if (s.name != NULL)
|
|
uiout->field_string ("syscall-name", s.name);
|
|
|
|
uiout->text ("), ");
|
|
|
|
return PRINT_SRC_AND_LOC;
|
|
}
|
|
|
|
/* Implement the "print_one" breakpoint_ops method for syscall
|
|
catchpoints. */
|
|
|
|
static void
|
|
print_one_catch_syscall (struct breakpoint *b,
|
|
struct bp_location **last_loc)
|
|
{
|
|
struct syscall_catchpoint *c = (struct syscall_catchpoint *) b;
|
|
struct value_print_options opts;
|
|
struct ui_out *uiout = current_uiout;
|
|
struct gdbarch *gdbarch = b->loc->gdbarch;
|
|
|
|
get_user_print_options (&opts);
|
|
/* Field 4, the address, is omitted (which makes the columns not
|
|
line up too nicely with the headers, but the effect is relatively
|
|
readable). */
|
|
if (opts.addressprint)
|
|
uiout->field_skip ("addr");
|
|
annotate_field (5);
|
|
|
|
if (c->syscalls_to_be_caught.size () > 1)
|
|
uiout->text ("syscalls \"");
|
|
else
|
|
uiout->text ("syscall \"");
|
|
|
|
if (!c->syscalls_to_be_caught.empty ())
|
|
{
|
|
char *text = xstrprintf ("%s", "");
|
|
|
|
for (int iter : c->syscalls_to_be_caught)
|
|
{
|
|
char *previous_text = text;
|
|
struct syscall s;
|
|
get_syscall_by_number (gdbarch, iter, &s);
|
|
|
|
if (s.name != NULL)
|
|
text = xstrprintf ("%s%s, ", text, s.name);
|
|
else
|
|
text = xstrprintf ("%s%d, ", text, iter);
|
|
|
|
/* We have to xfree previous_text because xstrprintf dynamically
|
|
allocates new space for text on every call. */
|
|
xfree (previous_text);
|
|
}
|
|
/* Remove the last comma. */
|
|
text[strlen (text) - 2] = '\0';
|
|
uiout->field_string ("what", text);
|
|
/* xfree last text. */
|
|
xfree (text);
|
|
}
|
|
else
|
|
uiout->field_string ("what", "<any syscall>", metadata_style.style ());
|
|
uiout->text ("\" ");
|
|
|
|
if (uiout->is_mi_like_p ())
|
|
uiout->field_string ("catch-type", "syscall");
|
|
}
|
|
|
|
/* Implement the "print_mention" breakpoint_ops method for syscall
|
|
catchpoints. */
|
|
|
|
static void
|
|
print_mention_catch_syscall (struct breakpoint *b)
|
|
{
|
|
struct syscall_catchpoint *c = (struct syscall_catchpoint *) b;
|
|
struct gdbarch *gdbarch = b->loc->gdbarch;
|
|
|
|
if (!c->syscalls_to_be_caught.empty ())
|
|
{
|
|
if (c->syscalls_to_be_caught.size () > 1)
|
|
printf_filtered (_("Catchpoint %d (syscalls"), b->number);
|
|
else
|
|
printf_filtered (_("Catchpoint %d (syscall"), b->number);
|
|
|
|
for (int iter : c->syscalls_to_be_caught)
|
|
{
|
|
struct syscall s;
|
|
get_syscall_by_number (gdbarch, iter, &s);
|
|
|
|
if (s.name != NULL)
|
|
printf_filtered (" '%s' [%d]", s.name, s.number);
|
|
else
|
|
printf_filtered (" %d", s.number);
|
|
}
|
|
printf_filtered (")");
|
|
}
|
|
else
|
|
printf_filtered (_("Catchpoint %d (any syscall)"),
|
|
b->number);
|
|
}
|
|
|
|
/* Implement the "print_recreate" breakpoint_ops method for syscall
|
|
catchpoints. */
|
|
|
|
static void
|
|
print_recreate_catch_syscall (struct breakpoint *b, struct ui_file *fp)
|
|
{
|
|
struct syscall_catchpoint *c = (struct syscall_catchpoint *) b;
|
|
struct gdbarch *gdbarch = b->loc->gdbarch;
|
|
|
|
fprintf_unfiltered (fp, "catch syscall");
|
|
|
|
for (int iter : c->syscalls_to_be_caught)
|
|
{
|
|
struct syscall s;
|
|
|
|
get_syscall_by_number (gdbarch, iter, &s);
|
|
if (s.name != NULL)
|
|
fprintf_unfiltered (fp, " %s", s.name);
|
|
else
|
|
fprintf_unfiltered (fp, " %d", s.number);
|
|
}
|
|
|
|
print_recreate_thread (b, fp);
|
|
}
|
|
|
|
/* The breakpoint_ops structure to be used in syscall catchpoints. */
|
|
|
|
static struct breakpoint_ops catch_syscall_breakpoint_ops;
|
|
|
|
/* Returns non-zero if 'b' is a syscall catchpoint. */
|
|
|
|
static int
|
|
syscall_catchpoint_p (struct breakpoint *b)
|
|
{
|
|
return (b->ops == &catch_syscall_breakpoint_ops);
|
|
}
|
|
|
|
static void
|
|
create_syscall_event_catchpoint (int tempflag, std::vector<int> &&filter,
|
|
const struct breakpoint_ops *ops)
|
|
{
|
|
struct gdbarch *gdbarch = get_current_arch ();
|
|
|
|
std::unique_ptr<syscall_catchpoint> c (new syscall_catchpoint ());
|
|
init_catchpoint (c.get (), gdbarch, tempflag, NULL, ops);
|
|
c->syscalls_to_be_caught = std::move (filter);
|
|
|
|
install_breakpoint (0, std::move (c), 1);
|
|
}
|
|
|
|
/* Splits the argument using space as delimiter. */
|
|
|
|
static std::vector<int>
|
|
catch_syscall_split_args (const char *arg)
|
|
{
|
|
std::vector<int> result;
|
|
struct gdbarch *gdbarch = target_gdbarch ();
|
|
|
|
while (*arg != '\0')
|
|
{
|
|
int i, syscall_number;
|
|
char *endptr;
|
|
char cur_name[128];
|
|
struct syscall s;
|
|
|
|
/* Skip whitespace. */
|
|
arg = skip_spaces (arg);
|
|
|
|
for (i = 0; i < 127 && arg[i] && !isspace (arg[i]); ++i)
|
|
cur_name[i] = arg[i];
|
|
cur_name[i] = '\0';
|
|
arg += i;
|
|
|
|
/* Check if the user provided a syscall name, group, or a number. */
|
|
syscall_number = (int) strtol (cur_name, &endptr, 0);
|
|
if (*endptr == '\0')
|
|
{
|
|
get_syscall_by_number (gdbarch, syscall_number, &s);
|
|
result.push_back (s.number);
|
|
}
|
|
else if (startswith (cur_name, "g:")
|
|
|| startswith (cur_name, "group:"))
|
|
{
|
|
/* We have a syscall group. Let's expand it into a syscall
|
|
list before inserting. */
|
|
const char *group_name;
|
|
|
|
/* Skip over "g:" and "group:" prefix strings. */
|
|
group_name = strchr (cur_name, ':') + 1;
|
|
|
|
if (!get_syscalls_by_group (gdbarch, group_name, &result))
|
|
error (_("Unknown syscall group '%s'."), group_name);
|
|
}
|
|
else
|
|
{
|
|
/* We have a name. Let's check if it's valid and fetch a
|
|
list of matching numbers. */
|
|
if (!get_syscalls_by_name (gdbarch, cur_name, &result))
|
|
/* Here we have to issue an error instead of a warning,
|
|
because GDB cannot do anything useful if there's no
|
|
syscall number to be caught. */
|
|
error (_("Unknown syscall name '%s'."), cur_name);
|
|
}
|
|
}
|
|
|
|
return result;
|
|
}
|
|
|
|
/* Implement the "catch syscall" command. */
|
|
|
|
static void
|
|
catch_syscall_command_1 (const char *arg, int from_tty,
|
|
struct cmd_list_element *command)
|
|
{
|
|
int tempflag;
|
|
std::vector<int> filter;
|
|
struct syscall s;
|
|
struct gdbarch *gdbarch = get_current_arch ();
|
|
|
|
/* Checking if the feature if supported. */
|
|
if (gdbarch_get_syscall_number_p (gdbarch) == 0)
|
|
error (_("The feature 'catch syscall' is not supported on \
|
|
this architecture yet."));
|
|
|
|
tempflag = get_cmd_context (command) == CATCH_TEMPORARY;
|
|
|
|
arg = skip_spaces (arg);
|
|
|
|
/* We need to do this first "dummy" translation in order
|
|
to get the syscall XML file loaded or, most important,
|
|
to display a warning to the user if there's no XML file
|
|
for his/her architecture. */
|
|
get_syscall_by_number (gdbarch, 0, &s);
|
|
|
|
/* The allowed syntax is:
|
|
catch syscall
|
|
catch syscall <name | number> [<name | number> ... <name | number>]
|
|
|
|
Let's check if there's a syscall name. */
|
|
|
|
if (arg != NULL)
|
|
filter = catch_syscall_split_args (arg);
|
|
|
|
create_syscall_event_catchpoint (tempflag, std::move (filter),
|
|
&catch_syscall_breakpoint_ops);
|
|
}
|
|
|
|
|
|
/* Returns 0 if 'bp' is NOT a syscall catchpoint,
|
|
non-zero otherwise. */
|
|
static int
|
|
is_syscall_catchpoint_enabled (struct breakpoint *bp)
|
|
{
|
|
if (syscall_catchpoint_p (bp)
|
|
&& bp->enable_state != bp_disabled
|
|
&& bp->enable_state != bp_call_disabled)
|
|
return 1;
|
|
else
|
|
return 0;
|
|
}
|
|
|
|
int
|
|
catch_syscall_enabled (void)
|
|
{
|
|
struct catch_syscall_inferior_data *inf_data
|
|
= get_catch_syscall_inferior_data (current_inferior ());
|
|
|
|
return inf_data->total_syscalls_count != 0;
|
|
}
|
|
|
|
/* Helper function for catching_syscall_number. If B is a syscall
|
|
catchpoint for SYSCALL_NUMBER, return 1 (which will make
|
|
'breakpoint_find_if' return). Otherwise, return 0. */
|
|
|
|
static int
|
|
catching_syscall_number_1 (struct breakpoint *b,
|
|
void *data)
|
|
{
|
|
int syscall_number = (int) (uintptr_t) data;
|
|
|
|
if (is_syscall_catchpoint_enabled (b))
|
|
{
|
|
struct syscall_catchpoint *c = (struct syscall_catchpoint *) b;
|
|
|
|
if (!c->syscalls_to_be_caught.empty ())
|
|
{
|
|
for (int iter : c->syscalls_to_be_caught)
|
|
if (syscall_number == iter)
|
|
return 1;
|
|
}
|
|
else
|
|
return 1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int
|
|
catching_syscall_number (int syscall_number)
|
|
{
|
|
struct breakpoint *b = breakpoint_find_if (catching_syscall_number_1,
|
|
(void *) (uintptr_t) syscall_number);
|
|
|
|
return b != NULL;
|
|
}
|
|
|
|
/* Complete syscall names. Used by "catch syscall". */
|
|
|
|
static void
|
|
catch_syscall_completer (struct cmd_list_element *cmd,
|
|
completion_tracker &tracker,
|
|
const char *text, const char *word)
|
|
{
|
|
struct gdbarch *gdbarch = get_current_arch ();
|
|
gdb::unique_xmalloc_ptr<const char *> group_list;
|
|
const char *prefix;
|
|
|
|
/* Completion considers ':' to be a word separator, so we use this to
|
|
verify whether the previous word was a group prefix. If so, we
|
|
build the completion list using group names only. */
|
|
for (prefix = word; prefix != text && prefix[-1] != ' '; prefix--)
|
|
;
|
|
|
|
if (startswith (prefix, "g:") || startswith (prefix, "group:"))
|
|
{
|
|
/* Perform completion inside 'group:' namespace only. */
|
|
group_list.reset (get_syscall_group_names (gdbarch));
|
|
if (group_list != NULL)
|
|
complete_on_enum (tracker, group_list.get (), word, word);
|
|
}
|
|
else
|
|
{
|
|
/* Complete with both, syscall names and groups. */
|
|
gdb::unique_xmalloc_ptr<const char *> syscall_list
|
|
(get_syscall_names (gdbarch));
|
|
group_list.reset (get_syscall_group_names (gdbarch));
|
|
|
|
const char **group_ptr = group_list.get ();
|
|
|
|
/* Hold on to strings while we're using them. */
|
|
std::vector<std::string> holders;
|
|
|
|
/* Append "group:" prefix to syscall groups. */
|
|
for (int i = 0; group_ptr[i] != NULL; i++)
|
|
holders.push_back (string_printf ("group:%s", group_ptr[i]));
|
|
|
|
for (int i = 0; group_ptr[i] != NULL; i++)
|
|
group_ptr[i] = holders[i].c_str ();
|
|
|
|
if (syscall_list != NULL)
|
|
complete_on_enum (tracker, syscall_list.get (), word, word);
|
|
if (group_list != NULL)
|
|
complete_on_enum (tracker, group_ptr, word, word);
|
|
}
|
|
}
|
|
|
|
static void
|
|
clear_syscall_counts (struct inferior *inf)
|
|
{
|
|
struct catch_syscall_inferior_data *inf_data
|
|
= get_catch_syscall_inferior_data (inf);
|
|
|
|
inf_data->total_syscalls_count = 0;
|
|
inf_data->any_syscall_count = 0;
|
|
inf_data->syscalls_counts.clear ();
|
|
}
|
|
|
|
static void
|
|
initialize_syscall_catchpoint_ops (void)
|
|
{
|
|
struct breakpoint_ops *ops;
|
|
|
|
initialize_breakpoint_ops ();
|
|
|
|
/* Syscall catchpoints. */
|
|
ops = &catch_syscall_breakpoint_ops;
|
|
*ops = base_breakpoint_ops;
|
|
ops->insert_location = insert_catch_syscall;
|
|
ops->remove_location = remove_catch_syscall;
|
|
ops->breakpoint_hit = breakpoint_hit_catch_syscall;
|
|
ops->print_it = print_it_catch_syscall;
|
|
ops->print_one = print_one_catch_syscall;
|
|
ops->print_mention = print_mention_catch_syscall;
|
|
ops->print_recreate = print_recreate_catch_syscall;
|
|
}
|
|
|
|
void _initialize_break_catch_syscall ();
|
|
void
|
|
_initialize_break_catch_syscall ()
|
|
{
|
|
initialize_syscall_catchpoint_ops ();
|
|
|
|
gdb::observers::inferior_exit.attach (clear_syscall_counts);
|
|
|
|
add_catch_command ("syscall", _("\
|
|
Catch system calls by their names, groups and/or numbers.\n\
|
|
Arguments say which system calls to catch. If no arguments are given,\n\
|
|
every system call will be caught. Arguments, if given, should be one\n\
|
|
or more system call names (if your system supports that), system call\n\
|
|
groups or system call numbers."),
|
|
catch_syscall_command_1,
|
|
catch_syscall_completer,
|
|
CATCH_PERMANENT,
|
|
CATCH_TEMPORARY);
|
|
}
|